[Devel] Re: fix for Radius failed query logging

[Peter Nixon]

OK. This _looks_ like a RADIUS accounting packet, and the patch doesn't look 
horrible, but with the exception of the following in RFC 2866 I can't find 
anything mentioning "Acct-Status-Type = Failed" as being valid:

5.1.  Acct-Status-Type

   Description

      This attribute indicates whether this Accounting-Request marks the
      beginning of the user service (Start) or the end (Stop).

      It MAY be used by the client to mark the start of accounting (for
      example, upon booting) by specifying Accounting-On and to mark the
      end of accounting (for example, just before a scheduled reboot) by
      specifying Accounting-Off.

 --snip--

      The Value field is four octets.

       1      Start
       2      Stop
       3      Interim-Update
       7      Accounting-On
       8      Accounting-Off
       9-14   Reserved for Tunnel Accounting
      15      Reserved for Failed       <------------------***************


Based on which RFC does SER generate RADIUS accounting packets 
with  "Acct-Status-Type = Failed"?

I am CCing this mail to the FreeRADIUS devel list also. (I suggest that those 
of you on the SER list interested in this patch should join freeradius-devel 
also)

Proposed patch to enable Acct-Status-Type = Failed support in FreeRADIUS at:
http://download.dns-hosting.info/CDRTool/freeradius/freeradius-cvs-failed-accounting.diff

Cheers

Peter

On Thu 16 Nov 2006 19:30, Adrian Georgescu wrote:
> We use this for logging of Radius packets type Failed, which are
> generated by negative codes in OpenSER.
>
> For example this Radius packet will not end up in sql without the
> patch applied:
>
> Thu Nov 16 18:28:01 2006
>          Acct-Status-Type = Failed
>          Service-Type = Sip-Session
>          Sip-Response-Code = 487
>          Sip-Method = Invite
>          User-Name = "Unknown at gw02-mci.budgetphone.nl"
>          Calling-Station-Id = "sip:Unknown at gw02-mci.budgetphone.nl"
>          Called-Station-Id = "sip:31402910153 at budgetphone.nl"
>          Sip-Translated-Request-URI = "sip:
> 31402910153 at 192.168.2.115:5060"
>          Acct-Session-Id = "5b6bb3eb297fb5c14ac8052d7bbd2904 at gw02-
> mci.budgetphone.nl"
>          Sip-To-Tag = "f5c8a2d2f16cd3f7i0"
>          Sip-From-Tag = "as42ed4c4a"
>          Sip-Cseq = "102"
>          Source-IP = "193.67.155.227"
>          Source-Port = "5060"
>          Canonical-URI = "sip:31402910153 at budgetphone.nl"
>          Billing-Party = "Unknown at gw02-mci.budgetphone.nl"
>          From-Header = ""Unknown" <sip:Unknown at gw02-
> mci.budgetphone.nl>;tag=as42ed4c4a"
>          SIP-Proxy = "81.23.228.150"
>          NAS-IP-Address = 10.0.0.139
>          Client-IP-Address = 10.0.0.139
>          Acct-Unique-Session-Id = "60b16bfb79b215b1"
>          Timestamp = 1163698081
>
> On Nov 16, 2006, at 6:25 PM, Klaus Darilion wrote:
> > Hi!
> >
> > Maybe someone can explain shortly what this feature is and where it
> > is needed? I'm using radius accounting but never had any issues
> > (maybe because I'm using radiator).
> >
> > regards
> > klaus
> >
> > Adrian Georgescu wrote:
> >> Hello Petter,
> >> The patch is available at:
> >> http://download.dns-hosting.info/CDRTool/freeradius/freeradius-cvs-
> >> failed-accounting.diff On Nov 16, 2006, at 5:09 PM, Peter Nixon
> >>
> >> wrote:
> >>> On Wed 15 Nov 2006 23:07, Adrian Georgescu wrote:
> >>>> Hello Peter,
> >>>>
> >>>> Thank you for helping us with including the OpenSER radius
> >>>> attributes
> >>>> in the mainstream Freeradius dictionary,
> >>>>
> >>>> Can you help the OpenSER community to have the failed query
> >>>> accepted
> >>>> by the Freeradius? We currently keep patches for Freeradius with
> >>>> this
> >>>> functionality and all who could help so far seem to be more
> >>>> interested in seeing some RFCs about the problem instead of fixing
> >>>> the code.
> >>>>
> >>>> Can you help?
> >>>
> >>> Hi Adrian
> >>>
> >>> I haven't seen the patch myself, so if you can send it to me with a
> >>> description of what it is supposed to accomplish I will take a
> >>> look at it.
> >>>
> >>> Cheers
> >>> --
> >>> Peter Nixon
> >>> http://www.peternixon.net/
> >>> PGP Key: http://www.peternixon.net/public.asc
> >>
> >> _______________________________________________
> >> Devel mailing list
> >> Devel at openser.org
> >> http://openser.org/cgi-bin/mailman/listinfo/devel
> >
> > --
> > Klaus Darilion
> > nic.at

-- 

Peter Nixon
http://www.peternixon.net/
PGP Key: http://www.peternixon.net/public.asc