sql module, postgresql driver

Peter Nixon listuser at peternixon.net
Mon Jan 8 17:16:57 CET 2007

On Tue 02 Jan 2007 00:41, FreeRadius Devel wrote:
> hello,
> in case of a fatal error that occurs on the postgresql database server
> the sql accounting module returns "ok" so the "redundancy" feature of
> freeradius does not work.
> in file src/modules/rlm_sql/drivers/rlm_sql_postgresql/sql_postgresql.c,
> function sql_check_error I see that for non "SQL_DOWN" errors it returns
> 0, should  it be -1 ? a non zero value ?

You Are correct. Fixed now.

Look out for a further monster (60+ line) patch to sql_postgresql.c in the 
next few hours. I am just putting it through testing at the moment. It fixes 
some other edge cases and a memory leak reported in Bug 413


Peter Nixon
PGP Key: http://www.peternixon.net/public.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.freeradius.org/pipermail/freeradius-devel/attachments/20070108/ffeab5e5/attachment.pgp>

More information about the Freeradius-Devel mailing list