little bugs that appear to have appeared ...

[wlan at mac.com]

Hi,

In auth.c, there is:

713         /*
714          *      Result should be >= 0 here - if not, it means the  
user
715          *      is rejected, so we just process post-auth and  
return.
716          */
717         if (result < 0) {
718                 return RLM_MODULE_REJECT;
719         }

Should this be the following instead (like the comment suggests?)

         /*
          *      Result should be >= 0 here - if not, it means the user
          *      is rejected, so we just process post-auth and return.
          */
         if (result < 0) {
                 return rad_postauth(request);
         }

Also, I updated from cvs this morning, but had some problems related  
to SNMP:

- do_snmp was missing from main_config_t
- radius_snmp_init() is prototyped to return int, when in fact it is  
void

Cheers,
David



On Sep 27, 2007, at 1:38 PM, Alan DeKok wrote:

> Arran Cudbard-Bell wrote:
>> 2 good passwords found, should not be be being warned.
>
>   Yeah, that's a minor issue.
>
>> update reply in the Post-Auth-Type blocks doesn't work.
>>
>> %{reply:Event-Type} in the sql query expands to ''
>
>   Which SQL query?  The one in the "sql" module, or the one in the
> "sql_roaming" module?  Note that the attr_filter module is listed
> between the two.  It will REMOVE any attributes that aren't  
> supposed to
> go in an Access-Reject... like Event-Type.
>
>   Alan DeKok.
> -
> List info/subscribe/unsubscribe? See http://www.freeradius.org/list/ 
> devel.html