rlm_sql: default Acct-On/Off query for all backends is somewhat bogus

Arran Cudbard-Bell A.Cudbard-Bell at sussex.ac.uk
Sun May 4 23:36:53 CEST 2008

A.L.M.Buxey at lboro.ac.uk wrote:
> Hi,
> I got bit by this issue - and the code still expects that acctsessiontime
> not NULL when a stop packet etc arrives.....have a work around
> in my sites-enable/default which only fires up the detail module
> if acct-session-time != 0      bad muju
> anyway, found another issue whilst away.  we are getting
> accounting packets thrown through the detail module
> thta dont actually have any accouting status type etc. 
> looks like they've been stripped out by the remote
> RADIUS server..... so the accouting packet doesnt have
> anything useful inside.  unfortunately, when the
> detail module hits these it just complains bitterly
> all the time. rather than taking them for the duff
> packet that they are.  any chance that the code can
> see the naff packet for what it is and just ditch it?

Exactly the same problem but with buggy NAS, already complained bitterly 
to Alan D.

His suggestion was

	sql {
		invalid = 2
	if (invalid) {

In the accounting detail reader instance.

What you really want is if a section returns invalid, the packet is 
counted as processed.

> alan
> -
> List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html

More information about the Freeradius-Devel mailing list