request->packet == NULL. Possible bug (simple example is provided).

Dmitry V. Krivenok krivenok.dmitry at gmail.com
Mon Oct 27 21:26:17 CET 2008


Hello!

Please look at the simplest rlm I wrote to demonstrate strange problem:

krivenok at develop2 22:21:06 ~/work/svn/libs/rlm_osb/trunk $ cat rlm_osb.c
#include <freeradius-devel/radiusd.h>
#include <freeradius-devel/modules.h>

///////////////////////////////////////////////////////////////////////////////

static int osb_instantiate(CONF_SECTION *conf, void **instance)
{
  return 0;
}

///////////////////////////////////////////////////////////////////////////////

static int osb_authorize(void *inst, REQUEST *request)
{
  DEBUG("rlm_osb: REQUEST %p", request);
  DEBUG("rlm_osb: PACKET  %p", request->packet);
  return RLM_MODULE_NOOP;
}

///////////////////////////////////////////////////////////////////////////////

static int osb_detach(void *instance)
{
  return 0;
}

///////////////////////////////////////////////////////////////////////////////

module_t rlm_osb = {
        RLM_MODULE_INIT,
        "osb",
        RLM_TYPE_THREAD_SAFE,           /* type */
        osb_instantiate,                /* instantiation */
        osb_detach,                     /* detach */
        {
                NULL,                   /* authentication */
                osb_authorize,          /* authorization */
                NULL,                   /* preaccounting */
                NULL,                   /* accounting */
                NULL,                   /* checksimul */
                NULL,                   /* pre-proxy */
                NULL,                   /* post-proxy */
                NULL                    /* post-auth */
        },
};

///////////////////////////////////////////////////////////////////////////////
krivenok at develop2 22:21:10 ~/work/svn/libs/rlm_osb/trunk $ make
gcc -g -fPIC -DPIC -c -MD  -Wall 
-I/home/krivenok/dev_builds/freeradius-server-current/src/  rlm_osb.c
gcc -g -shared -Wl,-soname,rlm_osb-current.so -o rlm_osb-current.so 
rlm_osb.o
krivenok at develop2 22:21:25 ~/work/svn/libs/rlm_osb/trunk $ sudo make install
install rlm_osb-current.so /usr/local/fr_curr/lib
ln -fs /usr/local/fr_curr/lib/rlm_osb-current.so 
/usr/local/fr_curr/lib/rlm_osb.so
krivenok at develop2 22:21:37 ~/work/svn/libs/rlm_osb/trunk $


So far, so good.
Module was compiled and installed successfully.

The latest freeradius version is used (got via git):

krivenok at develop2 22:19:03 /usr/local/fr_curr/sbin $ sudo ./radiusd -v
radiusd: FreeRADIUS Version 2.1.2, for host i686-pc-linux-gnu, built on 
Oct 27 2008 at 19:29:35
Copyright (C) 1999-2008 The FreeRADIUS server project and contributors.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.
You may redistribute copies of FreeRADIUS under the terms of the
GNU General Public License.
For more information about these matters, see the file named COPYRIGHT.
krivenok at develop2 22:19:11 /usr/local/fr_curr/sbin $


Lets start the server in debug mode:

krivenok at develop2 22:37:21 /usr/local/fr_curr/sbin $ sudo ./radiusd -X
FreeRADIUS Version 2.1.2, for host i686-pc-linux-gnu, built on Oct 27 
2008 at 19:29:35
Copyright (C) 1999-2008 The FreeRADIUS server project and contributors.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.
You may redistribute copies of FreeRADIUS under the terms of the
GNU General Public License v2.
Starting - reading configuration files ...
including configuration file /usr/local/fr_curr/etc/raddb/radiusd.conf
including configuration file /usr/local/fr_curr/etc/raddb/proxy.conf
including configuration file /usr/local/fr_curr/etc/raddb/clients.conf
including files in directory /usr/local/fr_curr/etc/raddb/modules/
including configuration file 
/usr/local/fr_curr/etc/raddb/modules/attr_filter
including configuration file /usr/local/fr_curr/etc/raddb/modules/ippool
including configuration file /usr/local/fr_curr/etc/raddb/modules/expr
including configuration file 
/usr/local/fr_curr/etc/raddb/modules/acct_unique
including configuration file /usr/local/fr_curr/etc/raddb/modules/counter
including configuration file /usr/local/fr_curr/etc/raddb/modules/osb
including configuration file /usr/local/fr_curr/etc/raddb/modules/policy
including configuration file /usr/local/fr_curr/etc/raddb/modules/logintime
including configuration file /usr/local/fr_curr/etc/raddb/modules/mac2ip
including configuration file /usr/local/fr_curr/etc/raddb/modules/sradutmp
including configuration file /usr/local/fr_curr/etc/raddb/modules/wimax
including configuration file /usr/local/fr_curr/etc/raddb/modules/digest
including configuration file /usr/local/fr_curr/etc/raddb/modules/perl
including configuration file /usr/local/fr_curr/etc/raddb/modules/mac2vlan
including configuration file /usr/local/fr_curr/etc/raddb/modules/krb5
including configuration file /usr/local/fr_curr/etc/raddb/modules/passwd
including configuration file /usr/local/fr_curr/etc/raddb/modules/unix
including configuration file /usr/local/fr_curr/etc/raddb/modules/detail.log
including configuration file /usr/local/fr_curr/etc/raddb/modules/chap
including configuration file /usr/local/fr_curr/etc/raddb/modules/radutmp
including configuration file /usr/local/fr_curr/etc/raddb/modules/smbpasswd
including configuration file 
/usr/local/fr_curr/etc/raddb/modules/attr_rewrite
including configuration file /usr/local/fr_curr/etc/raddb/modules/always
including configuration file /usr/local/fr_curr/etc/raddb/modules/realm
including configuration file /usr/local/fr_curr/etc/raddb/modules/echo
including configuration file /usr/local/fr_curr/etc/raddb/modules/mschap
including configuration file /usr/local/fr_curr/etc/raddb/modules/inner-eap
including configuration file /usr/local/fr_curr/etc/raddb/modules/files
including configuration file 
/usr/local/fr_curr/etc/raddb/modules/detail.example.com
including configuration file /usr/local/fr_curr/etc/raddb/modules/preprocess
including configuration file /usr/local/fr_curr/etc/raddb/modules/pam
including configuration file /usr/local/fr_curr/etc/raddb/modules/sql_log
including configuration file /usr/local/fr_curr/etc/raddb/modules/pap
including configuration file /usr/local/fr_curr/etc/raddb/modules/linelog
including configuration file /usr/local/fr_curr/etc/raddb/modules/ldap
including configuration file /usr/local/fr_curr/etc/raddb/modules/etc_group
including configuration file /usr/local/fr_curr/etc/raddb/modules/checkval
including configuration file /usr/local/fr_curr/etc/raddb/modules/expiration
including configuration file /usr/local/fr_curr/etc/raddb/modules/detail
including configuration file /usr/local/fr_curr/etc/raddb/modules/exec
including configuration file /usr/local/fr_curr/etc/raddb/eap.conf
including configuration file /usr/local/fr_curr/etc/raddb/sql.conf
including configuration file 
/usr/local/fr_curr/etc/raddb/sql/mysql/dialup.conf
including configuration file 
/usr/local/fr_curr/etc/raddb/sql/mysql/counter.conf
including configuration file /usr/local/fr_curr/etc/raddb/policy.conf
including files in directory /usr/local/fr_curr/etc/raddb/sites-enabled/
including configuration file 
/usr/local/fr_curr/etc/raddb/sites-enabled/inner-tunnel
including configuration file 
/usr/local/fr_curr/etc/raddb/sites-enabled/default
including dictionary file /usr/local/fr_curr/etc/raddb/dictionary
main {
        prefix = "/usr/local/fr_curr"
        localstatedir = "/usr/local/fr_curr/var"
        logdir = "/usr/local/fr_curr/var/log/radius"
        libdir = "/usr/local/fr_curr/lib"
        radacctdir = "/usr/local/fr_curr/var/log/radius/radacct"
        hostname_lookups = no
        max_request_time = 30
        cleanup_delay = 5
        max_requests = 1024
        allow_core_dumps = no
        pidfile = "/usr/local/fr_curr/var/run/radiusd/radiusd.pid"
        checkrad = "/usr/local/fr_curr/sbin/checkrad"
        debug_level = 0
        proxy_requests = yes
 log {
        stripped_names = no
        auth = no
        auth_badpass = no
        auth_goodpass = no
 }
 security {
        max_attributes = 200
        reject_delay = 1
        status_server = yes
 }
}
 client localhost {
        ipaddr = 127.0.0.1
        require_message_authenticator = no
        secret = "testing123"
        nastype = "other"
 }
radiusd: #### Loading Realms and Home Servers ####
 proxy server {
        retry_delay = 5
        retry_count = 3
        default_fallback = no
        dead_time = 120
        wake_all_if_all_dead = no
 }
 home_server localhost {
        ipaddr = 127.0.0.1
        port = 1812
        type = "auth"
        secret = "testing123"
        response_window = 20
        max_outstanding = 65536
        zombie_period = 40
        status_check = "status-server"
        ping_interval = 30
        check_interval = 30
        num_answers_to_alive = 3
        num_pings_to_alive = 3
        revive_interval = 120
        status_check_timeout = 4
 }
 home_server_pool my_auth_failover {
        type = fail-over
        home_server = localhost
 }
 realm example.com {
        auth_pool = my_auth_failover
 }
 realm LOCAL {
 }
radiusd: #### Instantiating modules ####
 instantiate {
 Module: Linked to module rlm_exec
 Module: Instantiating exec
  exec {
        wait = no
        input_pairs = "request"
        shell_escape = yes
  }
 Module: Linked to module rlm_expr
 Module: Instantiating expr
 Module: Linked to module rlm_expiration
 Module: Instantiating expiration
  expiration {
        reply-message = "Password Has Expired  "
  }
 Module: Linked to module rlm_logintime
 Module: Instantiating logintime
  logintime {
        reply-message = "You are calling outside your allowed timespan  "
        minimum-timeout = 60
  }
 }
radiusd: #### Loading Virtual Servers ####
server inner-tunnel {
 modules {
 Module: Checking authenticate {...} for more modules to load
 Module: Linked to module rlm_pap
 Module: Instantiating pap
  pap {
        encryption_scheme = "auto"
        auto_header = no
  }
 Module: Linked to module rlm_chap
 Module: Instantiating chap
 Module: Linked to module rlm_mschap
 Module: Instantiating mschap
  mschap {
        use_mppe = yes
        require_encryption = no
        require_strong = no
        with_ntdomain_hack = no
  }
 Module: Linked to module rlm_unix
 Module: Instantiating unix
  unix {
        radwtmp = "/usr/local/fr_curr/var/log/radius/radwtmp"
  }
 Module: Linked to module rlm_eap
 Module: Instantiating eap
  eap {
        default_eap_type = "md5"
        timer_expire = 60
        ignore_unknown_eap_types = no
        cisco_accounting_username_bug = no
        max_sessions = 2048
  }
 Module: Linked to sub-module rlm_eap_md5
 Module: Instantiating eap-md5
 Module: Linked to sub-module rlm_eap_leap
 Module: Instantiating eap-leap
 Module: Linked to sub-module rlm_eap_gtc
 Module: Instantiating eap-gtc
   gtc {
        challenge = "Password: "
        auth_type = "PAP"
   }
 Module: Linked to sub-module rlm_eap_tls
 Module: Instantiating eap-tls
   tls {
        rsa_key_exchange = no
        dh_key_exchange = yes
        rsa_key_length = 512
        dh_key_length = 512
        verify_depth = 0
        pem_file_type = yes
        private_key_file = "/usr/local/fr_curr/etc/raddb/certs/server.pem"
        certificate_file = "/usr/local/fr_curr/etc/raddb/certs/server.pem"
        CA_file = "/usr/local/fr_curr/etc/raddb/certs/ca.pem"
        private_key_password = "whatever"
        dh_file = "/usr/local/fr_curr/etc/raddb/certs/dh"
        random_file = "/usr/local/fr_curr/etc/raddb/certs/random"
        fragment_size = 1024
        include_length = yes
        check_crl = no
        cipher_list = "DEFAULT"
        make_cert_command = "/usr/local/fr_curr/etc/raddb/certs/bootstrap"
    cache {
        enable = no
        lifetime = 24
        max_entries = 255
    }
   }
 Module: Linked to sub-module rlm_eap_ttls
 Module: Instantiating eap-ttls
   ttls {
        default_eap_type = "md5"
        copy_request_to_tunnel = no
        use_tunneled_reply = no
        virtual_server = "inner-tunnel"
   }
 Module: Linked to sub-module rlm_eap_peap
 Module: Instantiating eap-peap
   peap {
        default_eap_type = "mschapv2"
        copy_request_to_tunnel = no
        use_tunneled_reply = no
        proxy_tunneled_request_as_eap = yes
        virtual_server = "inner-tunnel"
   }
 Module: Linked to sub-module rlm_eap_mschapv2
 Module: Instantiating eap-mschapv2
   mschapv2 {
        with_ntdomain_hack = no
   }
 Module: Checking authorize {...} for more modules to load
 Module: Linked to module rlm_realm
 Module: Instantiating suffix
  realm suffix {
        format = "suffix"
        delimiter = "@"
        ignore_default = no
        ignore_null = no
  }
 Module: Linked to module rlm_files
 Module: Instantiating files
  files {
        usersfile = "/usr/local/fr_curr/etc/raddb/users"
        acctusersfile = "/usr/local/fr_curr/etc/raddb/acct_users"
        preproxy_usersfile = "/usr/local/fr_curr/etc/raddb/preproxy_users"
        compat = "no"
  }
 Module: Checking session {...} for more modules to load
 Module: Linked to module rlm_radutmp
 Module: Instantiating radutmp
  radutmp {
        filename = "/usr/local/fr_curr/var/log/radius/radutmp"
        username = "%{User-Name}"
        case_sensitive = yes
        check_with_nas = yes
        perm = 384
        callerid = yes
  }
 Module: Checking post-proxy {...} for more modules to load
 Module: Checking post-auth {...} for more modules to load
 Module: Linked to module rlm_attr_filter
 Module: Instantiating attr_filter.access_reject
  attr_filter attr_filter.access_reject {
        attrsfile = "/usr/local/fr_curr/etc/raddb/attrs.access_reject"
        key = "%{User-Name}"
  }
 }
}
 modules {
 Module: Checking authenticate {...} for more modules to load
 Module: Checking authorize {...} for more modules to load
 Module: Linked to module rlm_preprocess
 Module: Instantiating preprocess
  preprocess {
        huntgroups = "/usr/local/fr_curr/etc/raddb/huntgroups"
        hints = "/usr/local/fr_curr/etc/raddb/hints"
        with_ascend_hack = no
        ascend_channels_per_line = 23
        with_ntdomain_hack = no
        with_specialix_jetstream_hack = no
        with_cisco_vsa_hack = no
        with_alvarion_vsa_hack = no
  }
 Module: Linked to module rlm_osb
 Module: Instantiating osb
 Module: Checking preacct {...} for more modules to load
 Module: Linked to module rlm_acct_unique
 Module: Instantiating acct_unique
  acct_unique {
        key = "User-Name, Acct-Session-Id, NAS-IP-Address, 
Client-IP-Address, NAS-Port"
  }
 Module: Checking accounting {...} for more modules to load
 Module: Linked to module rlm_detail
 Module: Instantiating detail
  detail {
        detailfile = 
"/usr/local/fr_curr/var/log/radius/radacct/%{Client-IP-Address}/detail-%Y%m%d"
        header = "%t"
        detailperm = 384
        dirperm = 493
        locking = no
        log_packet_header = no
  }
 Module: Instantiating attr_filter.accounting_response
  attr_filter attr_filter.accounting_response {
        attrsfile = "/usr/local/fr_curr/etc/raddb/attrs.accounting_response"
        key = "%{User-Name}"
  }
 Module: Checking session {...} for more modules to load
 Module: Checking post-proxy {...} for more modules to load
 Module: Checking post-auth {...} for more modules to load
 }
radiusd: #### Opening IP addresses and Ports ####
listen {
        type = "auth"
        ipaddr = *
        port = 0
}
listen {
        type = "acct"
        ipaddr = *
        port = 0
}
Listening on auth address * port 1812
Listening on acct address * port 1813
Listening on proxy address * port 1814
Ready to process requests.


and then send test packet:


krivenok at develop2 22:37:39 /usr/local/fr_curr/bin $ cat ~/radius_test.txt
User-Name = "some_user"
User-Password = "some_pass"
Nas-Ip-Address = "192.168.1.1"
krivenok at develop2 22:39:08 /usr/local/fr_curr/bin $ cat 
~/radius_test.txt  | sudo ./radclient localhost auth testing123
Received response ID 140, code 3, length = 20
krivenok at develop2 22:39:15 /usr/local/fr_curr/bin $



Lets look at daemon's output:


rad_recv: Access-Request packet from host 127.0.0.1 port 29966, id=140, 
length=55
        User-Name = "some_user"
        User-Password = "some_pass"
        NAS-IP-Address = 192.168.1.1
+- entering group authorize {...}
++[preprocess] returns ok
rlm_osb: REQUEST 0x8174730
rlm_osb: PACKET  (nil)
++[osb] returns noop
++[chap] returns noop
++[mschap] returns noop
[suffix] No '@' in User-Name = "some_user", looking up realm NULL
[suffix] No such realm "NULL"
++[suffix] returns noop
[eap] No EAP-Message, not doing EAP
++[eap] returns noop
++[unix] returns notfound
++[files] returns noop
++[expiration] returns noop
++[logintime] returns noop
[pap] WARNING! No "known good" password found for the user.  
Authentication may fail because of this.
++[pap] returns noop
No authenticate method (Auth-Type) configuration found for the request: 
Rejecting the user
Failed to authenticate the user.
Using Post-Auth-Type Reject
+- entering group REJECT {...}
[attr_filter.access_reject]     expand: %{User-Name} -> some_user
 attr_filter: Matched entry DEFAULT at line 11
++[attr_filter.access_reject] returns updated
Delaying reject of request 0 for 1 seconds
Going to the next request
Waking up in 0.9 seconds.
Sending delayed reject for request 0
Sending Access-Reject of id 140 to 127.0.0.1 port 29966
Waking up in 4.9 seconds.
Cleaning up request 0 ID 140 with timestamp +68
Ready to process requests.


What about the following output?

rlm_osb: REQUEST 0x8174730
rlm_osb: PACKET  (nil)
++[osb] returns noop


request->packet is NULL.

It looks like a bug. Isn't it?

According to this output, request was received properly:

        User-Name = "some_user"
        User-Password = "some_pass"
        NAS-IP-Address = 192.168.1.1

However request->packet field is NULL.

Any ideas?


P.S.
All worked fine with freeradius-2.0.5.



More information about the Freeradius-Devel mailing list