Patch for raddb/sql/mysql/ippool.conf

Alan DeKok aland at deployingradius.com
Mon Aug 3 11:34:31 CEST 2009


Chris Moules wrote:
> Sorry this is not a GIT patch.
> 
> Here are two minor fixes to the MySQL ippool.conf file.
> 
> 1) A Syntax correction for the alternative 'allocate-find' query.

  Uh... which version of MySQL are you using?  The examples were changed
FROM "is null" TO '= null" in January.

> 2) There was an issue with the 'start-update' query updating more than
> it should.
> I am using IMSI codes as my pool-key. In the case that a phone
> disconnects, but no Acct-Stop is received the expiry_time is updated
> every time that this phone reconnects as only the NAS and the pool-key
> are used as update limiters.
> 
> By including at least the framedipaddress this is solved.

  OK.

> As both the 'stop-clear' and 'alive-update' sections are using the 3
> additional qualifiers, it makes sense to use them here too. (I see no
> reason no to).

  Looks good to me.

  Alan DeKok.



More information about the Freeradius-Devel mailing list