freeradius-client rc_avpair_log() function

[Alex Massover]

Hi,

AFAIU, rc_avpair_log() function in freeradius-client is not thread-safe, it uses a shared buffer (rh->ppbuf).

So one can't have shared rc_handle if calling to rc_avpair_log() from different threads.

Please tell me if that's correct and I'll make a simple patch changing:

rc_avpair_log(rc_handle *rh, VALUE_PAIR *pair)
to
rc_avpair_log(rc_handle *rh, VALUE_PAIR *pair, char *buf, size_t l)

This way a caller will provide a non-shared buffer.

--
Best Regards,
Alex Massover
VoIP R&D TL
Jajah Inc.


This mail was sent via Mail-SeCure System.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freeradius.org/pipermail/freeradius-devel/attachments/20100201/5c194110/attachment.html>