vmps request: long attribute VQP-Ethernet-Frame again

[Alan DeKok]

Hermann Lauer wrote:
> Unfortunately the cutting solution which was included after the discussion above was no
> completely correct, because the vqp_recv routine has to skip the complete ethernet packet
> in checking as otherwise the rest would be interpeted as garbage, which makes
> the server rejecting the packet with a "Packet contains invalid attribute"
> message. The appended patch tries to fix this, but now memory errors occurs:
> 
> *** glibc detected *** /usr/sbin/freeradius: corrupted double-linked list: 0x00166cd0 ***
> Aborted
> 
> Any ideas ?

  'attrlen' can't be more than 253, otherwise it overflows the buffer
that is associated with the attribute.

  It's OK to *process* more than 253 bytes from a packet.  You just
can't *copy* more than 253 into the vp->vp_octets buffer.

  Alan DeKok.