Patch: avpair.c - empty reply VALUE_PAIR (0x0) for replies with unknown vendor attributes

[Stefan Karss]

Hello Adam,

I guess my description was a bit confusing - "first recursion" means the
first recursion instance in that bit of messy code ;-). So wherever an
unknown vendor happens the reply pointer is NULL.

Try my patch and see if it helps. If I remember correctly someone on the
list wanted to submit another patch that translates unknown
attributes/vendors into a special syntax - but I'm not sure if it has
already been submitted.

Rgds,
Stefan

On Tue, Jun 15, 2010 at 10:12 AM, Adam Lewis <VNQM87 at motorola.com> wrote:

>
> I also seem to be having a problem with attributes that should be ignored
> but
> otherwise have no effect on the other attributes in a reply.
>
> If an attribute from an unknown vendor happens to be the very last
> attribute
> in the list, rc_avpair_gen() ignores it by returning pair immediately. The
> only problem being pair is still set to the entry value of NULL and this
> ripples up through all the recursive calls, which means all the other
> attributes get ignored as well. Has anybody else seen this?
>
> Adam.
>
>
> Stefan Karss wrote:
> >
> > Hello again,
> >
> > when the RADIUS servers sends a reply packet with an attribute for an
> > unknown vendor freeradius-client just skips over this when filling
> > response
> > VALUE_PAIR list. Unfortunately it doesn't for unknown attributes from
> > known
> > vendors - in that case rc_avpair_gen returns NULL in the first recursion
> > which results in a NULL pointer for reply VALUE_PAIR.
> >
> > The attached patch just skips over unknown attributes for known vendors
> > just
> > like the lib skips over attributes from unknown vendors.
> >
> > Rgds,
> > Stefan
> >
> >
> > -
> > List info/subscribe/unsubscribe? See
> > http://www.freeradius.org/list/devel.html
> >
>
> --
> View this message in context:
> http://old.nabble.com/Patch%3A-avpair.c---empty-reply-VALUE_PAIR-%280x0%29-for-replies-with--unknown-vendor-attributes-tp28313256p28888431.html
> Sent from the FreeRadius - Dev mailing list archive at Nabble.com.
>
> -
> List info/subscribe/unsubscribe? See
> http://www.freeradius.org/list/devel.html
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freeradius.org/pipermail/freeradius-devel/attachments/20100627/668ce2f0/attachment.html>