Possible patch for memory leak in rlm_wimax

James Ballantine james.ballantine at vividwireless.com.au
Tue Nov 9 07:03:04 CET 2010


Hi again,

We are seeing what I think may be a memory leak inside the rlm_wimax
module: Several HMAC_CTX structures are initialised with
HMAC_CTX_init(), but only the last one seems to be cleaned up with
HMAC_CTX_cleanup().

I've attached a patch which removes the memory leak according to my
tests. However, I don't know if my change is correct - whether a single
HMAC_CTX should be re-used (as I've done in this patch), or whether a
new one should be created and cleaned up for each use. I would
appreciate it if someone with more familiarity than me could review this
change.

Thanks very much,
James
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rlm_wimax-ctx-cleanup.patch
Type: text/x-diff
Size: 2745 bytes
Desc: not available
URL: <http://lists.freeradius.org/pipermail/freeradius-devel/attachments/20101109/6d111dd5/attachment.patch>


More information about the Freeradius-Devel mailing list