Module-Failure-Message creation in rlm_mschap

[Alan DeKok]

Garber, Neal wrote:
> The rlm_mschap change to create the Module-Failure-Message attribute
> creates it on the request chain.  I notice that the original commit on
> 2010-09-10 (35ee205d4e2dcb4fe5e3
> <http://github.com/alandekok/freeradius-server/commit/35ee205d4e2dcb4fe5e34143a06bd9cafd279eeb>)
> had it in the reply.  Then, a subsequent commit intentionally changed it
> to the request (401dcce982f9a9972bc7
> <http://github.com/alandekok/freeradius-server/commit/401dcce982f9a9972bc7bb87d5ee7e0bf3888f3a>). 

  Every other module adds it to the request list.

> Would you be opposed to putting it back on the reply chain?  I ask
> because of the pending change to save the reply attributes upon failure
> to survive the final eap round trip.  If it’s not in the reply chain,
> then it gets lost.  If you’re opposed to this, should the request chain
> be saved as well (or perhaps just save Module-Failure-Message if it exists)?

  Or, copy it from the request to the reply...

  Alan DeKok.