new rlm_sql connection pool logic

[Arran Cudbard-Bell]

Hi All,

Alan mercilessly ripped out all the connection pool logic in rlm_sql and replaced it with calls to the generic connection pool API which is new in 3.0.

In anyone's running an SQL DB and wants to test it'd be much appreciated.

New code is in Master at HEAD.

WARNING: This change breaks compatibility with V2.0 configs, you will need an empty pool { } stanza in each instance of rlm_sql configuration or the server will fail to load. See here https://github.com/alandekok/freeradius-server/blob/master/raddb/modules/sql for the full pool configuration sub-section.

The following configuration items no longer have any effect: num_sql_socks, connect_failure_retry_delay, lifetime, max_queries. Their equivalents are, (start, mix, max, spare), *none* , lifetime, uses.


DEVELOPERS NOTE: From this point onwards any new modules which use a pool of connections, or would benefit from a pool of connections but doesn't use the connection API, will not be accepted. 

Code for connection pool is here:
https://github.com/alandekok/freeradius-server/blob/master/src/main/connection.c

#include <freeradius-devel/connection.h>

-Arran

Arran Cudbard-Bell
a.cudbardb at freeradius.org

Betelwiki, Betelwiki, Betelwiki.... http://wiki.freeradius.org/ !

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freeradius.org/pipermail/freeradius-devel/attachments/20111017/1a4adfd2/attachment.html>