Tabs in SQL queries...

[Arran Cudbard-Bell]

On 23 Jul 2012, at 11:40, Phil Mayers wrote:

> On 23/07/12 10:10, alan buxey wrote:
>> Hi,
>>> What do people think to stripping out tabs in xlated SQL queries so that the debug output is actually readable?
>> 
>> why play with the queries? Why not just strip the space in the debug output - that way, you get
> 
> This is a safer approach IMO.
> 
> Certainly munging them for readability would be good, though.
> 
> One other option, that might be more generally usable, is to modify the config file parser to strip the indent present on the 1st from 2nd and subsequent lines when using continuations. At the moment, this:
> 
> some_query = "select foo from \
>              bar where x=1"
> 
> ...becomes:
> 
> "select foo from               bar where x=1"
> 
> ...whereas the more intuitive result is:
> 
> "select foo from bar where x=1"
> 
> I think this is what leads to the whitespace in debugged SQL queries?

Partially, the other part is arranging the fields into neat columns, and something happening to the line endings if they're escaped.

The problem is more pronounced with the V3.0 style SQL configuration.

https://github.com/arr2036/freeradius-server/blob/ad8813369daa240ce75a3a75630d7da0cba0d11b/raddb/sql/mysql/dialup.conf




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freeradius.org/pipermail/freeradius-devel/attachments/20120723/bb5fb882/attachment.html>