rlm_cache locking (or not)

Phil Mayers p.mayers at imperial.ac.uk
Fri Oct 26 18:38:24 CEST 2012


On 26/10/12 17:20, Arran Cudbard-Bell wrote:
>
> On 26 Oct 2012, at 16:56, Phil Mayers <p.mayers at imperial.ac.uk>
> wrote:
>
>> On 26/10/12 16:28, Arran Cudbard-Bell wrote:
>>
>>> Quick fix would be to change type to RLM_TYPE_THREAD_UNSAFE in
>>> the module_t struct, then it'll go through modcall_single.
>>
>> Ah, I didn't think of that; I've already done this:
>>
>> https://github.com/philmayers/freeradius-server/commit/2250dc653203a43446703a5cb5723b60bfb23b69
>>
>>
>>
:o/
>>
>> Oh well!
>
> That's better for the general case, as it's possible you'll have
> ldap/sql xlat expansions being done through the module which would
> benefit from multithreadedness.
>
> Please send a pull request :)

Will do, let me run it for a couple of hours first though, check it 
doesn't explode or something!


More information about the Freeradius-Devel mailing list