aland at deployingradius.com
Tue Jun 11 17:50:36 CEST 2013
Stelian Ionescu wrote:
> No, it's a regression. On 2.* commas and apostrophes part of the literal
> query as embedded in dialup.conf didn't get escaped, only the various
> expansions; but now the whole query gets escaped .
It's a bug fix.
In 2.x, the '?' character wasn't listed in "safe-characters". Yet it
wasn't escaped. That's wrong.
The expansion functionality was re-written for v3. It's now less
code, with better error messages, and fewer weird corner cases. As a
side effect, the "safe-characters" is now processed correctly.
Previously, it wasn't.
The "safe-characters" list is editable for a reason. If '.' and '?'
should be listed by default, we can go fix that. But the functionality
WILL NOT be reverted. The old code was wrong.
More information about the Freeradius-Devel