Exec problems in FR3.0

[Phil Mayers]

On 13/06/13 17:14, Phil Mayers wrote:
> On 13/06/13 16:24, Franks Andy (RLZ) IT Systems Engineer wrote:
>> Sorry to send yet more emails with issues. I’ve moved to FR3 to test SQL
>> stuff and am having some problems with getting exec modules I previously
>> used to work. I know I could rewrite these in perl, but they worked
>> before in FR2.2.1 and Iwant to solve why they won’t work now.
>
> Confirmed. Looks like a bug has crept into the exec code in HEAD:
>
> 28619 execve(0x6461202e2e2e2000, [0x6461202e2e2e2000,
> 0x77656e20676e6964, 0x2074656b636f7320, 0x7325, 0x612064656c696146,
> 0x727020676e696464, 0x6b636f732079786f,
>   0x7325203a7465, 0x612064656c696146, 0x766520676e696464,
> 0x646e616820746e65, 0x20726f662072656c, 0x2174656b636f73,
> 0x7265206c61746146, 0x6565726620726f72, 0x636f
> 7320676e697a, ...], [/* 2 vars */]) = -1 EFAULT (Bad address)
> 28619 write(1, "\33[1m\33[33m(0) WARNING: myexec : F"..., 91) = 91
>
> Will investigate.
>

Looks like this commit broke things:

https://github.com/FreeRADIUS/freeradius-server/commit/4c3030db2743e682c58a0fba30b43d066f22beb0

What's the rational for rad_expand_xlat having "const" on the argv input 
argument? Doesn't seem useful.