struct fr_connection 'number' label
a.cudbardb at freeradius.org
Wed Jun 26 17:17:39 CEST 2013
On 26 Jun 2013, at 16:12, Aaron Hurt <ahurt at ena.com> wrote:
> Looking through the code here:
> Should fr_connection->number match fr_connection_pool_t->count … it seems as though number is being assigned the incremented value of count and number is a signed int whereas count is an unsigned int? What happens if count grows larger than the max signed int?
> Should both of these be changed to a long or unsigned long to reduce the chance of overflow to a near impossibility?
Arguably, yes. Though it is unlikely that the counters would ever get that high, and there would be no side effects other than a negative integer being displayed.
So yes, may as well make them uint64_t.
Arran Cudbard-Bell <a.cudbardb at freeradius.org>
FreeRADIUS Development Team
More information about the Freeradius-Devel