Commit report for master branch

Sun Mar 3 00:00:04 CET 2013

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server)

======
Reformatting in firebird

Arran Cudbard-Bell at 2013-03-02T22:41:45Z
Files modified:
	* src/modules/rlm_sql/drivers/rlm_sql_firebird/rlm_sql_firebird.c
	* src/modules/rlm_sql/drivers/rlm_sql_firebird/sql_fbapi.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/c16e6e4fae804813fbbc5cd317f76daa21340c10
====== 
Use correct return codes and variable types

Alan T. DeKok at 2013-03-02T21:56:15Z
Files modified:
	* src/modules/rlm_eap/eap.c
	* src/modules/rlm_eap/rlm_eap.c
	* src/modules/rlm_eap/rlm_eap.h

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/5da6638eadca162a6e0dac34946c9fa79f622e6e
====== 
Remove unused variable

Alan T. DeKok at 2013-03-02T21:56:15Z
Files modified:
	* src/lib/dhcp.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/482e406342243cedbc776af3d3d673ae8a561f2f
====== 
Fix compiler warnings

Alan T. DeKok at 2013-03-02T21:56:15Z
Files modified:
	* src/modules/rlm_eap/types/rlm_eap_pwd/eap_pwd.h
	* src/modules/rlm_eap/types/rlm_eap_pwd/rlm_eap_pwd.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/9481678decaf10501f507eb73e6eebc41d030938
====== 
Remove unused variable

Alan T. DeKok at 2013-03-02T21:56:15Z
Files modified:
	* src/modules/rlm_eap/types/rlm_eap_leap/rlm_eap_leap.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/42224201b1c4fe07bd19d93f3f7da0a1e17c2445
====== 
Remove unused variable

Alan T. DeKok at 2013-03-02T21:56:15Z
Files modified:
	* src/main/radsniff.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/d587a5d1ca6093511934303cef8dc8542648e9e8
====== 
Remove compiler warnings

Alan T. DeKok at 2013-03-02T21:56:15Z
Files modified:
	* src/modules/rlm_sql/drivers/rlm_sql_sybase/rlm_sql_sybase.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/9f0bd858de4fdc03c4110d8f949e856773d6d052
====== 
Remove more warnings

Alan T. DeKok at 2013-03-02T21:56:15Z
Files modified:
	* src/modules/rlm_sql/drivers/rlm_sql_freetds/rlm_sql_freetds.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/dbea9a9c2e5e0f4f81fbe34b89b7ac7473347a78
====== 
Fix compile warnings

Alan T. DeKok at 2013-03-02T21:56:15Z
Files modified:
	* src/modules/rlm_sql/drivers/rlm_sql_db2/rlm_sql_db2.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/4c623f8236ce00ae380a64f223dad116dc23389c
====== 
Too many -Ls

Arran Cudbard-Bell at 2013-03-02T17:11:24Z
Files modified:
	* src/modules/rlm_sql/drivers/rlm_sql_oracle/configure
	* src/modules/rlm_sql/drivers/rlm_sql_oracle/configure.in

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/6f9fd5b5a7110c51bb465010d911b5297ce04b73
====== 
Only string and integer types can have tags.

This should fix the issue with Coverity

Alan T. DeKok at 2013-03-02T16:42:18Z
Files modified:
	* src/lib/radius.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/9a4ac1ff1dd1f24208e0389d4585ed8d38cf1101
====== 
Array entry always exists

Alan T. DeKok at 2013-03-02T16:38:45Z
Files modified:
	* src/modules/rlm_counter/rlm_counter.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/8c50c94660f12a3900a06c06329e8c39ac568105
====== 
Remove dead code

Alan T. DeKok at 2013-03-02T16:37:58Z
Files modified:
	* scripts/jlibtool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/1b5fa9e60dbd502f870b2ac595829c9df0c98395
====== 
Use memcpy for binary structures, not strncpy

Alan T. DeKok at 2013-03-02T16:32:20Z
Files modified:
	* src/main/radwho.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/bc6207ca31a40fa36cef22e4a888c26cca8864ce
====== 
Use talloc for hs_type

We'll probably need to audit the source for similar issues.
Or, simply convert everything to talloc, and the problems
will go away.

Alan T. DeKok at 2013-03-02T16:30:38Z
Files modified:
	* src/main/realms.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/f0c4a14eb32f3de3dbf3fc298734de5dc833b3af
====== 
Free memory on error

Alan T. DeKok at 2013-03-02T16:26:25Z
Files modified:
	* src/modules/rlm_sql/drivers/rlm_sql_db2/rlm_sql_db2.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/56d8ae55c87a8f2205b089c561b1d2822c15a1aa
====== 
Return something.  No idea if it's correct.

People shouldn't be using the freetds module.

We should probably just deleted it.

Alan T. DeKok at 2013-03-02T16:12:42Z
Files modified:
	* src/modules/rlm_sql/drivers/rlm_sql_freetds/rlm_sql_freetds.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/872a3e1f2ad4c7797821056648f6362e695a7320
====== 
Note that it's fall-through

Alan T. DeKok at 2013-03-02T16:12:42Z
Files modified:
	* src/modules/rlm_sql/drivers/rlm_sql_unixodbc/rlm_sql_unixodbc.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/2ada82d0b1963012b4479394ecfd2929ed0a9314
====== 
If we don't re-connect, it's an error.

Alan T. DeKok at 2013-03-02T16:12:42Z
Files modified:
	* src/modules/rlm_ldap/rlm_ldap.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/4f237877b1f84474e2b755919027c58c40798d97
====== 
Free memory on error

Alan T. DeKok at 2013-03-02T16:12:42Z
Files modified:
	* src/modules/rlm_sql/drivers/rlm_sql_oracle/rlm_sql_oracle.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/467496178594c69e3ee9f6f2243cabc002d2dfb9
====== 
Initialize VP to NULL.

There may be no data from the json call.  If so, we return NULL

Alan T. DeKok at 2013-03-02T16:12:42Z
Files modified:
	* src/modules/rlm_rest/rest.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/6b3c6569d20c8b9c26471f78aee9a4c26b1ab659
====== 
Use correct variable

Alan T. DeKok at 2013-03-02T16:12:42Z
Files modified:
	* src/modules/rlm_redis/rlm_redis.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/5c984cc18a4c6a8aed89df6efedad6141f9bf4b6
====== 
Use correct variable

Alan T. DeKok at 2013-03-02T16:12:42Z
Files modified:
	* src/modules/rlm_eap/types/rlm_eap_md5/configure
	* src/modules/rlm_eap/types/rlm_eap_pwd/rlm_eap_pwd.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/ae15a0a5b7eeb96bf0fd5cfff421fda1bb30d076
====== 
Use correct argument

Alan T. DeKok at 2013-03-02T16:12:42Z
Files modified:
	* scripts/jlibtool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/92606b093e8e538806600a0a58ff8674aa31beda
====== 
Free memory on bind / select failed

Alan T. DeKok at 2013-03-02T16:12:41Z
Files modified:
	* src/modules/rlm_sql/drivers/rlm_sql_sybase/rlm_sql_sybase.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/4e2c0f317e8272984eecc283f6800147c7e7c6e8
====== 
Hacks for Coverity.

We know that editing the dictionaries won't happen.  Coverity doesn't

Alan T. DeKok at 2013-03-02T16:12:41Z
Files modified:
	* src/lib/radius.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/6dfd63803442f041f7d907db383815fe349213f3
====== 
Made "chase_referrals" and "rebind" to "yes" by default.

And updated the source so that it prints out warnings
if they cannot be enabled.

We should probably just remove these two options.  There are
always benefits to leaving them on.  There are no real benefits
to turning them off

Alan T. DeKok at 2013-03-02T16:12:41Z
Files modified:
	* raddb/mods-available/ldap
	* src/modules/rlm_ldap/rlm_ldap.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/aa3bb1ee65a03a854fa4359041bd297114c11900
====== 
Use correct buffer for output

Alan T. DeKok at 2013-03-02T16:12:41Z
Files modified:
	* src/main/conffile.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/9c4cbe9a0d11936eadaf016f36c234dc884690a2
====== 
Fixup oracle configure script

Arran Cudbard-Bell at 2013-03-02T06:46:48Z
Files modified:
	* src/modules/rlm_sql/drivers/rlm_sql_oracle/configure
	* src/modules/rlm_sql/drivers/rlm_sql_oracle/configure.in

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/dcbb9e8b6b11d2e76b1b8125c7f2d38de12a5e67
====== 
-- 
This commit summary was generated @2013-03-03T00:00:04Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed).