Patch for updated EAP-TNC support for freeradius from tnc at fhh

Avesh Agarwal avesh.ncsu at gmail.com
Mon Mar 11 01:26:38 CET 2013


On Sun, Mar 10, 2013 at 3:22 PM, Arran Cudbard-Bell <
a.cudbardb at freeradius.org> wrote:

>
> On 10 Mar 2013, at 00:13, Avesh Agarwal <avesh.ncsu at gmail.com> wrote:
>
> >
> >
> > On Sat, Mar 9, 2013 at 8:50 AM, Arran Cudbard-Bell <
> a.cudbardb at freeradius.org> wrote:
> > I've refactored the code and shrunk it.
> >
> > I really appreciate your help on this.
> > The code you submitted leaked opaque data, which i've fixed.
> >
> > I'm concerned about the call to storeUserName, and getConnection,
> there's no where where the connection is explicitly destroyed, so I don't
> see how memory passed to those functions or allocated by those functions is
> ever freed. I guess there must be some magic GC/reference counting i'm
> missing?
> >
> > ------
> >
> > Regarding the library.
> >
> > I actually packaged it for fedora listed here
> http://koji.fedoraproject.org/koji/buildinfo?buildID=383324 .
> >
> > So I use the that packaged version when building EAP-TNC module for
> freeradius, and somehow I did not have any of these issues while building
> the module. I will surely look for and try to eliminate  the errors you
> noticed.
> >
>
> Ok i've sent a pull request. It adds the missing dependencies properly,
> fixes the build system to work on OSX, and fixes the typos.
>
>

Appreciated, merged the patch.

> -Arran
> -
> List info/subscribe/unsubscribe? See
> http://www.freeradius.org/list/devel.html
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freeradius.org/pipermail/freeradius-devel/attachments/20130310/5136e2aa/attachment.html>


More information about the Freeradius-Devel mailing list