Hard column wrap

Arran Cudbard-Bell a.cudbardb at freeradius.org
Tue Mar 19 15:37:16 CET 2013


On 19 Mar 2013, at 10:01, Alan DeKok <aland at DEPLOYINGRADIUS.COM> wrote:

> Arran Cudbard-Bell wrote:
>> For years the official maximum line length in the FreeRADIUS has been 80 columns. There was no real reason for this other than to satisfy our project leader's nostalga for VT100 displays.
> 
>  Well... not *just* VT100.

> 
>> Deeply nested sets of logic are still considered harmful, and yes
>> 
>> we (still,
>>      have,
>>      to,
>>      use,
>>      this,
>>      retarded,
>>      argument,
>>      alignment,
>>      scheme);
> 
>  Yes.

It's (really,
       really,
       really,
       retarded, 
            and,
              brittle,
 because,
   when,
you, 
do,
search,
   and,
    replace,
    it,
      messses,
      up,
   the,
alignment)
      

> 
>> egyption braces for
>> 
>> if (conditions) {
>> 
>> }
>> 
>> one true brance for
>> 
>> functions ()
>> {
>> 
>> }
> 
>  Yes.
> 
>> switch (es)
>> {
> 
>  No... the brace goes on the same line as the switch statement.

Really? I think that's wrong, it munges the first case statement with the condition, makes it harder to read.

> 
>> for (lo; oo; ps)
>> {
> 
>  Same here.

ok...

> 
>  I *loath* the fanatical whitespace model of:
> 
> 	if (a)
> 	{
> 		stuff
> 	}
> 	else
> 	{
> 		other
> 	}
> 
>  Half of my screen is taken up by brackets.  If you can't figure out
> what code belongs where from the indentation alone, you shouldn't be
> programming.
> 

Yeah Allman style looks dumb for conditions but aids readability in everything else...

>> all (arguments, must, have, a, space,  or
>>      newline, after, the, comma or semicolon)
> 
>  Yes,becauseIhaterun-onsentences.They'retoodanghardtoread.
> 
>  (see?)

Wasn't a criticism.

> 
>> if (braceless)
>> 	alan_will_beat_you_with_sticks;
>> else if ((assignment = nested)
>> 	with clubs;



More information about the Freeradius-Devel mailing list