Possible bug in rlm_counter (v3)

A.L.M.Buxey at lboro.ac.uk A.L.M.Buxey at lboro.ac.uk
Wed Feb 26 10:58:05 CET 2014


Hi,

>    res cannot be an unsigned int. It should be an int because this condition
>    -> https://github.com/FreeRADIUS/freeradius-server/blob/v3.0.x/src/modules/rlm_counter/rlm_counter.c#L805
>    never can be false.

thats a condition that checks IF res > 0

...so res COULD be less than 0 - who knows what random value might be assigned to it be some
wierd policy or NAS config?  ;-)

alan


More information about the Freeradius-Devel mailing list