Possible bug in rlm_counter (v3)

Alan DeKok aland at deployingradius.com
Wed Feb 26 14:39:48 CET 2014

Marco Marino wrote:
> res=check_vp->vp_integer - counter.user_counter; (line 804)
> So, if we declare
> unsigned int res;
> probably it never goes in the "else" condition (there is a casting
> problem!). But res should be "int", because res often is negative (and
> this is right).
> In the version 2 of this counter, res is int and it works. In version 3
> res is unsigned int and not works (User never reach its maximum daily
> session time).

  I'll push a fix.

  Alan DeKok.

More information about the Freeradius-Devel mailing list