ippool configuration causes 3.x server to fail to start

[John Dennis]

There is a problem in raddb/mods-available/ippool, looks like it wasn't
updated correctly for 3.x. It contains the following lines:

> 	# session-db:
> 	#	The main db file used to allocate addresses.
> 	session_db = ${db_dir}/db.ippool


But this causes the following start up error:

> /etc/raddb/mods-enabled/ippool[28]: Configuration item 'filename' must have a value
>   }
> /etc/raddb/mods-enabled/ippool[28]: Invalid configuration for module "main_pool"

It's because of these lines in rlm_ippool.c

> 	{ "session-db", PW_TYPE_FILE_OUTPUT | PW_TYPE_DEPRECATED, offsetof(rlm_ippool_t,filename), NULL, NULL },
> 	{ "filename", PW_TYPE_FILE_OUTPUT | PW_TYPE_REQUIRED, offsetof(rlm_ippool_t,filename), NULL, NULL },
> 

Both session-db and filename are mapped to the inst filename attribute
but filename is required. Also the attribute name in
readdb/mods-available is session_db which doesn't even exist (it's
session-db, note hyphen vs. underscore).

The raddb/mods-available/ippool needs to have both session-db and
session_db changed to filename.

I didn't bother producing a patch because the necessary edit is trivial.


-- 
John