ippool configuration causes 3.x server to fail to start

[Arran Cudbard-Bell]

On 17 Jan 2014, at 16:45, John Dennis <jdennis at redhat.com> wrote:

> On 01/17/2014 11:29 AM, Arran Cudbard-Bell wrote:
>> 
>>> but filename is required. Also the attribute name in
>>> readdb/mods-available is session_db which doesn't even exist (it's
>>> session-db, note hyphen vs. underscore).
>>> 
>>> The raddb/mods-available/ippool needs to have both session-db and
>>> session_db changed to filename.
>>> 
>>> I didn't bother producing a patch because the necessary edit is trivial.
>> 
>> Done. Thanks for reporting the issue.
> 
> Thanks Arran. But just noticed in the commit you missed updating
> session-db in the comment lines above the filename attribute. That makes
> it confusing, the comment should use the same name as the attribute.

Done.

> However, it might be worth including in the comment filename used to be
> called session-db just to help folks during migration.

That was why I left it in there, it wasn't missed, but I guess users can probably figure out what it's used for by the fact the default value is '${db_dir}/db.ippool'.

Arran Cudbard-Bell <a.cudbardb at freeradius.org>
FreeRADIUS Development Team

FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 881 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freeradius.org/pipermail/freeradius-devel/attachments/20140117/4795f865/attachment.pgp>