3.0.x HEAD crashing

[Arran Cudbard-Bell]

On 17 Jun 2014, at 19:32, Phil Mayers <p.mayers at IMPERIAL.AC.UK> wrote:

> On 17/06/2014 18:05, Arran Cudbard-Bell wrote:
> 
>> What modules are you using?
> 
> Man, what are we not...
> 
> The main things are:
...

I figured the cache module would be involved in there somewhere. It's really the only thing that does anything major with control attributes...

That's interesting... well I noticed a check was missing for the parenting of VALUE_PAIR data buffers. If one wasn't being copied somewhere in the cache module, and being freed due to incorrect parenting, it'd result in heap corruption.

I've added the check, could you run up v3.0.x HEAD and see if it fails?

I also noticed a missed free when removing cache control attribute, but that'd quite minor, and wouldn't of even resulted in a memory leak...

-Arran

Arran Cudbard-Bell <a.cudbardb at freeradius.org>
FreeRADIUS Development Team

FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 881 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freeradius.org/pipermail/freeradius-devel/attachments/20140617/0e104b14/attachment.pgp>