talloc & threads in rlm_eap

Arran Cudbard-Bell a.cudbardb at freeradius.org
Fri Jun 20 14:29:11 CEST 2014

On 20 Jun 2014, at 11:17, Arran Cudbard-Bell <a.cudbardb at freeradius.org> wrote:

> On 20 Jun 2014, at 10:56, Phil Mayers <p.mayers at imperial.ac.uk> wrote:
>> Hmm assuming nothing else is talloc'ed off the parent of handler that is, or freeing handler itself is racey...
> That's now fixed too. I think. The memory associated with the handler is now freed within the destructor for the handler, which synchronises the frees using the same mutex. Hopefully that's OK.
> https://github.com/FreeRADIUS/freeradius-server/commit/f74b0fe85f171faf5c1445240d23a28eb73f20c1
> If it explodes I guess we'll need to figure out another solution.

Confirmed lack of explodyness.

I also fixed some other explicit frees of VPs which were associated with the EAP specific opaque data.


Arran Cudbard-Bell <a.cudbardb at freeradius.org>
FreeRADIUS Development Team

FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 881 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freeradius.org/pipermail/freeradius-devel/attachments/20140620/76add1e9/attachment.pgp>

More information about the Freeradius-Devel mailing list