talloc & threads in rlm_eap

[Arran Cudbard-Bell]

On 20 Jun 2014, at 20:18, Arran Cudbard-Bell <a.cudbardb at freeradius.org> wrote:

> 
> On 20 Jun 2014, at 19:00, Arran Cudbard-Bell <a.cudbardb at freeradius.org> wrote:
> 
>> 
>> On 20 Jun 2014, at 18:50, Arran Cudbard-Bell <a.cudbardb at freeradius.org> wrote:
>> 
>>> 
>>> On 20 Jun 2014, at 18:39, Phil Mayers <p.mayers at IMPERIAL.AC.UK> wrote:
>>> 
>>>> Erm... Oh dear:
>>>> 
>>>> https://lists.samba.org/archive/samba-technical/2014-June/100669.html
>>>> 
>>>> Does this mean what I think it does?
>>> 
>>> Appears so.
>> 
>> OK, well that explains a lot. Basically we can't parent REQUEST structs from any shared
>> contexts, same for the handlers. That's going to make request chaining using talloc a bit
>> more difficult, but it's not impossible, and we can still keep the nice autofree 
>> behaviour we just need to use destructors instead.
>> 
>> The rest of the code was written to assume REQUESTS were only used by one thread at a 
>> time so should be ok.
>> 
>> Things like rbtrees, hashes, lists, etc are all synchronised so they're fine.
> 
> Ug, but parented off things like config structures. I just checked and they seem fine
> though.
> 
> Anyway, handlers now alloced from the NULL context. So all should be well...

Connection pools allocated from the NULL context too. REQUESTs it seems were already being
allocated from the NULL ctx.

Arran Cudbard-Bell <a.cudbardb at freeradius.org>
FreeRADIUS Development Team

FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 881 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freeradius.org/pipermail/freeradius-devel/attachments/20140620/b66c312b/attachment.pgp>