3.0.1 & 3.0.2 / error in unlang when using attribute 3GPP-IMSI

[Chaigneau, Nicolas]

I've fixed this by modifying main/util.c as follows:

In function radius_list_name(...):

	/*
	 *	We couldn't determine the list if:
	 *
	 * 	A colon delimiter was found, but the next char was a
	 *	number, indicating a tag, not a list qualifier.
	 *
	 *	No colon was found and the first char was upper case
	 *	indicating an attribute.
	 *
	 */
	q = strchr(p, ':');
	//NCH: this is wrong, we may have "proxy-reply:3GPP-IMSI" for instance...
	//if (((q && (q[1] >= '0') && (q[1] <= '9'))) ||
	//    (!q && isupper((int) *p))) {
	if (!q && isupper((int) *p)) {
		return unknown;
	}


The comment says "the next char was a number, indicating a tag, not a list qualifier".
I don't know what this means. I there a risk this fix breaks something else ?




> -----Message d'origine-----
> De : freeradius-devel-
> bounces+nchaigne=capgemini.fr at lists.freeradius.org [mailto:freeradius-
> devel-bounces+nchaigne=capgemini.fr at lists.freeradius.org] De la part de
> Chaigneau, Nicolas
> Envoyé : lundi 24 mars 2014 15:33
> À : FreeRadius developers mailing list
> Objet : RE: 3.0.1 & 3.0.2 / error in unlang when using attribute 3GPP-
> IMSI
> 
> Hello again,
> 
> 
> I migrated to 3.0.2, but the problem is still here :
> 
> 
> (0)   update control {
> (0) ERROR: %{proxy-reply:3GPP-IMSI}
> (0) ERROR:   ^ Unknown attribute
> (0)   } # update control = fail
> (0)  } #  post-proxy = fail
> 
> 
> 
> Could you look into this ?
> 
> Thanks,
> Nicolas.
> 
> 
> > -----Message d'origine-----
> > Envoyé : mercredi 12 mars 2014 17:07
> > À : FreeRadius developers mailing list
> > Objet : RE: 3.0.1 / error in unlang when using attribute 3GPP-IMSI
> >
> >
> > OK, thanks!
> >
> > I'll wait for release of 3.0.2, since it is imminent.
> >
> >
> > Regards,
> > Nicolas.
> >
> >
> > > -----Message d'origine-----
> > > Envoyé : mercredi 12 mars 2014 17:01
> > > À : FreeRadius developers mailing list
> > > Objet : Re: 3.0.1 / error in unlang when using attribute 3GPP-IMSI
> > >
> > > On Wed, Mar 12, 2014 at 03:55:31PM +0000, Chaigneau, Nicolas wrote:
> > > > I have the following error when I try to use 3GPP-IMSI attribute
> in
> > > unlang :
> > > >
> > > > (0) ERROR: %{proxy-reply:3GPP-IMSI}
> > > > (0) ERROR:   ^ Unknown attribute
> > > >
> > > > If I hack the dictionary entry 3GPP-IMSI -> X3GPP-IMSI, it works
> > > fine.
> > > > Looks like there is a problem with attributes starting with a
> > digit.
> > > >
> > > > Maybe this issue has already been fixed in 3.0.x ? I don't know
> > where
> > > to look in the code...
> > >
> > > It was fixed a few months ago. Should be in both v3.0.x HEAD and
> > > v2.x.x HEAD IIRC.
> > >
> > > Matthew
> > >
> >
> This message contains information that may be privileged or
> confidential and is the property of the Capgemini Group. It is intended
> only for the person to whom it is addressed. If you are not the
> intended recipient, you are not authorized to read, print, retain,
> copy, disseminate, distribute, or use this message or any part thereof.
> If you receive this message in error, please notify the sender
> immediately and delete all copies of this message.
> 
> -
> List info/subscribe/unsubscribe? See
> http://www.freeradius.org/list/devel.html
This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.