segfault with 3.0.3 on rhel 6.5

[Aaron Hurt]

Alan’s commit does indeed fix the issue in all my testing environments.  The below is a simple patch which should apply to the freeradius-server-3.0.3 dist source.


From f9e2d539599345b03dde495a36d4ec8bd90d78a5 Mon Sep 17 00:00:00 2001
From: Alan T. DeKok <aland at freeradius.org>
Date: Thu, 15 May 2014 10:31:23 -0400
Subject: [PATCH] Use the correct data type.  Closes #634

---
 src/main/mainconfig.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/main/mainconfig.c b/src/main/mainconfig.c
index 86757df..4564778 100644
--- a/src/main/mainconfig.c
+++ b/src/main/mainconfig.c
@@ -83,7 +83,7 @@ static char const *radlog_dest = NULL;
  */
 static char const	*localstatedir = NULL;
 static char const	*prefix = NULL;
-static char		my_name;
+static char const	*my_name = NULL;
 static char const	*sbindir = NULL;
 static char const	*run_dir = NULL;
 static char		*syslog_facility = NULL;
--
1.7.1

On May 15, 2014, at 9:29 AM, Stefan Paetow <Stefan.Paetow at ja.net> wrote:

> Yes. System is a CentOS 6.4 system that was upgraded to 6.5.
> 
> Packages were built with rpmbuild -ba and the SPEC that I've included in the URL (refresh your page).
> 
> I've also set a panic action, yet when I try to start the service, it says none is set. 
> 
> :-/
> 
> Stefan
> 
> 
> 
> -----Original Message-----
> From: freeradius-devel-bounces+stefan.paetow=ja.net at lists.freeradius.org [mailto:freeradius-devel-bounces+stefan.paetow=ja.net at lists.freeradius.org] On Behalf Of Phil Mayers
> Sent: 15 May 2014 14:56
> To: freeradius-devel at lists.freeradius.org
> Subject: Re: segfault with 3.0.3 on rhel 6.5
> 
> On 15/05/14 09:56, Stefan Paetow wrote:
>> Aaron, Alan D, et al.
>> 
>> Just to confirm, I've been able to reproduce on my CentOS 6.5 system 
>> with an RPM version of this.
> 
> I *can't* repro this on a 6.5 box compiled from source.
> 
> Can I just confirm people are seeing it segfault on startup with a default config? No action required?
> -
> List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html
> 
> Janet(UK) is a trading name of Jisc Collections and Janet Limited, a 
> not-for-profit company which is registered in England under No. 2881024 
> and whose Registered Office is at Lumen House, Library Avenue,
> Harwell Oxford, Didcot, Oxfordshire. OX11 0SG. VAT No. 614944238
> 
> -
> List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freeradius.org/pipermail/freeradius-devel/attachments/20140515/dfe73533/attachment.pgp>