Commit report for v3.0.x branch

Fri Oct 3 00:00:02 CEST 2014

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server)

======
Un-tagged attributes can *never* have tags

Alan T. DeKok at 2014-10-02T23:24:51Z
Files modified:
	* src/main/tmpl.c
	* src/tests/unit/condition.txt

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/e024e5cb63af1353812f821859b003c14a579f25
====== 
Fix typo

Arran Cudbard-Bell at 2014-10-02T22:00:46Z
Files modified:
	* src/main/tmpl.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/3c36e45c1e090493cb20c1effc80dcde73475812
====== 
We should use strtol to parse tag and array indexes as strtoul still parses negative numbers into very large ones (which is confusing for users)

Arran Cudbard-Bell at 2014-10-02T21:59:52Z
Files modified:
	* src/main/tmpl.c
	* src/tests/unit/condition.txt

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/3f786cbc906f408ee122cd6bd42a745a027507e3
====== 
They're indexes not references...

Arran Cudbard-Bell at 2014-10-02T21:58:44Z
Files modified:
	* src/main/xlat.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/1bef7d411142c5ccf17aa92dfba5f1ba16f31810
====== 
Formatting

Arran Cudbard-Bell at 2014-10-02T21:33:11Z
Files modified:
	* src/modules/rlm_files/rlm_files.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/79993e1628b30d4b9e494e1c2f45286550a5f0f8
====== 
Fix invalid request/list errors

Arran Cudbard-Bell at 2014-10-02T21:33:03Z
Files modified:
	* src/main/tmpl.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/0004df2ad0546c56ab5544e7ff3258bc1f24dbd6
====== 
Indent condition error markers

Arran Cudbard-Bell at 2014-10-02T21:32:30Z
Files modified:
	* src/main/conffile.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/ed18db0a87ecbaf60f2bb92c07796f6ec74a561b
====== 
I hate doxygen

Arran Cudbard-Bell at 2014-10-02T20:59:45Z
Files modified:
	* doc/source/Doxyfile

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/f01083027ca8bec52459604616f4b9d7b1f737b5
====== 
Convert the majority of tmpl functions to use a similar signature as the parse functions

This means condition parsing error markers now extend into attribute references

Arran Cudbard-Bell at 2014-10-02T20:48:39Z
Files modified:
	* src/include/parser.h
	* src/include/tmpl.h
	* src/main/map.c
	* src/main/modcall.c
	* src/main/parser.c
	* src/main/tmpl.c
	* src/main/valuepair.c
	* src/main/xlat.c
	* src/modules/rlm_expr/rlm_expr.c
	* src/modules/rlm_rest/rest.c
	* src/tests/unit/condition.txt

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/69fac42a7c3b02f937a8e6f27a7eea51251facac
====== 
Move fr_canonicalize_error to log.c

I still don't like the name, partly because now I have to remember how to spell canonicalize, and it seems like it should have double n's to me

Arran Cudbard-Bell at 2014-10-02T20:40:05Z
Files modified:
	* src/include/log.h
	* src/main/log.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/3c8a5e838a7641a359a342c767ae280a4b0f7174
====== 
Convert tmpl_afrom_attr_substr to use a similar signature as other parsing functions

Arran Cudbard-Bell at 2014-10-02T16:17:41Z
Files modified:
	* src/include/tmpl.h
	* src/main/map.c
	* src/main/tmpl.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/307295e0aa8e137c75590bf2ba8f2c4a3286d512
====== 
Add comment for fr_canonicalize_error

Arran Cudbard-Bell at 2014-10-02T16:17:41Z
Files modified:
	* src/main/parser.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/251bef616740cb9975a697a8d9bc2a26ed31329d
====== 
Output variables come first

Arran Cudbard-Bell at 2014-10-02T16:17:41Z
Files modified:
	* src/include/parser.h
	* src/main/conffile.c
	* src/main/modcall.c
	* src/main/parser.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/c7de80aabe5c2ab78a845774de2ccaf3f4e9abbe
====== 
Tests for commas, too

Alan T. DeKok at 2014-10-02T15:35:38Z
Files modified:
	* src/tests/keywords/comments

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/035614d2748a8afe5326637d1ff2b3842cee29d5
====== 
Stop on comma and EOL, too

Alan T. DeKok at 2014-10-02T15:34:35Z
Files modified:
	* src/main/conffile.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/0c2084f37fc8115fc78d91e54fc37fdb286e3c4f
====== 
Fix comments after module reference.

	ok # foo!

Alan T. DeKok at 2014-10-02T15:32:30Z
Files modified:
	* src/main/conffile.c
	* src/tests/keywords/comments

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/5d20478f376986c309d75c76c9e3c42285c2b37e
====== 
Note recent changes

Alan T. DeKok at 2014-10-02T15:27:47Z
Files modified:
	* doc/ChangeLog

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/98de9dad0e5aa0401489792619714bdf41c2d1c6
====== 
Add test for comments

Arran Cudbard-Bell at 2014-10-02T13:54:15Z
Files modified:
	* src/tests/keywords/comments

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/fa4f05ce31f000a08d360bccfb15e6491bdd21ce
====== 
Fixup rlm_sqlcounter warnings

Arran Cudbard-Bell at 2014-10-02T13:38:11Z
Files modified:
	* src/modules/rlm_sqlcounter/rlm_sqlcounter.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/b6873dff3b546e861af38065095a0dc398b24a48
====== 
Hint that request and cmd should never be NULL in radius_exec_program

Arran Cudbard-Bell at 2014-10-02T11:47:28Z
Files modified:
	* src/include/radiusd.h

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/49e7829323216c2240152de9c72c27368c3dc2c3
====== 
Change logging in radius_exec_program to use R* macros

RERROR should always be used where an error may indicate a failure of an external resource like a script, or database and we have the REQUEST available.

It outputs to the main server log like ERROR but also includes the request number, so multiple errors can be tied together when inspecting the log.

Arran Cudbard-Bell at 2014-10-02T11:44:13Z
Files modified:
	* src/main/exec.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a3f097fa8233a95614828c0d06f5646578d76b58
====== 
Change eap_vp2packet to use fr_strerror_printf to output its errors

Because "Malformed EAP message" as an error without any more detail is not useful

Arran Cudbard-Bell at 2014-10-02T11:40:42Z
Files modified:
	* src/modules/rlm_eap/libeap/eapcommon.c
	* src/modules/rlm_eap/libeap/eapsimlib.c
	* src/modules/rlm_eap/radeapclient.c
	* src/modules/rlm_eap/rlm_eap.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/e664cd5e8af011bcccac0b7b827b0409f5a3b54d
====== 
Whitespace

Arran Cudbard-Bell at 2014-10-02T11:40:38Z
Files modified:
	* src/modules/rlm_eap/rlm_eap.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/37bec764f4a99ac64df1ebe080ddaeec638f884d
====== 
More verbose error message on proxy failure. Including the User-Name the request was for, is extremely useful for eduroam.

Arran Cudbard-Bell at 2014-10-02T11:40:34Z
Files modified:
	* src/main/process.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/9affe318f6e38a08cd1e2d3de72239ae8728161e
====== 
-- 
This commit summary was generated @2014-10-03T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed).