Commit report for master branch

[The git bot]

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server)

======
Need to merge suboptions list, not insert the head of it, closes #812

Arran Cudbard-Bell at 2014-10-18T19:42:34Z
Files modified:
	* src/modules/proto_dhcp/dhcp.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/96e35fcaad9484bd0d3592bd071423b6b6abc9d2
====== 
Merge pull request #813 from herwinw/cppcheck

Cppcheck

Arran Cudbard-Bell at 2014-10-18T19:33:15Z
Files modified:
	* src/lib/valuepair.c
	* src/main/tmpl.c
	* src/modules/rlm_detail/rlm_detail.c
	* src/modules/rlm_eap/libeap/eapcrypto.c
	* src/modules/rlm_passwd/rlm_passwd.c
	* src/modules/rlm_replicate/rlm_replicate.c
	* src/modules/rlm_sql/drivers/rlm_sql_freetds/rlm_sql_freetds.c
	* src/modules/rlm_sql/rlm_sql.c
	* src/modules/rlm_unbound/rlm_unbound.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/d7421a7dd4ce52a4ac73d14a7d8b4764354a03cf
====== 
Fixed check in pairvalidate

The only commit in this series that actually changes some behaviour. The test was supposed to check if one of the values (match and check) was false, while the other was true. Because the while loop already validated that at least one of them is true, we can get the desired behaviour by just checking if one of them is false. The old behaviour only tested to see if match was false.

This code is not tested in the unit tests. It would be nice to have it in there, but I've got no idea how to write that.

This fixes the following message of cppcheck:

[src/lib/valuepair.c:547]: (style) Same expression on both sides of '||'.

Herwin Weststrate at 2014-10-17T19:53:44Z
Files modified:
	* src/lib/valuepair.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/ed8d7b49c10be4fd386a76c25f71d9a468f8aaa2
====== 
Use *= 2 instead of += $self for doubling

The generated code is slightly more efficient too (unless you consider compiler optimizations)

This fixes the following message of cppcheck:

[src/modules/rlm_unbound/rlm_unbound.c:157]: (style) Same expression on both sides of '+='.

Herwin Weststrate at 2014-10-17T19:53:42Z
Files modified:
	* src/modules/rlm_unbound/rlm_unbound.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/992c0e42e8c9c7e724b27f5541b8bcfb263cb7f0
====== 
Don't assign a value to a variable and uncondionally overwrite it

This fixes the following message of cppcheck:

[src/modules/rlm_replicate/rlm_replicate.c:113]: (performance) Variable 'rcode' is reassigned a value before the old one has been used.

Herwin Weststrate at 2014-10-17T19:53:39Z
Files modified:
	* src/modules/rlm_replicate/rlm_replicate.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/8de37c3fda9ceb7d7a230149cdd45dd467a16fb4
====== 
Dereference query pointers before checking to see if they're empty

This effectively did a check to see if the pointer was NULL, exactly what we did in the LHS of the and operator.

This fixes the following messages of cppcheck:

[src/modules/rlm_sql/rlm_sql.c:638]: (warning) Char literal compared with pointer 'inst.config.authorize_group_check_query'. Did you intend to dereference it?
[src/modules/rlm_sql/rlm_sql.c:675]: (warning) Char literal compared with pointer 'inst.config.authorize_group_reply_query'. Did you intend to dereference it?

Herwin Weststrate at 2014-10-17T19:53:37Z
Files modified:
	* src/modules/rlm_sql/rlm_sql.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/99403c7b6f8dc9938f7310ee2a243b397c426c5e
====== 
Removed assignment of function parameter at the end of function

This fixes the following message of cppcheck:

[src/main/tmpl.c:826]: (warning) Assignment of function parameter has no effect outside the function.

Herwin Weststrate at 2014-10-17T19:53:35Z
Files modified:
	* src/main/tmpl.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/3f51efd51beebfaa3542a0d1e25ce708d70f89a4
====== 
Removed some unused variables

This fixes the following messages of cppcheck:

[src/modules/rlm_sql/drivers/rlm_sql_freetds/rlm_sql_freetds.c:290]: (style) Variable 'ret' is assigned a value that is never used.
[src/modules/rlm_sql/drivers/rlm_sql_freetds/rlm_sql_freetds.c:492]: (style) Variable 'ret' is assigned a value that is never used.
[src/modules/rlm_sql/drivers/rlm_sql_freetds/rlm_sql_freetds.c:573]: (style) Variable 'ret' is assigned a value that is never used.
[src/modules/rlm_passwd/rlm_passwd.c:284]: (style) Variable 'len' is assigned a value that is never used.

Herwin Weststrate at 2014-10-17T19:53:33Z
Files modified:
	* src/modules/rlm_passwd/rlm_passwd.c
	* src/modules/rlm_sql/drivers/rlm_sql_freetds/rlm_sql_freetds.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/c816ad52d2006ff12c3f506e9deb4e47e9d7c866
====== 
Use %u in sprintf when printing unsigned integers

This fixes the following messages of cppcheck:

[src/modules/rlm_eap/libeap/eapcrypto.c:108]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
[src/modules/rlm_eap/libeap/eapcrypto.c:119]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
[src/modules/rlm_eap/libeap/eapcrypto.c:126]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
[src/modules/rlm_eap/libeap/eapcrypto.c:133]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
[src/modules/rlm_detail/rlm_detail.c:236]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.

Herwin Weststrate at 2014-10-17T19:53:32Z
Files modified:
	* src/modules/rlm_detail/rlm_detail.c
	* src/modules/rlm_eap/libeap/eapcrypto.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/6c5f8e3aba4871a594f4aa666f26c38e3d200913
====== 
-- 
This commit summary was generated @2014-10-19T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed).