3.1.x consistency check

[Arran Cudbard-Bell]

> On 24 Nov 2015, at 09:01, Matthew Newton <mcn4 at LEICESTER.AC.UK> wrote:
> 
> On Fri, Nov 20, 2015 at 10:52:28PM +0000, Matthew Newton wrote:
>>> It may be worth doing a dev build of v3.0.x (if you're not
>>> already) just to see if the validity checks catch the issue.
>> 
>> That's a good idea. It'll probably be after the weekend now. I've
>> just rebuilt 3.0.x and pushed it to the live server, so I'll leave
>> that for the weekend and see how it holds out. If it crashes like
>> before it probably won't be until 9am Monday morning anyway.
> 
> Follow on from this.
> 
> The (non-dev) build from Friday with SoH bugfix has run all
> weekend and through both the busy time of yesterday morning and
> this morning without crashing, so I think that patch has fixed it.
> Thanks! Previously would crash within a few minutes or hours at
> the most.
> 
> I've just put a dev build on the other server and about to push
> all load on to it, but it's not crashed on the first packet like
> 3.1 did so hopefully the consistency checks are consistent :)
> 
> I'll probably try bumping up to 3.1 again after this, "just
> because"...

In v3.1.x just took a pass through to convert most direct writes to vp_strvalue and vp_octets to use the value assignment API, which will always ensure proper \0 termination and correct vp_length.  Hopefully there won't be any more incidents of this.

-Arran

Arran Cudbard-Bell <a.cudbardb at freeradius.org>
FreeRADIUS development team

FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 872 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freeradius.org/pipermail/freeradius-devel/attachments/20151201/5e5f4b20/attachment.sig>