[Proposal] Change list of mandatory parameters for rlm_sqlippool
aland at deployingradius.com
Wed Jun 10 14:42:40 CEST 2015
On Jun 10, 2015, at 5:56 AM, Geaaru <geaaru at gmail.com> wrote:
> if I understood correctly configuration parameters inside rlm_sqlippool
> with PW_TYPE_REQUIRED are needed because logic is related with a
> classic SQL transaction but with some databases for examples
> PostrgreSQL or Oracle logic could be reduce to a single procedure /
> function that speedup interaction with database to a single call.
> So, why not remove PW_TYPE_REQUIRED to allocate_clear, allocate_update
> and/or others parameters?
Maybe. To be honest, I'd prefer to make the queries configurable, as is done with rlm_sql in v3:
query = ...
> A list of parameters where remove PW_TYPE_REQUIRED is:
> - off_clear
> - on_clear
> - alive_update
> - start_update
> - allocate_update (allocate_find is sufficient)
> - allocate_clear
> User can be use it or not but is not a mandatory parameter and so it
> could be do a choice about use it or not.
Probably a good idea.
But fixing the sqlippool to be saner is good, too.
More information about the Freeradius-Devel