3.1.x consistency check

[Arran Cudbard-Bell]

> On 20 Nov 2015, at 12:13, Arran Cudbard-Bell <a.cudbardb at freeradius.org> wrote:
> 
>> 
>> On 20 Nov 2015, at 12:07, Arran Cudbard-Bell <a.cudbardb at freeradius.org> wrote:
>> 
>>> 
>>> On 20 Nov 2015, at 11:57, Matthew Newton <mcn4 at leicester.ac.uk> wrote:
>>> 
>>> Hi,
>>> 
>>> So trying 3.1.x to see if it fixes the 3.0.x error.... :)
>>> 
>>> Packaged build (so disable-developer) segfaults in rlm_ldap (ldap.c:1431).
>>> Trying to debug that I built a new version which has enable-developer set. That
>>> bombs out in a consistency check in SoH, as below.
>>> 
>>> Looks like it doesn't like that pair_make_request is called with a NULL value?
>>> But can't imagine that is right as that's normally what happens to create an
>>> attribute?
>>> 
>>> About to go home now so thought I'd shoot out a quick e-mail in case someone
>>> else knows the immediate answer without me having to stare at code for a while
>>> :)
>> 
>> Pushed a fix for your SoH issue.
>> 
>> Buffer was being underallocated.  Should have been t + 1, but we have proper
>> functions for assigning values to attributes now, so just used that instead :)
>> 
>> Will look at LDAP.
> 
> Pushed a fix for LDAP.  Looks like that array is NULL if no extensions are present.
> 
> Expected array with one NULL element, but... OpenLDAP.

Interestingly the SoH issue was there in 3.0.x too, so you must be the first person to use it with the v3.0.x branch :/

-Arran

Arran Cudbard-Bell <a.cudbardb at freeradius.org>
FreeRADIUS development team

FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 872 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freeradius.org/pipermail/freeradius-devel/attachments/20151120/ecf7a58b/attachment.sig>