Commit report for v3.1.x branch

[Fajar A. Nugraha]

On Fri, Oct 2, 2015 at 6:18 AM, Matthew Newton <mcn4 at leicester.ac.uk> wrote:
> In theory, configure
>
>    ...
>    --with-iodbc-include-dir='/usr/include/iodbc' \
>    ...
>
> should fail on wheezy because isql.h is in /usr/include. But
> because src/modules/rlm_sql/drivers/rlm_sql_iodbc/configure.ac now
> also has
>
> smart_try_dir="$iodbc_include_dir /usr/include /usr/include/iodbc /usr/local/iodbc/include"
>
> then it erroneously reports as having found it in
> /usr/include/iodbc, but actually uses it from /usr/include, so all
> is well. Essentially the extra --with-iodbc-include-dir directive
> is just redundant.


I haven't tested 3.x, but with 2.1.12 on ubuntu vivid they added
patches/freeradius_add_iodbc_include_dirs.diff, which basically change
this line

smart_try_dir="$iodbc_include_dir /usr/include/iodbc /usr/local/iodbc/include"

on src/modules/rlm_sql/drivers/rlm_sql_iodbc/configure.in and
configure. Tested on my ppa for 2.2.9 to work on precise, trusty
(isql.h in /usr/include), vivid, and wily (isql.h in
/usr/include/iodbc). No "--with-iodbc-include-dir" on debian/rules.

So if you want to remove redundant code, the "/usr/include" in
smart_try_dir line is probably safe to remove as well.

-- 
Fajar