Post-Auth-Type REJECT "broken" in 3.1.x

[Alan DeKok]

> On Jun 22, 2016, at 7:32 PM, Matthew Newton <mcn4 at leicester.ac.uk> wrote:
> Unlike previous behaviour,
> 
>  post auth {
>    Post-Auth-Type REJECT {
>      ...
>    }
>  }
> 
> does not get found and called in 3.1.x - you get
> 
> (1)  ERROR: No Auth-Type found: rejecting the user via Post-Auth-Type = Reject
> (1)  Failed to authenticate the user
> (1)  Using Post-Auth-Type Reject
> (1)  Post-Auth-Type Reject sub-section not found.  Using default return values.

  Arg...

> If it's changed to
> 
>    Post-Auth-Type Reject {
> 
> then all is fine.

  That's annoying.

> This broke in
> 
>  commit 0b2e4da0c574dedd9309c9dbbdf4f8cb9d869d27
>  Author: Alan T. DeKok <aland at freeradius.org>
>  Date:   Tue May 24 17:00:29 2016 -0400
> 
>      Use CONF_SECTIONs directly in unlang_interpret
> 
> The easiest fix is to change the default config to be "Reject"
> rather than "REJECT", but that will seemingly unnecessarily break
> configs when people upgrade from 3.0 so I'm not sure that's the
> best solution.

  TBH, we could just revert that commit.  I was making changes in v3.1.x branch before they became too invasive.  I rolled back many of the changes, and went on to re-do them in a newly created v4.0.x branch.

  If reverting that commit works, just go ahead and do it.  At this point, I won't be touching v3.0.x or v3.1.x for anything other than bug fixes.

  Alan DeKok.