Post-Auth-Type REJECT "broken" in 3.1.x

[Matthew Newton]

On Thu, Jun 23, 2016 at 11:03:32PM +0100, Matthew Newton wrote:
> On Thu, Jun 23, 2016 at 09:33:52AM -0400, Alan DeKok wrote:
> > > This broke in
> > > 
> > >  commit 0b2e4da0c574dedd9309c9dbbdf4f8cb9d869d27
> > 
> > TBH, we could just revert that commit.  I was making changes
> > in v3.1.x branch before they became too invasive.  I rolled
> > back many of the changes, and went on to re-do them in a newly
> > created v4.0.x branch.
> 
> After a brief go at this it looks like it's a whole chunk of
> commits after that as well. I've got 20 or so at the moment but

OK, this *seems* to be the commits that need to be reverted:

  0e3dbd8 Move prototypes for public consumption
  155cce8 try this...
  c3c11c1 move pointer from typedef to struct entry?
  159c2d4 Put "component" and "actions" into compile context
  b9ba753 rename function to be more consistent
  b4dcc39 one more default action compile
  708f4b3 compile_module should use compile_defaultactions()
  5039b29 use compile_default_actions everywhere
  7323bb7 dump_tree needs a name, not a component
  9aa50a9 modcall does not need rlm_component_t
  0ca5d62 Remove modcall.h, it was only 4 lines long
  9cd1e70 rename modcall_compile_section() to unlang_compile()
  2bed61e more functions use group_allocate
  613bf40 Remove all knowledge of components from the interpreter.
  7d6df32 always set request->server_cs
  65c65ac make unlang_interpret() take a default action
  4df0f89 Set request->server_cs if not already set
  12217ed remove indexed_modcall and virtual_server_t
  0b2e4da Use CONF_SECTIONs directly in unlang_interpret

which is any changes to src/main/modules.c,
src/include/interpreter.h, src/main/interpreter.c and
src/main/modcall.c since 0b2e4da.

i.e.

  git log --pretty='%h' 0b2e4da^..4e131ebd -- src/main/modules.c src/include/interpreter.h src/main/interpreter.c src/main/modcall.c | xargs git revert -n

I've pushed it to

  https://github.com/mcnewton/freeradius-server/commits/postauthreject

It builds and the unit tests all complete OK. Let me know if
you're happy to go with that?

Thanks

Matthew


-- 
Matthew Newton, Ph.D. <mcn4 at leicester.ac.uk>

Systems Specialist, Infrastructure Services,
I.T. Services, University of Leicester, Leicester LE1 7RH, United Kingdom

For IT help contact helpdesk extn. 2253, <ithelp at le.ac.uk>