rlm_sql_oracle: OCI_COMMIT_ON_SUCCESS

[Arran Cudbard-Bell]

> On 17 Jul 2017, at 12:58, George Chelidze <george.chelidze at magticom.ge> wrote:
> 
> Hi guys,
> 
> rlm_sql/drivers/rlm_sql_oracle/rlm_sql_oracle.c:
> 
>    status = OCIStmtExecute(conn->ctx, conn->query, conn->error, 1, 0,
>                            NULL, NULL, OCI_COMMIT_ON_SUCCESS);
> 
> Any reason for having OCI_COMMIT_ON_SUCCESS in OCIStmtExecute() call?
> 
> The problem is that any module (rlm_sqlippool is a good candidate)
> relying on rlm_sql and using the concept of database transactions will
> have no chance to rollback, neither it can provide any guarantee for
> data consistency.

Feel free to open a pull request describing a bit more of the background around this.  I don’t believe anyone on the core team is familiar with Oracle internals, so we can’t help, but if you explain exactly why OCI_COMMIT_ON_SUCCESS is bad, then I don’t see why it can’t be changed.

-Arran