Commit report for v4.0.x branch

Tue Jun 6 02:00:02 CEST 2017

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server)

======
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org

 iQIcBAABCgAGBQJZNdvqAAoJEP+k1YKfttfKCq4P/2bkQ7swAvs0uGVlFCt4LK9+
 Q9yzroZPNvQlOT34IAfsJ4PQl5WSWW9Tie5SCf/FXzAtTmXCghC/HG2FgQ2LdrEB
 9pGOsVpT1lHk2666NCE/yUH/eD7T+9xiOqiqwJSe8Z/fxR9MkEGuqCZTY1M38+Zm
 y0ORjMgLlVBcEXw14d/hjatJuiJi05cFmdC3+KP1sj4FedzPyzNvfE8qhNC60KuV
 vjvTPEEZeYnwo4PPqooBIz2IeuynZK6wGJepj5INTCvcYdzywITUUl2F3VJJNXVk
 yAQ6KoHwVegkoVHXGeyvenVVRVr+rHrgTqwxIasLKEtgKqkCSZqsyK4AFhk+EMHD
 KmvXddYVkiPgFAIX8Jiput74hCO43mxLoHt7lllBePYgCqK4I+Ejz/rnBftwNTzT
 fPc6Q0DmI6RrOUHrxr3Q2DiPEVY1NkfOZVu6WMeqK9zAA6/pHlTh6ys8hupMIqbX
 +AxXF9au/YNN+2orGxNS4cB5fZCCG1s6pgqJe7VFOD4wjfuxRSPWoIrwbNOP9esC
 wzSRDcjuLRIrsEeZK19f5E+QGmrV1/v2mRAEiWF83W281sWmqueBH5dj0JcqKm/z
 bLKyv6ipvQT/+fPsHZy/QfR74yDJwT/s/WV1Ae45HPuCIAiLercurVCYgv4zMHD2
 JczfVuT9FhwVZcv+H4lj
 =dtnJ
 -----END PGP SIGNATURE-----

Don't need socket_type_from_proto anymore

Arran Cudbard-Bell at 2017-06-05T22:32:10Z
Files modified:
	* src/lib/util/socket.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/d8ec51414148644edad7b3ea824dea07f8254c42
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org

 iQIcBAABCgAGBQJZNdtmAAoJEP+k1YKfttfKtksP/3F5bRBeDHM8CsZr3oRwEekb
 QVCiXfWbDgzdXD9ZJIANwukaXYds5G8jyd5KtMFf31ZjWQb9kkVWXcnvoyBHP4wQ
 aeXBHLKe+f4er8Gfc4NN5lmK0l+DioCxRSp/P4stx5ALasenmgqNucSu3Hif3grk
 7DEL9iFtIIFBBg+920aPFe2de/y2C8DatKVJEC6Gs5Cxpkqj14H8pQuPHebhS6EU
 UnptbIlSCQPd1vz6fG825yyjVNr8lfZjmuNHEuudLV27Jbkekq9Aef17laWXwttp
 lvtLlb+PmngZiF8RZ2HxjiMR/2T78J6pLcRvkw++WH8cWChaoW6h8VIv+5qhiSBn
 AsxR4bWIEEL4TUG7IuGcc/hLXv7bt6lvIotGoYw0V+AdQNzY2/PoAyUSSFT3M7xa
 yjCkCPJdVYxLMOxoP9kMA3An1Rug2g/W8zFrinnxqwAC0FZyRQnIoI/PesDHWxM2
 JEZ9Xa8veYykDZornccoO5n19GTN/OlmV3RJae5bL4qLuJW8r7cy2/WL7jUW5FhF
 u+iKf2Cf61ekLHZPIxA6T0gOSPPFxw9Gzxx+DC5Qyh5LlBlTv0ko7aMQf0df6K65
 bhlnWMNcpP1s42vELiY2yuKfd7n+sSC6ZvnPMM8yFYciqZEyUDaMlw9PDlYV4hPV
 Z0+mLLv49CrrenFK/pX/
 =hsrI
 -----END PGP SIGNATURE-----

Null pointer dereference

Arran Cudbard-Bell at 2017-06-05T22:29:58Z
Files modified:
	* src/lib/util/socket.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/2a205078d006afa4e4dfc034449a4031d01225cd
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org

 iQIcBAABCgAGBQJZNc7vAAoJEP+k1YKfttfKpiUP/iApCudetDUQtJ6LoFZQimi7
 tr4Oz9BYRopFRZlfFlwREr4w1i/QUoklRgOoalViZhYpSP4EaGr7osPKWS3PHP+g
 mjBTnBDcbf18dQFYOv05rF2+pNre2kaUYY2eG8zsBJwS86m9Y75mJ7/zSLn2ap6+
 1evjiKfCWOffHrYnjhYmQmkYuM+LvSFIRr17sBXv/y2UWvNx6+LHEjdggxu927vn
 bhlIa7UhxDFxT0Fxxzx98n2Jko5goadLTWupO7WrHi10+sa+Dk05jRbAGZ46EIOn
 iTrKyZsuS9LwCNqYNSgzAvvzXTaeoVA4zDdWU1SUTWsuECTTFI7ozLBQcoPQLZtr
 z32IoXPM7baAamFSpgY8N7SVIzT64YSrgg/SybgyXdGMeuvd4WYDfTYpCK7xt4Bg
 m+1RgSeiUyOXEMyp50LjpIWW3fYRaT5WYuOe19Uy9yruH3ZCgXKonndK7MMRXcIS
 02x0bjZ2qGhfv8gbeoxxqRxm5V4FWOW7+QijRAfzBWjhjDzpN3sflb7sxbqCGpoc
 BvWUIsp8lTO2w+C6jI3UxQhlVqRl9gFQBnuZzIbG0tWHQ+cbZ8rFMC0BK1Yl441a
 KxXpXOV5pG2ciUw2oQuQ691OjWYL4dyfeEeqni3ZgBTre5K79ara1kMVdxHuPdhF
 qGaFfRMVoJp9b/Sn0oaf
 =vIgf
 -----END PGP SIGNATURE-----

Move don't fragment to a function and set it for connected UDP sockets too

Arran Cudbard-Bell at 2017-06-05T21:36:47Z
Files modified:
	* src/lib/util/socket.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/932c97d91c798ed0b5c1d3f9fdea680fbfa011a6
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org

 iQIcBAABCgAGBQJZNc7fAAoJEP+k1YKfttfKp84P/0Vr4JvA7xhy4U9GaZMghXrb
 jOWDzm4vRPKSSHJfu5hmCsJm58sGwSiC2FT084z3/Zsa7/iIFBGea/2aAOnH3vYy
 ss7hqvRskGsf2vqXwA8dyGTY73RWX+7iSNSYvaGExu/11TFuRCc6WeL3C61qK5n1
 BIHDRLZML5ZCW/JEN5DORV4wTT4wQ5YV/0Yh5Yyl5XXtbf93UfnMBdIOA61Lu8TL
 HLxDf0kd1q62WgXlD+q8xQcnN4LtR4pOxgCK1Enp2JR+5HCO4AJr7e7HtDeG/iZX
 k8loOYb6JMXFc4omfvcnhxmvlRzCT8bjY7ORGPkkgp5dz+18GJ79a1GUIabGdVvH
 mg88SrJPK/BPI3sZc9beGzVczFqKAUs2dEGSVA80W4Jn0CCzq5fT3fHYHCZ0URw6
 IiGmqNAcdqbuqKQvl2DkP1EkbpbD8qilj/AtWDlIUwv7OJUJCIuH9HMPu0GPA6as
 /SefZYf2bhsoCXv2tTUYjnHZQB/B0cE0YyfzHw5qt1CXbFc9eGCoHUPR3xVELtWQ
 sNMqE8G4v5MuJyWyooJs/ubYhszmddOivDMwFmDU7gxMijkEjEsyVL6y7hb6OyPm
 3J1HM9vmHxhuwUWbw0rLix3oCufizO0ZtxQnbZqOs/G0lWadVBi+I2h26mZHF7Nb
 iMroQa7YELZLWcQ/19tj
 =Cibr
 -----END PGP SIGNATURE-----

Fix typo checking return code

Arran Cudbard-Bell at 2017-06-05T21:36:31Z
Files modified:
	* src/lib/util/socket.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/e4367e10a4c0f145c07e4a926e9b23eb2f437f60
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org

 iQIcBAABCgAGBQJZNc5zAAoJEP+k1YKfttfKV2MP/3k9xndqOFAgvxgtyrkIznh0
 yFeIg0ijpSquSMCrTJE8EaC6FSpgCwDDiL8kwL+wLsnssj6NvP+GiqjmwQlYfliy
 fbj0RzfVJyo5QjQkJt4B4u6FhgfUucjxvE/U6ef752u4l+UEZIIwdHeRtgn/fFI/
 dF2pht+HhXvAoiB2DY3HoGMGPrR0rlQ1eba9fG6thJyzVmyvBoyfEoimlssGQMw4
 3fmv0xZ3qXnDQKKk1oo+OmbL/N68kFrMgI5FY8LNsCffArYzbJW9+DOVgvLKI1om
 0RVGPo7zD153Y5aOfLjjaWN5V2y1lt6Aot+h426/RPBNiTbb7V13G6l7XO+pblbO
 BVia2CFRAnyKjTijF//YjLlJpuHLwX3NKS4T9aO/r46+AqN7JReWYyK2k5XoB9RP
 PoBxWqj4ydp02DPt5aVNEvq3BAJeXeFnNG2McvP6QyBeVl5vaWmzo0nQpMfOCGc3
 EC4XRQEA31xw/qkYqeaHN8gtkhcMZmF6HzGmctk1xd3gqJEo1gnHNGLc1ahCrum/
 MUgPVazKY/7NO5y8hBRfunU35z+izMDhz7mLY5/in57sX/mGGtu5KYuArcHRMS0q
 ed5p62M3wQkdxg3ko8Z6DiQ7KVUOYQF+ZWh0bvekYGkN1HzTC986MSvm0KuDHYO8
 Wud/nvmDIMyTi0Ng9kKI
 =DygK
 -----END PGP SIGNATURE-----

Typo

Arran Cudbard-Bell at 2017-06-05T21:34:43Z
Files modified:
	* src/main/radclient.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/08d948b753b8dfc368a20a18d08b70bd93ee3eff
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org

 iQIcBAABCgAGBQJZNctrAAoJEP+k1YKfttfKbw8QAJTHcHi9fFVDfE2F4U+iSoVf
 f4GaVUY4Bik/slUFp5VQ8glRa6oFo+yZh8wZFZkjTxb2pj++jbPeTgbDl+hdKI3j
 hBcpsqBbp/XOrqbXDzJ8XBng+5at7T6TBfWMRvMiFXRTe8l0ZwsfZvoaSNOpB+J+
 KchoFb8mqtrsgMPoOESImmfD9GirJAeIVTpSybZ84m8bc9OOEk5EDqhWXL9nSYxI
 libIIqNTMffo5ozF4FK7NOf7xlvuqRcuZhe62it3qD46TafYzalUaBK1mxI3znJT
 hTTkPv7dnfACqNzaQ0mbOrufaUfe7Brg5SpGUFZqq8h1B4gUUvnqUDYw6phGjIAQ
 +ATFOKUtzhoSp0onnxwg83xxVcvmWvInzK1ccjZnzBeMLfxpCtkt4EyggWTJxAyr
 uMc0ju4DgUsoMJlS2wQqy3Glby8cYK2YFpG/8lRgbyL8rBZPQSFyaLDW+/PZILRK
 z//m1Rg+XXPUmnJtM8c4MB7NY03kE6ucmyXU05pOvga9W0FFzqa3Uy5E9vBrNmFg
 gY3IisuOOtLXBSfQffLaKg0Ty1rHPmztDylce3/cfyg/1OQretPdKqq3dQDVFnFi
 3Xx29uDkrV3u66yhN9/i63Kqna25X6fRQCsCDFFflvv1LnIdllsfEes0WbbuORIR
 Xl4ORnuA6Et66samZ92c
 =bFGi
 -----END PGP SIGNATURE-----

Remove fr_socket()

Most of the calls use fr_socket_server_udp now.  Which sort of works but isn't great.

The issue is a lot of the code assumes unconnected UDP sockets, whereas it should be updated to use connected ones.

Seems like connect()ing a UDP socket and then trying to set the destination IP address will probably produce obscure errors.

Arran Cudbard-Bell at 2017-06-05T21:21:47Z
Files modified:
	* src/include/libradius.h
	* src/lib/util/socket.c
	* src/main/listen.c
	* src/main/radclient.c
	* src/modules/proto_bfd/proto_bfd.c
	* src/modules/proto_dhcp/dhcpclient.c
	* src/modules/rlm_radius_client/rlm_radius_client.c
	* src/modules/rlm_replicate/rlm_replicate.c
	* src/tests/util/radius1_test.c
	* src/tests/util/radius_schedule_test.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/6c83dc9cea097373f009b77cf4c7d65fea106ec6
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org

 iQIcBAABCgAGBQJZNb5fAAoJEP+k1YKfttfKK3kP/i/FkX3LUJar66JYLl7nYt5N
 +jmeglsM0ToVkI4+RMg4ywwDLykmhfOBsuC0948iNBMHyORgqrV77SIZhlbJp0Sy
 +8VZZz/1w9zZxB98mvLVys4D8ixY+PBM9Y5UKvKnFU+0kAeNqjjSe3w8hudk9Ytt
 8sw74X6Cg+N7zx3U1r6346ma27PuuP27k+cSMomKj9QuokkdPCA2+I3vphONzOBm
 3w6WWIGXgT12lDpug5kvRCexCSSfi8CNMLu/yn5bv09DQugnF5BSOYdkq6j/2/nM
 j+RVKXegtpjFH5X/4bZ5In13IFmU7bVT6SmnyGWCDMKyPmWLAoSj0s990maw0h8J
 IYUKR9an6yz9c+J1RzEJNtGLzFsVA0VvNDU/wQkZGff2ikAG0P/phOhp3ktlZsLX
 GLeCfDsjZt8fghWldQBdRUElLIo6OOzSZz+Im6BXRqcHsUpKVXIAJ1AXbtdiXMfU
 9AlBkDCKaaZRAdVM+g5Z8yz5F4MKrm0ha6ZI676mhqgJrZFf1SGA2ay3o7Lw/PCe
 aPvAmEZz441KFC+m2p+qgGRohpJ+1JTfDio8ezC1AxLoj+9tsMlIKwSFS4wOZ8dG
 qrqB9vHTo6Gc6F9vS29Fdxit7QLu/rci1GqtUX+PqwR2/Sk+OGIkAgk07AuP0FRw
 VnkfYBLMfH3Oyfoa4+8X
 =kvOT
 -----END PGP SIGNATURE-----

Cleanup socket.c

Split the socket opening functions into udp and tcp, with the common logic in local functions

Arran Cudbard-Bell at 2017-06-05T20:26:06Z
Files modified:
	* src/include/inet.h
	* src/include/libradius.h
	* src/lib/util/inet.c
	* src/lib/util/socket.c
	* src/lib/util/udp.c
	* src/main/client.c
	* src/main/listen.c
	* src/main/realms.c
	* src/modules/proto_bfd/proto_bfd.c
	* src/modules/proto_dhcp/proto_dhcp.c
	* src/modules/rlm_realm/rlm_realm.c
	* src/protocols/radius/list.c
	* src/tests/util/radius1_test.c
	* src/tests/util/radius_schedule_test.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/097dd0e4595f89db133801ad057b3c97cc42efb4
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org

 iQIcBAABCgAGBQJZNalZAAoJEP+k1YKfttfKXgwP/A9knUYUy7vetJ1IgyZl5tAq
 2pBxeToHDRGMVyAIL2VyhcZYJGwRpVY/oKKnP2lCzxeeBkCyy1vBqCJHCc05Rf7z
 3ZsHhmBk77Vc9j4ryxN9weqwrFxF+fC69dRfpaLC5P24LsP+IbLu1gnYYEBoVQdd
 SiIIRPOgvmaf0c6SolBZNf5r4oyd/0WAcisq5IUHdYubNhdibBxPfg9tAcKAmehh
 MIx8UuXPo4+ZyUorz1bWrYIuj6jsNWj36QTkYpioxcCHzkUOTPVfqHcmKkxVWj1v
 ZWH+d61jv1pGWCgvJOjfxrvWoN73UbbwOQuxej1RYF7nu/kKJe7UckX9vXmQbaBV
 JCYT8NpWPZ7mt3+uwqIpHEIGDchG2TCrxJIGKM+x1Y9K6/yp8mHlr3nbkn/mz66e
 0YI9VWzwMw+7Bi9VoP2gH63A+XX48AeCw47bw1GbKaCbKM5tuwGD/RuD9E2QwKPs
 ipqMpyAhtCwtS0HQ2uvSKa6RyfLWY9tSsDdjNRwnBdALPM0o8fafnMECk22Kij2f
 syrwE6y/CN1u3bNMt/l0ta6wxcZ4GlGGOVSwbFUqU7HZMKL2JPd4IWdLKkj6wmr1
 23VipXjyj9wMp26hAfK0ey7rEs34dj7jda9QqkcDwrSJElGkYm7n6Si3clRKXUcL
 DsPH/TjgcMIYmSPG9bxe
 =7Nin
 -----END PGP SIGNATURE-----

Move UDP socket parsing entries into a CONF_PARSER array

Arran Cudbard-Bell at 2017-06-05T18:56:25Z
Files modified:
	* src/main/connection.c
	* src/modules/proto_radius/proto_radius.c
	* src/modules/proto_radius/proto_radius_udp.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/6d1ca0e3af6568674bd5523ef5ea8c688dfc3edd
====== 
Fix typo

Philippe Wooding (via Matthew Newton)@2017-06-05T11:16:26Z
Files modified:
	* src/main/conduit.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/fc401499e03cf569770fb768e99bf2eac91dc5d9
====== 
Rename more functions

Arran Cudbard-Bell at 2017-06-05T00:55:56Z
Files modified:
	* src/include/pool.h
	* src/main/modules.c
	* src/main/pool.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/ef489edec607140ec77615deb383367482a5a143
====== 
-- 
This commit summary was generated @2017-06-06T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed).