Commit report for v4.0.x branch

announce at freeradius.org announce at freeradius.org
Sat May 27 02:00:03 CEST 2017


New activity for FreeRADIUS (the high performance and highly configurable RADIUS server)

======
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org
 
 iQIbBAABCgAGBQJZKIlsAAoJEP+k1YKfttfKDx4P9jiWWYdM3kBQSePafH3ef2q2
 jHuPfMES9Qu6d6C9TdEq+fY2Hpo0ia+U37MRbRBvHmArxXtvHNBTKW3W586fYWGP
 JHmc0tsfm2oV/wUSoQ66y1XeIa2zb/sGGIp2WJmu12soityjxkEKHcVqSLlobSko
 M71k3mcOHnODAqmCK+HHC+NJqIbo1e7j/Z0QoNcbkZVuib+ubXiizPXG5TMHKRqA
 iAwX0dMK7gQ7a2/QV37rvMcXnzvyyq+37ve5DluVJpDvPnHBOHkau0oDpePTnJXa
 cgxGKr2uI1xp1i3l9NC0xnq26zOWwI9psIggMGq6TZ6zNiI1q6GASIT+q4FXT0Xm
 VAABhM2aFL204x12KNb5+ko0LIaGRVKcyZdVotFmVRyJbT/y5lge3nGmbTGrPVBL
 a1QKZTNO+kiFr2r2f1m113paOapuwSvg+cyPKNqy9jfTiRrk/kn/WtecxemgjKjZ
 5LIjJ5aoLAjxywDYiMZR0AOoGH8HdSv7wX1YznFe5kUYJHY9LMQaAJLHWrDU/Ddy
 oU6ux5+NcSq2X5foF3loGXGXnviyK2ay4jWdbEvqCzWid17Pl0FqRTGIkPfdAifS
 WJJ+bqm14utrUAAErQb94Xcl8bTqFHmPiOUMZc7XIr7Ub8GVoFY6SmUu3u8egcJo
 qCFczdt8VNRt1I14b5o=
 =AKl9
 -----END PGP SIGNATURE-----

Just in case coverity is really stupid

Arran Cudbard-Bell at 2017-05-26T20:00:44Z
Files modified:
	* src/lib/util/dict.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/1637de93a0d241ce34aa2b6972b206dc41a65769
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org
 
 iQIcBAABCgAGBQJZKIjfAAoJEP+k1YKfttfKPLAP/jiKklt4ZQTPTm9jORWL5woX
 XMRiLvd8z8cFPTsC3vV7mB+darntrqmFb+WhSR4vrprtG2HheU6mE1xJhec2p6S7
 dFmT5HY4UJPLHBKoxnvhc+BCIPkQ1cjAglazyrMc7A65SXrs7pEXcJa3vnoYdRfy
 8aG1+DMkea27dM3s2TyWZQDVjTxoOuGrrF0mskWJ0u47mVaOYjq4RuOMR3G4WoJd
 8iMwY3pss9HS5n7qgZ0eVo9kCOjafHeLaGeSpm/aUD/E+QGf6mKxDV95lBDecvss
 PHv4yBde9JiPyOCRk0Zk0Fn74T7nRfnaolJgOOouSuSprois107/OSgA5y7pb1L/
 PF1TMYYj6VIjvkA045RFANvW3wiua73okhxNDZGZN8BQZVR6YAxjkba5XfoOL49r
 uCEuYd2Fd8nuJy3ztAzjP3ZRkSJcScpx/a9iTn/BSGxqhg5NgYf1n1cW3xkvJyPf
 GrxFnHiJ3OseJP0eXV6g95Tpb0gVY5ehJSt30qgeqYxvHbbaXO/p4DIro+Lc6m0a
 fGXRX9247mrTHfafsNh5BN7La8DSZT/V5wHM0Oh8oBbur8N+2jl2kJ1DByDrZOiz
 ngm2XivcveqNbMsVrXpKQOoS1sQej9kwFSfig6j+OdAYRXdEf33nJ9the5GvjJw3
 27SAsA22cf/JUn6hU+Bq
 =JHl9
 -----END PGP SIGNATURE-----

CID 1400066: Check for NULL parent first

Arran Cudbard-Bell at 2017-05-26T19:58:23Z
Files modified:
	* src/lib/util/dict.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/6767354f79155c785b74e458e4fa4824b39c0fb0
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org
 
 iQIcBAABCgAGBQJZKIjfAAoJEP+k1YKfttfKQZ8QAJgjlQa+GkhakmyJaqn+VDay
 PgF4H/k6YqGzYNgHC/En2p1kbnvFOWEox2jb0GAwhb0YtsUgdfMZQoX6ENL/Jt5x
 DjwJoopMYyx9vQezlCF5goTbcbXWQjAaGr6+Kojx3RUI7idH88ojzxwgSD6j6vvQ
 cvI8k2G3zL+dHhZha+GazXN3ItzQ3UUjokwVfnqEHckkXhCAfYoZEW2Nh9ChIHi8
 NQfF4xS6hwtKNOFdUSyOtIBEZUx1qPM5Sz39L0/N7Fm8cq6ydZuTCWo6ZS+/l7YA
 Z4qa3XHnCUyNjLNIJ6VZGhDByNgHrBv8W3rYsj1mYVZB5iYAXhDYQJyE8v64Ktzo
 BZYsEMw7kMVb93sKXqK7c9lFnmc9C4HJ1wN+WXCKSLLM/tS0+pYIAAK99/mraos+
 ki7TRXBAJyuF4GsIm88fFCpjP3jpKHAUNKCOQ/377sTaIFOgOMeFc6hlGnX2WH/B
 R2yrjCHRsSdFMmtfvAwik/F2JM+lqFas3yxB+xkNSzaCfZsedeyc87UfcmaOTEm2
 VCJsoxcGTcvXlnOSit1cQF1I5WNlhj+eWkA9FXvW9ekMqVZlcJ/LnZuWi35oZ9HI
 Uv8IgnIG75lWKpjRjLT7ih9haRtRkhUECS30hYcMbxhssbMd0EPr8J2tjcWq1oqb
 hrRgOeHjKoMdAiVay2NP
 =54VD
 -----END PGP SIGNATURE-----

CID 1409861: Check return code

Arran Cudbard-Bell at 2017-05-26T19:58:23Z
Files modified:
	* src/modules/proto_bfd/proto_bfd.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/4ea8d884ee7d3e2bbab94470d142c0fc1f7eef62
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCAAGBQJZKIjMAAoJEH0Oec13Yh7NadYH/2lye9tFIXj6jvttdWiTqW12
 wTNs3g5PEd09cFBMWpr8ccVcxAMT6/bp2mGdSpScwrNweNwRLen4qSFT07Jv/VAT
 uKAoV0S7mOnaVL4M83Q8D7WjtPgus4SRFXqHx+nYBq31cgZ7vjWjLV9TbskcoUre
 wcG8AND+K65OsMa3ZzuOuDZBtrtQE5uOAVBN7vqlHsT/cArN0aijJqhmiZaEjtZE
 yxrO8sfzieq9X6xBtYpm6/lwCtGS2zVmafbA4k8FqyneSrKQzj5uM0/lBNpOlFmF
 mloMd2jduyuw/Jz5Iqc+KlCvfheMladO5Ek/P1oYX2UiohIJ8P/aA+yb1KnL6wM=
 =xqDj
 -----END PGP SIGNATURE-----

no need to check variable

CID #1400066

Alan T. DeKok at 2017-05-26T19:57:53Z
Files modified:
	* src/lib/util/dict.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/0136c370036443c27572662a53fb81c74e850b08
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCAAGBQJZKId+AAoJEH0Oec13Yh7NeYEIAJxLwRU38Ae5U372D7mSJZRW
 IWorj0f4Fop5UuGtNOejq2Mp4QhZVjlku/2ueZsL+DSWlZ0QJtWAgKDauE68Vrhp
 6MJCnOtYhFUgsDFMxfSN/XNzBu0EqCs5H5iFzyxtJ7Fc0J1+54dPh4xoVVgoOF+E
 1wMrC2GPlJjNwoPpo+5WC2n/MYokJzP3JB3ach9JI8HsvHQ0ICyYmOjAMduX9JLW
 SMVFehoO73hP5ERaQlsDblryMivcWCipZf8+6wOGui0F/Ix38Ms60zXk4qTTpGXH
 HDsx2+c/4kd5pD0QbCwuvFFtzUIambLhjQdLu3EgTwutd+J6u7SLLcH9XbziEWQ=
 =70No
 -----END PGP SIGNATURE-----

return dict, 'out' must not be NULL

CID #1400033

Alan T. DeKok at 2017-05-26T19:52:03Z
Files modified:
	* src/lib/util/dict.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/6c79b325d040ef4df376238cb435268dc7776bd3
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCAAGBQJZKIbuAAoJEH0Oec13Yh7NiDEH/jAzC4+QxLCBbW0Ff6nFE3Ro
 1I+nm0ysuxozTtFPyZl94dXeG+6X5DZkh5u1Zqw8srLbE9Xo7+YXbqG/pSd80PU1
 ayZRgMTXEG0dqpwzPadXJizu9crmnvYagrC7vjZw8adPlXZSKhE4kXUMi25Bf+B7
 3FROhfEUmAnKkjNR0ZseVlg0c8X8PebQBjZYnurcsIm2HZFgTRAwK1P8nH2tU+MX
 AdpHJFYV09jF0mO/HzXYZ7lNaPaj2suz51KETywYVmRITjFUo9CmeTMv7ezptf2W
 OEGXU2a+kUKaBwKh9wU6llnTbu9dq0fih4vL4SM6aXujvY4ELeKWZ4VJp0GLryA=
 =6u1l
 -----END PGP SIGNATURE-----

remove dead code

CID #1400032

Alan T. DeKok at 2017-05-26T19:50:01Z
Files modified:
	* src/modules/rlm_eap/types/rlm_eap_fast/eap_fast.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/abd133051c9563e1c76b4fc77489d5daea3d3955
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCAAGBQJZKH8ZAAoJEH0Oec13Yh7N9/MH/i6CNtcTEWl+NiNfZwz/zqsr
 wEwQIUNn2y9QxoJk88FBADQauBwCZkgvrO+5AK8OHkr2avFbFLAgQtp/mNY/KH9J
 lgKyIoGNIdOd4E4qHq1hgMMHQCveVswDIcUIEGCmn85eVMyVTyb3dQsk+Q1VP6th
 L8eaC/7dRj6zMax/PtYLdVC1l+4DsdNfW/covJDG5UTYhIIR1criV7FcfYLm/Tgn
 r6iP26whEH7LHtdNDii3TotJ4xKOtNmMiJFsujmd+3XbaWe0QAGaUo62pGyubDnA
 KhYYY4/csxp6AUq7CWIJI0J0UWKhbSVLEB2l73lU+LV0pON5XXZsvLHHNEHDUoA=
 =z5pc
 -----END PGP SIGNATURE-----

check for and ignore stats if !request->packet

CID #1400038

Alan T. DeKok at 2017-05-26T19:16:41Z
Files modified:
	* src/main/stats.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a43d1d9fe0e0a2f46c2a5856b77ba6c4fe56ee32
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCAAGBQJZKH8ZAAoJEH0Oec13Yh7Nhf0H/3c9lHwTKXFbPS49itsgxcFS
 cpOPxSOvUQcv8lo/7y9vknfn/S7Q+aw55PvOPp3NSEBm/IiAGV1Mtt5DHP1V01KX
 k1XakPBvjAfm5gkA5SEdcV8nXAni3sdq2AqrO3uv2PBU0uXq6SqwHyfLZZI0+xhU
 MyPfH12pj3dV91NNeHZLkLbzylYBEFb88MyPS6PUYaaYcfMjlFKXJtJcpDanfj2E
 OaONdU1X9DJPptgKJGjdfL1aXTOAQbfW7oIAiVaQYvl7OqWpQkkpriIw2FfGSpmc
 2ebLlq58d82vz+h4aIFBneJrOjFdiFaDmz9hqIi1JgfM12rq7ONEF5gzQbiXSU0=
 =Zd5G
 -----END PGP SIGNATURE-----

ignore errors on initial fault setup

Alan T. DeKok at 2017-05-26T19:16:41Z
Files modified:
	* src/main/radiusd.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/07eafda0b60d358e0bed6e5dd2a94411e88265ec
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCAAGBQJZKH8ZAAoJEH0Oec13Yh7NSYEH/3Tna8nXhvG4jjIygXw769Xd
 VrUtnUCrGxe7FDkQot3IhNQJxMv9o8wV/k9HZXYw55zlY5tivC1EW7bLsbLTNsWn
 KVxfALfgOFE8dn8+DhKTZ86tUvngST/B4+VnOG8+I7mJctbCe72XOOYrWpnTRcwr
 rDAyJsiD42kJo22qVtTTMPl9dEMHfPyBZjS9xFYEI6pRVPZ7ZsMTZfo90L2GSkCF
 pmSZehR2wfCtS89gHrCxkmJ5N9YBDKxVLfAfiXOAr/YjNaCEkHxX13CYbjg9izJd
 h8Fhbs6wodfBhm6y+mrAjncO7ukpTBg/ik/jDRMlVQRvX2TVz0KBrq3Oim+pN+A=
 =LWxr
 -----END PGP SIGNATURE-----

cast to quiet static analysis

CID #1409876

Alan T. DeKok at 2017-05-26T19:16:41Z
Files modified:
	* src/lib/util/dict.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/9a410efaa4f9fc0d0356433cc9f354301bd48d41
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCAAGBQJZKH8ZAAoJEH0Oec13Yh7NenUH/Am+YHQlL2C+mJbxd7wYHjM9
 kN1q3JDQCpfNa7AdVL//PscV/E2wIrjJ7bGwBkrvNQdQnuV/zeiTCDZZ6SefZSBb
 DcqI5F9tI/L68KEOrAJi1xLc1Xp1MSy6I9Tr5aGEM6C8IMpmsyF1wMOaW5OIG4e2
 Syu6fBPVR3+FeMZ7svd0RYGdRkpjymdQblOKz0WHZgCdY/MVmKcpv61r7Y+g0Tcs
 4avN296UOlgWjxIapjQ58GTCxuNePAema0zvB04uOfqI2ML3A+Oh7nMPnD8GvGXl
 +8IXWfhoXN/ZiZ8D1mn6WraqCTbkMYkcbKsy1xtwRbyjzA/wPiY9INi1mdubGQ4=
 =hh8j
 -----END PGP SIGNATURE-----

check errno, not num_events

CID #1400045

Alan T. DeKok at 2017-05-26T19:16:41Z
Files modified:
	* src/tests/util/channel_test.c
	* src/tests/util/radius1_test.c
	* src/tests/util/worker_test.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/c792ac3456756f1e9a38e654492376b38f801420
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEbBAABCAAGBQJZKH8ZAAoJEH0Oec13Yh7NJr4H+LVmg4JIR6wj+bZTn7qQ41y+
 zlsNeqZIMFavqiAWkWxo20Td9reC1c6Ds4AFUgulPhng8eCT57kQbORRQW6IwqUP
 eH12fncXAa2xVE6G1peDYF3KeniY/WyKMB7AszNO6YDEiMV7kWob95UxD577hmmE
 XSCmttotkg0poAIAxSdlhKFo8rUB2wEAVNu9EXK1bpvmEAJ5Mqjg8cEN8aviYIGW
 cDZ+FHnDmD7A/Y5wQqDZ1CgJZzIiv2HQy1LtvrfWaDMCapBaafSp5Tnoz/CWqLBY
 iI+MJMZBHWOg0if3VvG8uFrr8U6kEJlX0CObV/QWiDsYlc7KpxAmRGcbSTi2NA==
 =FcLY
 -----END PGP SIGNATURE-----

don't lock if there's no interpreter.

Mainly to shut up coverity.  CID #1400046

Alan T. DeKok at 2017-05-26T19:16:41Z
Files modified:
	* src/modules/rlm_lua/lua.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/fd2731052018781b0327dcb2da98197e7373dde7
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org
 
 iQIcBAABCgAGBQJZKHwzAAoJEP+k1YKfttfK8HIP/RbovsKa+LWgufgpJfJoBVCE
 eseyIOVmY0oRXQCEhQa7dumx4K390upY+aD06vMGj+UswtssEdcvDt62edSbDUSY
 qDcRHqoUGUnnQMAUKIs3tI9Fz/P4KTVxzyRzUfHtr4PI7zkP80jlSeUOcnBKHRva
 XQus8v248KMVF8t2v9C/ctKFbphT4VaLNdqicdsEQfYdkWxiWYuEhf6ez78n/KBB
 a56nwhK8+ncwPXeTyxLgU8pJIflEAm4jDl/YR4J+/i2j9okliRLzRpbit4eJc1JH
 ylA0N09T6cTNy8PxmKSbBLtRVAbstu9cKv/r/wIFFWxylM1TdQjFN7irlK0P0zxm
 V3TC0rD6XKDJEvtZDF2sXNXyfQKVQDtf1XKez5u4/rVOClT3bP14vicm+wHK4MWZ
 N2vh/T1m/+ugnNz3ckSm41FC0ZpvXfLuwi7FqqdBJe4fyazjAJ/YL0TCWtLVivfz
 OFnPgb7Nq4mWHtaB3ZN+gvwbFuZBUu5yBTnwBmjYTSw7b9Vhb7SOuqvNsx0PwgOT
 rPawlP/UwuIjYA7Xg1Q2Tli+5Hf7/UYKf+UMvEvhP7TcI4tgwtpNyovp6yrv9ajg
 JV+sVt8T4ZLKlioJ+QwS8znRXeUkfo3OuYA7JbS0g24BNovg3AFjFuZh4X1Zgnt6
 z7LCVqqwKd7oPr5RJ3vc
 =nSm7
 -----END PGP SIGNATURE-----

CID 1400023: Check return code of fr_pair_value_from_str

Arran Cudbard-Bell at 2017-05-26T19:04:19Z
Files modified:
	* src/modules/rlm_lua/lua.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/9abcb45455c907e5135d8a704f2107111862575f
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org
 
 iQIcBAABCgAGBQJZKHwzAAoJEP+k1YKfttfK4hkP/0JqJKkeofq+4TMzjxPXgM1j
 YgbYVeoMQB5nJf1HvcpGX5xLmhFBONbQ+wQo7XEGOmzxO1ypyVduzkA8J2LT2mvr
 fzEMUiVLa1unLtZ3mVzNjvXr6ElZ21Y0vlevqvxcoYjkGmqYO58KEK5n8D9MSD9V
 mEnkxsvr4/oYlkSkjOjWdGYy8ciQjbj78eZd1f2H3RH6xFg54BG+3JkiLggaR/HK
 5yxnA30IUdHucEFIk5Palpb+4XvIRlwf9Evt9Ne8isRorDjWL6gHIqj+bL2SVkSA
 11nL1KMpxTQvcOYjJJqHSOa2XGJ6HEcprcJ8EioBg8OTFR0jY1z7gWY9FQ84xEgS
 Q6Qnr7XYrYYYXz+AQ+RB+d/CT4tN3VKMUOCIqe3XPRClHJ9S8HhHeAc/Ra92P/G9
 uDTJ8fJOxYKQZBbjMXSQieg+NMNi8aCl1N6oww40QH8V+YMBrSRFd9c3FU6B6EPW
 R6f46gg8T0mk+Jh9YjrhhrCf8h7Zz+OV1QZh6JQtMswd+RTxe/sa7P2eqw3kPq2w
 vDZA7CS254YiD+0VoSwEE9Q/ABuwgluDPSqChxW4RTr0iqB9oXC8BrqfCBew20HE
 o7FgupYekYb8NDHE1KAPM2FdZ/aouXjXtrUv397OtmgadPfL8eBU0IW19Io3bkDx
 eaizh1rp8Vebm7MEd9D9
 =0+/j
 -----END PGP SIGNATURE-----

CID 1358898: Set umask if we're running under coverity

Arran Cudbard-Bell at 2017-05-26T19:04:19Z
Files modified:
	* src/main/tls/validate.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/02b89f5df4888ce2f3296e9ba17e6f298bd9fb70
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCAAGBQJZKEiwAAoJEH0Oec13Yh7N+GkH/jkuQIubZA+i3Au/jGs+Pxhc
 QMt+M0drzuS25IW5bc0nPlZgMzF3BzhqRvFx84J0VI8N1RoNWNCOJgKNa3NnI3rM
 4Pekac6lToetIvsNAeGp7yd39IwYGwBnJ4HoFBcKnNIJkDhopRo9JzldMQ48FqFl
 TNGwDkTrGTHW6G56AI6Cw+X9boOeC+yifRh9MI+omvrHaj9pZLCQuFbhEKYyLkBf
 xirKFBKL6U30GEa1QB9RAaQKve9xITnXtwd2gCSP1/+o6MqTmCJJHDElVsf6K6aO
 JRUMY8Jc2njRleEurdhe+cLY659Q9XXmY2emC9BD0ftx3VB1xiWAtB01qWCHXEU=
 =+JR7
 -----END PGP SIGNATURE-----

typo

Alan T. DeKok at 2017-05-26T15:24:30Z
Files modified:
	* src/modules/rlm_eap/lib/base/eap_tls.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/6f35b1c0626a108d43e3214a0890718ad1d0a3fd
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org
 
 iQIcBAABCgAGBQJZKC/2AAoJEP+k1YKfttfKekMP/irJ5t1NV66VHa1uMSytynpg
 5F92XrcriNvYTb94Pov/5ITXcTv793cNVBd3psWNfPNlNfDYa5z6kjgpyhNC920+
 twR4Jw0KDJemHkjgtplQE84MZOvJuBNo70Y9Ilgr/fO98mvQlpKfh4bXPHjKGtBX
 3ngYfSJthLBx+bR9pKZDOSM87D1uazlObL68zDrutDNuuCv9utB9yZ+og6Mn8yyA
 ipel6HRHBLE7q/+B6yGdimzmwddevRnDjur86/GaSKROyP2/njMPjpzOZYdeuI20
 2WQ1YLXgv14goKDLMdOOJGqPxdSnStAXdJL1IZcqBx1YatT5BY0xkEue3i1Rn7Fn
 /8TrDL6Fqusx9RpBVsnMJMcKg6FppZaQ5nBD1LpLzlTUWWZ7g2hh4QHPQalTA1ep
 XsfkA8WIh79CuNysISJEzNff9fImG6vsIuIU4hVUtMe7d48LSV9c6H5sr/9g9zb7
 64XwFXOS6mSJpAVK5CJ+QAUtaSkKZJcFzyVI17UNyqtT+3JB/ItQT2wH0bCEZ6I2
 pHjAeqqRwrTOC4BJg01M88Tg4KbgQddfzbbsCUZL3nZtuwrQHlDQg3vprNUXfn5H
 OcZr4Wi0p02dZGluLo2A2XM4v1x2fwEVcW6iXjRcyYodb+txLdPJb63z0LUlXG1w
 RcuoXKEjouTUNRIp38mf
 =QxNE
 -----END PGP SIGNATURE-----

CID 1206505: Check octet/string attribute lengths.  This is already done in VQP verify

Arran Cudbard-Bell at 2017-05-26T13:39:02Z
Files modified:
	* src/modules/proto_vmps/vqp.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/9c594e2ff1a5af75da1d9098d4329685c8dff8ce
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org
 
 iQIcBAABCgAGBQJZKC6oAAoJEP+k1YKfttfKviQQAKWT/Usu20+BW9HDdcj3ftHw
 lvtxLa+9vWYB3MJLAZJOJWTB18grhgLngH6jyhGSj9YVDBnqTPwB5Kcbn4pX/au1
 p5uybDXFQY2k1+16QHMGVepbYPBVLHU2PRdSFOB6KXpZBlf+I3tjWRYZ+pZx8+Az
 LDXYIsLhfHAniyqooBqdu/fCw5ioDq9aosJ1LdhOoU1vN4aMh/ieIp6zP+TKArDU
 eP13/bKc7d024dBL6Ot5h9I1zos21YKxukXaSHD5rjsW28gCNQSDOD9IqeCFPYB+
 Xj8D/0ZHr8wPGhPyyvvxZPyMV17eQxgyUuDJHa0IVtXczlNWt1OkHpQbhTkVJ0wK
 VpQ242bP9pkTAlfwuetVuwfD54ow9bMkF51qZso/U1WkiWURqNDbT8NMPVSF0bJB
 zlAIf6GZC9DvIus/RswvNqZ6PMNE9kwThFU0srgi8QjbQn3ZFTfdqlHoailR43rr
 aIVcZVhkU7Ym/G51MTfMKy2VUlkFKB5N1lCRBeAlTn0ElRFivxVbzNMfJNYwohID
 /clRKFIHKZTCbC8ejNBctSfFD6AD4y/0hGn+SmAfpWehJZW7Mr60m5HkwUV0fKR/
 iyoEIQoaS2/QTYiE0Bf0cZTOHg5YTC+35tmHgMgYKAI8Wwm896QBwvpX/+psOW7O
 1XTIMdjovqcWHibb36vg
 =z9T1
 -----END PGP SIGNATURE-----

CID 1104354: The high byte of c is always 0, so don't bother shifting.

Arran Cudbard-Bell at 2017-05-26T13:33:28Z
Files modified:
	* src/lib/util/misc.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/4ef238106ffd7577475b77d58e02d76513e8578a
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org
 
 iQIcBAABCgAGBQJZKC2RAAoJEP+k1YKfttfK4hgP/3wh18eDSLSoi9mBEr7UpvKJ
 kqRXO4EhjDtgR1L4tM2A6vFFBqMapknrRORQ/bZyhfx3tw/fbiCaDzazBoHHdIPy
 tzBd4uauUD9ltFf2cGdx6rdsXzplwsFkgbmp4NKD13dKzyVjtyNYR5wPyeklyuyo
 eKVF9Iam2AhU3oAxDMF++K4je4v38ybHgYgDK7d/Z8px+xcXW40nobrufRMEb6dQ
 IRbDXJ0Hr+4H3CTNe+oK4jcNJV29dE5Ttw+GQQt6fMenVjvYto7ppl96LN2cv6f0
 ZqkuyKjbp7K9YmxUyVUxb84cWVqZj6FhNjGrVN3VdqKGS4J7dLX+QTZN1B57InnG
 7VkvN3fEN/gqMumWIqWcDYAhLj/HiD1nxYebc52IinhNhyFQNE8UNsO7PpEdRErG
 rhzFg8DzBsVycTeRxy3jniMntV1E+pcybqTT14qdTuRXVktPLIeWDd2nD/svZqva
 VS42XIYKowMt9rVG1usc30bFDK4GW7Hekubf51kwy6WLrgdmLWe9sOHnAvhMrgUa
 t79SaElXoCdUiuRK9+tUzL/pdCnqg369JuyVOZ+WvEJ9hW/C6HX7h5EVGS81OzJT
 ZTHitmpW47p2fEuB0WZbYbuGP/VMkCIX6AJzRPTD3PGCthaNThak5Hw8DhQx7a+I
 jW/RfTlQhWUHDCJOtJXb
 =2Rqs
 -----END PGP SIGNATURE-----

CID 1020958: Fix double unlock

Arran Cudbard-Bell at 2017-05-26T13:28:49Z
Files modified:
	* src/modules/rlm_sql/drivers/rlm_sql_firebird/rlm_sql_firebird.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/2653e4fb6a7e204c0df4cfc10f1b767b464f34ca
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org
 
 iQIcBAABCgAGBQJZKC2RAAoJEP+k1YKfttfKLckP/3NQ5njOW7sTayAHLupRtbzl
 YyS/AFTmTp3uHPIYYx4dN5AUTd1+XOnZXcIcjx/9wlNtyUZ558FCkzGphKIT7YiB
 UZk2UxB/qd492IukWTuUVdIbExceQV8EPg1CrNIB5fN1OzfxqmBDeVIe6SxDJO+M
 g3K/07xY/6UwTZjoe1eHrZzx5wH+5VmxR3Wbfr7PUIIoHiJkFy7LOdqzjUvm3fWQ
 Q1bkyfeyFbvKSeohifHgS4xg8Era7eLtPSYlT5pgXaKGxKpsKha3KT7DuoPXopeM
 xJpJFE0+b1Qf69QkNeaPO/wmQnsg/Hmpv1iXayqoHMIvEQrQw0SPcnWfg9fsnePa
 we3CbQYgt2hCuQW021DinewaY3oILN+Nd67thzScqo1uc+sl0x3aWWy6PNMeSUGE
 E0CrPgQ6SobWpdlOyHzg3jSQFJ96wcpX9HL6bpSRZGvEa0lhA05ETQQoBxlm1QuE
 tmZsy2HPnSU4aVsdk3cHywvaCrbyavG3NrmVWNB0BINJGXl+f0MLl4+nPHkkJBYt
 Q2voliv9SpaAqFFeBzR4fY/PzqFBEvDzjNjgCW66OEFd3/NLqTe9vZOWb0rEF8nM
 9jHCRSGmk6NKSgOrX2VjBDW+a82GPDnEgwVfibua7C/I+WthF4lIxLuo7e16k4fA
 VoDxOl7KnFt/bBKqolRd
 =52Ui
 -----END PGP SIGNATURE-----

CID 720453: Don't cast, so we restrict the range of values to the minimum and maximum indecies of the array

Hopefully coverity is smart enough to figure that out... Otherwise I guess we're checking the that uint8_t can't be bigger than UINT8_MAX :/

Arran Cudbard-Bell at 2017-05-26T13:28:49Z
Files modified:
	* src/lib/util/pair.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/456951e02aa9b22e01284f4cc74463c9802eeac8
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCAAGBQJZKCyqAAoJEH0Oec13Yh7NUA4H/RXPy8A3qEmWa/Wn+C8EypUx
 7GisEO1LAPF9dKXYZ1ZEqQwR5g3d5XReez98ML5+nd7b+slaksg+y8ikbRf+sl3c
 B1h+Y83SbUGNGCgUMUMmiiVIh5UHgDZYZU6iB4rT2l8fIAAqIJh5eQpho0iV72Xq
 2ehq479HTxxe8SVoH2dj2QUpAyFiA59lBieX+C84bc2N2MknB9/kdpKQ/vTGSZH8
 ysfp2apy/Dyl62yMwN0T/PvCdQUPKKRv65WDqHzzqTNTVnyCBCIHDNQM83dK4vsd
 5TFwD1cLBJ1x50zidPZzR/N7flLBYFgX+w0H9pkxtFjUcwEkgvxjV23gj06RIPo=
 =gVjq
 -----END PGP SIGNATURE-----

check return code

CID #1400026

Alan T. DeKok at 2017-05-26T13:24:58Z
Files modified:
	* src/modules/rlm_rest/io.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/aeaed57c7678d0522cbee2f951fcf66e82a8ea48
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCAAGBQJZKCyqAAoJEH0Oec13Yh7NfEYIAI7FWkQzSWLmP/TK14llyoSC
 I38SQruWsde8cX7tLijZrVItvPJ3a1yEmKPvIZH8ZpbgGuQZP8kr33FawH3rjRYr
 LnrFFyOGcv5Ag20R4GzPPPSsvSjDo3REDochFmt8qDkVfxzGzZQU5ct+9l3gLU7N
 7IkhZTgAtbMrt1XO80pgXQPO6RIf2bD+M7BUHkR+XdkAjh4eeVnXF+14Y5OAt7Oe
 nMaL99P4fK6qRRvicKbQ8KwgRvTV3l+A8oWfq2lH12QZ7gpYnrpMroOiPgZS2p7K
 ldLisYRVZm4vwk6uMsQshlN0YjbxkmwWasYF07P4Ixk/8SQi9AWUC7cfOHjuaKQ=
 =cfMy
 -----END PGP SIGNATURE-----

we mean to ignore the return value

CID #1400023

Alan T. DeKok at 2017-05-26T13:24:58Z
Files modified:
	* src/modules/rlm_lua/lua.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/38ba4d88d584d6c3d65f5f0b990986f3b920c7b2
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCAAGBQJZKCypAAoJEH0Oec13Yh7NsXMH/iM95mVrHyDcRq3H+S0YayB0
 xt1SDFNGlvAUG+qzfGbF1+goPvWtB9nQ/zXsGIAql8kD3/wnvDY6gJ6Tp/SY65zs
 i6V5x5u5/7VCDVf/eIFYb4/rFx72IkxsCuXQWC5T/CzCyFv0Q5TOY2Mr52thxpvx
 VPn23wLgw9qyCdGtXShvlLB1FsO+ETFmC/B9modfe+3RIucH5Q9Dzp4jAU58Dono
 hl+2lAwCNKtxXFK6wTOR/840BLzZyW1XD6PEaD3kAtn8xTtpQELtgenwpQtKKITE
 tPvZsnHmeJrpeUSmx7YJ2ekskQyLqE2AgBfcmARBYBKGACRd/7qWzcioXFD3FIs=
 =JjmC
 -----END PGP SIGNATURE-----

check return code of read()

CID #1400021

Alan T. DeKok at 2017-05-26T13:24:57Z
Files modified:
	* src/main/threads.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/00505f3b46ce068b91655cd1c9bfae6115bfc463
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCAAGBQJZKCypAAoJEH0Oec13Yh7NInAIAKPwwO364wGj4GDvHT/yEi0O
 0nHAjn2HDt4CUqYEV5GZ2SDeht83ku05tJwetVRcYPl4+6R3G4d5bfUASfWpMMvz
 fZFEQoYqV332yE/mITnFsmKj4MuOCu5DEaY0NRQ4Z/m6vSBOCUJKbjDSvznvkWpO
 yFdE+3rl/BJa4ky7v2tCMvep7BWG/o+j9X76tSCBIY+4IfiaKbvcVrO7/KYImKQU
 f0+MXwqUO0FMyaOvg0Fy52y4zRBS2UAfrz42wy3OetitQKxsI9alR2/zEsS5Shr3
 9GRM9jbfTNfMKGWcSmTyaThl3dUCiSlSw5zlZRx4DCBvOV1ZNUd4Io2WL3zb7jU=
 =CWi7
 -----END PGP SIGNATURE-----

ignore return code.

CID #1400018

Alan T. DeKok at 2017-05-26T13:24:57Z
Files modified:
	* src/modules/rlm_rest/io.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/286299065883c8dc319479dc5cb00c043d197852
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCAAGBQJZKCypAAoJEH0Oec13Yh7NArsH/RfoPDWEssSP3LZVVWrupzuF
 lYedz1ZuKNRmBuQLZtxIfiI8kkq80YWxePgWEw6NI70HNlie6SgUy7AA/88ws+5b
 c9kj5czg4C//MF+xwxCo1mbyusNLEEcqjAu18TfiIHedRMNQQBzE1Mrzwhf8aGVU
 cEnVd75VDu7I5ahZH61IXReqNqD4yENNKjMgntqlZTHYjAMZYnBWRdmtMEZOxOjj
 Nfu3i60ebaJjHp+LD1ZeG1uoDcOEhVkKAEui4FLPakH57kr6sicOfoGQUQ4/Hnk0
 2kvnmB9bzWxrsJ2EI7VqW27SM9XXYLJCDVg8vFS9iUQyRk9jFKqS3EA4V8dcuGE=
 =Vz0F
 -----END PGP SIGNATURE-----

we ignore the return code

CID #1400017

Alan T. DeKok at 2017-05-26T13:24:57Z
Files modified:
	* src/modules/rlm_lua/lua.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/365e8cf6fc890a6e565e9b617f2a8827985b943d
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCAAGBQJZKCypAAoJEH0Oec13Yh7Ns68H/iOgDvBsInQfqI6FsO3qAhP8
 kFIzpFO3u740HWiVQU10lpUSzbtpSmWwXoJwHghQ1T5MD/T2hpbWITHHJu2vL1Pw
 ZPD0R/1l9mP/QjyoEGls7Qbx9Sg7xuXgPLpANQX/2e9BC64r+1RKkxxUHxkuMaOD
 uDegMOaiBeMZuQUIWbI5uavy/hu1L4gFNSk7K1iACqiMrHSCIL4RGYg4XaAmAqli
 5Su944cTf1LyBPhmOlP3kR5Dlu/VXLsW4iTWgzI+gv1be4Y4SpYwqe6IkLyEmvo1
 BJ5YD0McglK9Oavpuq0gmdRW2kx5Xt2c8gsv/wCgFfQOJs1oNl/xfhj32WAnes0=
 =c18R
 -----END PGP SIGNATURE-----

call request_data_get() to remove arguments to trigger function.

CID #1358901

Alan T. DeKok at 2017-05-26T13:24:57Z
Files modified:
	* src/main/trigger.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/68af0993e4a82bec6d082db4940b93e1bfbdec6c
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCAAGBQJZKCypAAoJEH0Oec13Yh7NumQIAImTIVZZnx1Mn5OZJBJE5p6s
 7vEAYFbM8lrLG+5GtSp0IK8auBWDfXr1IppfD9vyx4tQL6em3RLOJvFKkXBxywoZ
 CTwma6kuNFVYajLXgjVycPC+vDB3E11BZEZcs9s59OKNhMqifxeffz05tBk2IagG
 gPGfy3nj5rLxqsYUKNHE/wBXjYblIAc0r+KthPuDWsDgC2DRhLKxyNiu9xi25OsO
 Y/v1FZzQpA12vGzrBNijc5agSTgnVE52WZlMuXjlEwDGk4DzupqTObOTSEMVt0oC
 Y+r+FGrA/ZYWppKw7LBxs9955GqNVv1wcCuVJSz2ahPMZ2pGtdfTxVttfpQdA38=
 =PxOh
 -----END PGP SIGNATURE-----

We now have better checks for bad SSL linking.

CID #1358897

Alan T. DeKok at 2017-05-26T13:24:57Z
Files modified:
	* src/main/tls/session.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/641f341398c2d9bee03f1fa7b0a2455018fe2473
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCAAGBQJZKCypAAoJEH0Oec13Yh7NnXIH/217l72To2DpmmJfagskpmuY
 zaRzNvw30kQC3kIm233S9kdwx9jgc6mxYRsF/znImGTFkdd4vmx8AqwAoxCzn2b4
 4vzxhWADJ7vBe9LITpnoz+L4lXzlb/9+Levbp8cq19OGSam/2plheZPDaD7vjSeB
 TL7+uYiBXcFAdxjKoOih0QdjX/rSgd4MWYQypfJ0SG1qixES8BRA53fbuyLHqPuf
 68BkCSc5zdhnGCxgXHzjLW31/29gveMGbxcqvjwE9XO4nX8px3f+87b5Pa4MI6ft
 9OYUwnq2DFeHScIB4plfYNQm7eyqP3UGV4WZ6EHgisj14VChBvjR+fJjCBiAuKg=
 =OA71
 -----END PGP SIGNATURE-----

suppress output if there's no log.output

CID #1358896

Alan T. DeKok at 2017-05-26T13:24:57Z
Files modified:
	* src/main/log.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/36528da99362670eadc7258188e7142310633d1d
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCAAGBQJZKCypAAoJEH0Oec13Yh7NGUcH/3zc8kWyubg2DvCrUU/WkkeR
 L0QZKozfZR/DZDvZadSFnlcvlH0O/+aHsb7rBEQOakGThrSVzZKav4EmNPxxJeVS
 8yriq4MoaYHueVawap8nQchOncl6SK1Ed4fu9ladMuARDmneUoUnZYBbCV2QmW+o
 60TtjvhJ/RqQ2B3Ei3fBfugEGgGeK7AA/p1lqK08PfKXnmd4qk6E5eX2GmsFiQET
 NvZRxJtQPWZvyHtfvSx3HQL/ba7vLMrHr5gXpo/9LH2PUapAQnTszKu9/x2lgazy
 WtKmRfPp55EVVtwRnWBn6LtAAf1KKPtWWWxJyux+cN5S7chjlo49qnzyo1wyrDo=
 =UeKd
 -----END PGP SIGNATURE-----

check username, too.

CID #1358893

Alan T. DeKok at 2017-05-26T13:24:57Z
Files modified:
	* src/main/auth.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/960cfd9b7f37e93364018a5885881c25758a576d
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCAAGBQJZKCypAAoJEH0Oec13Yh7NEioH/2Qoge1SjbU6lUQyRYieK0vS
 CXguPxm7JYdSnnZ6JneA+H6rxB6648qT3cogLUSq7VG+l+OHZWwbvdQeIR09eDDJ
 NFQSx1sg3q/WwBjtZLOVcMqOzj4R1LpF6lSpNfQhy+ewltmNamvpZ68nD+iq9jZJ
 381w7E7MGY0xO6LqJio0IRm56aGDDXCo+KuRcgjkWNN8BWND088Gfc4HhDACkMRi
 GKeb7doTRa9zQERK80hU1mPF3+RrcJggggp8W4o0J23c5NAdAgKKetLej3z3kUFD
 Hl1rfvbSW1G+VWFhAbib/JI1NtACz8L9Ooy26kptAPjY/PBdfiZiNYDWZjVi4qw=
 =q4Eh
 -----END PGP SIGNATURE-----

remove unnecessary check.

CID #1358883

Alan T. DeKok at 2017-05-26T13:24:57Z
Files modified:
	* src/lib/util/pair.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/732538cd249fec2e264bdcf4ee3e7f92e194aff9
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCAAGBQJZKCypAAoJEH0Oec13Yh7NqdwH/RHAwI0dwC1iPie9kDLprlXO
 f7Cr86MaSleHVs2IYcN168PVw1Yi1GWgo/Obqiv4S5r2419y7NRVQ7NnFjTfUi1H
 sUc9sRBQa7u1WRh7z/AbL0T5+Fv2kEMcOYoAP9b5ren7XM8MQySSiMSQynPMcpPK
 OwN0K0rMslUvlFwhomU6fDQQQBmIO1nO5+XQ/F+juEjLkC6Xppp7Q5wFiJnWCKqX
 VdygrA6MRwpT5Ahe5ZvxIRG6j5AdOt+a6BZCKgbAuszbId2W2ePn9/mwVJwi2mGC
 PeF/FUSF29WR5JQ+Y2HeuQiU53kCcZmTZa3mufBnc7X0ZuMaLp73v1Fk2ONi4es=
 =vI+e
 -----END PGP SIGNATURE-----

eap_tls_data was already checked.

CID #1339404

Alan T. DeKok at 2017-05-26T13:24:57Z
Files modified:
	* src/modules/rlm_eap/lib/base/eap_tls.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/4c5a330d3397839cd17f4e4e72caa1a186671802
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org
 
 iQIcBAABCgAGBQJZKCspAAoJEP+k1YKfttfKU6gP/2i6MzkspCpKao2SsdaXC0i/
 4llpySfrk508+XU4oMdmfiz81mdGFkUY0BBm4VKC4LiBxq0rxIt7EXlyRZxGrW75
 dnUgQsnGuWYw3Y0yQh6pNP/lw8jqTaM/tEdC6q8mJMJgSo0/Cuug+GequFK2nWE/
 DKM7uDqrNTM6ZXblMMj1PRzhiyVeQxpdlHuSc8YWJzB07mt8F28atdHcv6T3EQLh
 vrQTRwC72+mwks8ctqm49ozng0pIs9BNM8AgizTIJf5mwAjVMHbv524ZkqHPAnbf
 TpWn2705RwajA94nG014E0x63WwsuAF76yL8hRimpmKAtMvLYtdtj92QCHaQ98eV
 ChRkC6ES3FEpc8oLcxA1lXjOVqm71yijMqqSVj16M6rHWPnPvDt3Xa2tDobE1X/R
 xQvKgdbnhlYqbGdcvrs3pmlLa1T7sryeinNwtYEm0kY4pHZ8b6JENkR2gEN3zk30
 TCSPuoVYlMZKpM4TPN2VHnKLhn4VPCQVmL1ItI0wA0yNMf0y08sB9A5OLy9we9jd
 //K5iuBSlPudH4v4gRMs6PdGSs0Fi1QHpC1p91JI+UDyacP8t2gApuUUHYdx1Jnc
 yR0lTswrB35ueni+DqtvL7dNws60+K8/moqnhfcw0gKNGyFIWrKD/3LeB6+6Bsi6
 2MQPziLhbXGbEDNP9XF1
 =BuY7
 -----END PGP SIGNATURE-----

Lie about **

Arran Cudbard-Bell at 2017-05-26T13:18:33Z
Files modified:
	* src/lib/util/dict.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/3460598d1439284c0d58147707e91a8488135ad9
====== 
Cast to quiet static analysis

Arran Cudbard-Bell at 2017-05-26T12:01:53Z
Files modified:
	* src/lib/util/dict.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/8b150aaa7b7f8a668c73661f29d6c347bc8cda63
====== 
CID 1409876: False positive

Arran Cudbard-Bell at 2017-05-26T02:07:52Z
Files modified:
	* src/lib/util/dict.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/7659ca756442031d937bf3d61814b6142b77faa5
====== 
CID 1409875: Check data first before deref

Arran Cudbard-Bell at 2017-05-26T02:07:52Z
Files modified:
	* src/lib/util/value.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/58aa63d3a857766c3247e57c0f27480370bf1db8
====== 
CID 1409874: Always call va_end

Arran Cudbard-Bell at 2017-05-26T02:07:52Z
Files modified:
	* src/main/log.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/430cd245ea0a9ed70f48c1cc97f1415049399b8a
====== 
CID 1409873: Don’t close the FD twice

Arran Cudbard-Bell at 2017-05-26T02:07:52Z
Files modified:
	* src/main/conf_file.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/8c16f60c1ecc51ebae549b41fe6d1a90fc4def4c
====== 
CID 1409872: Always call va_end

Arran Cudbard-Bell at 2017-05-26T02:07:52Z
Files modified:
	* src/lib/util/log.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/dda66f3c8dac30f905bb2915f18b4f5f9ecb60d5
====== 
CID 1409871: Check request_setup was successful

Arran Cudbard-Bell at 2017-05-26T02:07:52Z
Files modified:
	* src/modules/proto_ldap_sync/proto_ldap_sync.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/2c5f31ba9bc82d039c783a125aaa97cc62ccb0e9
====== 
CID 1409869: Check fr_pair_alloc

Arran Cudbard-Bell at 2017-05-26T02:07:51Z
Files modified:
	* src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/1fd0dd344b0db28a7d635ff04b2b351d061a51d0
====== 
CID 1409868: Check return of cf_data_find

Arran Cudbard-Bell at 2017-05-26T02:07:51Z
Files modified:
	* src/modules/proto_radius/proto_radius.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/5f158df41e47f1bb14f2b541d17518cac70dbb5e
====== 
CID 1409867: Missed break

Arran Cudbard-Bell at 2017-05-26T01:52:07Z
Files modified:
	* src/lib/util/value.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/7dc3144e8ba879ea6fc8b8c919ae61edc7f93f29
====== 
 CID 1409866: Missed break

Arran Cudbard-Bell at 2017-05-26T01:48:43Z
Files modified:
	* src/protocols/radius/decode.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/cc3e7b11f31f8d4fa210a1b639bd6a37d94b2bd5
====== 
CID 1409865: Remove dead code

Arran Cudbard-Bell at 2017-05-26T01:47:36Z
Files modified:
	* src/lib/util/value.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/0627c6574ba05c40a14544618ec40668e7e9575a
====== 
CID 1409864: Use the bool to check for multi

Arran Cudbard-Bell at 2017-05-26T01:44:45Z
Files modified:
	* src/main/conf_file.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/0e2b79fac212ffec5f852c165942a2bcd350e5a1
====== 
CID 1409863:  our_err is no longer used

Arran Cudbard-Bell at 2017-05-26T01:40:08Z
Files modified:
	* src/lib/ldap/libfreeradius-ldap.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/834ff04d599ed7191dc951b2d7c1ae8ee0e4db81
====== 
CID 1409862: Missed check for NULL original packet

Arran Cudbard-Bell at 2017-05-26T01:35:50Z
Files modified:
	* src/protocols/radius/base.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/5d18c6c49ff6fc845a26e36213b582dcb2d65565
====== 
CID 140986: Check return code of cf_pair_parse

Arran Cudbard-Bell at 2017-05-26T01:24:23Z
Files modified:
	* src/modules/proto_bfd/proto_bfd.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/5047f8fe252ae3267491807cfa2da2afe3267d02
====== 
CID 1409860: Can’t use bounds checks on 64 bit integers

Arran Cudbard-Bell at 2017-05-26T01:21:17Z
Files modified:
	* src/lib/util/value.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a047289442d7e47bec66de533aa3ddb4160f6537
====== 
CID 1409859: Check error code of fr_radius_packet_send

Arran Cudbard-Bell at 2017-05-26T01:18:22Z
Files modified:
	* src/modules/rlm_radius_client/rlm_radius_client.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/67bd7e066b59c5687e3b7ef295d2a4fad59a7ce3
====== 
CID 1409858: Fix typo

Arran Cudbard-Bell at 2017-05-26T01:14:09Z
Files modified:
	* src/modules/proto_dhcp/dhcp.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/e32a84b7bb2ca91147f1ba071d95becda2ddb9b9
====== 
More formatting

Arran Cudbard-Bell at 2017-05-26T01:06:45Z
Files modified:
	* src/main/unlang_interpret.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/502899767f85338efc8550f0e1ad91b91c39c262
====== 
Dynamically allocate modcall stack state

Arran Cudbard-Bell at 2017-05-26T01:06:45Z
Files modified:
	* src/include/interpreter.h
	* src/main/request.c
	* src/main/unlang_interpret.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/ae676652070abbd22729077879ed09398d82dfec
====== 
Formatting ’n inlining

Arran Cudbard-Bell at 2017-05-26T01:06:45Z
Files modified:
	* src/main/unlang_interpret.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/98b628e8c8f085090476effd5bb4c617f04fb1cc
====== 
-- 
This commit summary was generated @2017-05-27T00:00:03Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed).


More information about the Freeradius-Devel mailing list