Commit report for v4.0.x branch
announce at freeradius.org
announce at freeradius.org
Wed Nov 1 01:00:02 CET 2017
New activity for FreeRADIUS (the high performance and highly configurable RADIUS server)
======
gpgsig -----BEGIN PGP SIGNATURE-----
iQEcBAABCAAGBQJZ+OIrAAoJEH0Oec13Yh7NV2AH/28nj9GPM2cCuEeQgsC5UQH/
omlho7PHwyBHnvJ4fna3pLJGM9xDrZVkYTSqglFb3Xm2N2/1JDqkY4e7qTtbNWfi
Zc686jSncEaY/EV61BKpQhVjA4jhjTse9dUGypEbolv26kPJqAU7iwSBv+cHzwNw
3alrt/ld9KVohBBI7vbRaAMnAx4Y+KzJBV9FhH1S5GjUbswrkaevDG4feMRoBzH4
ZtAs8842Jb3x/Yy1fTv5Ty6Hy8yFqEMy1gCkAkQWlzWbP7icovenQmVxViAv5lqY
v2B9s9S/Drv8WpK1+0GLlzmOmwxu40kDy11d1P13/ptiEGeY5meWOsruqbbE+yE=
=js8O
-----END PGP SIGNATURE-----
remove unused assignment
Alan T. DeKok at 2017-10-31T20:50:43Z
Files modified:
* src/lib/io/schedule.c
Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/5db6c1a74d89e4cce8fbca290e58bca9ce88037a
======
gpgsig -----BEGIN PGP SIGNATURE-----
iQEcBAABCAAGBQJZ+No/AAoJEH0Oec13Yh7NENIIAIcYzuoJkWrOtU+4/CdtIzs5
xCsD7Fpw8rSuVk40fdglc1/CwBRpTUbfNuzV2UnJfHZ0T8YOMtmeg0nWA6WHfMVF
Loz1pXES07f26stoaA9mZt56MuvwwyMpGWe/EpmqyDRRsYqlCn/19gsbK3wZFmHM
jE/qcrr3d4GTPtDHpPnv0J9fUCn0doo+q1pmXWXbuNsDEfgtHSwnOsaRPLG/Baq9
UXdELQImnkCAhNkJty8WR9sSscUb3UBMXmSDJRWo5VUC+3BrxdXMnxG/v29fGakg
9aPQZcmao/nObWntUXemD6uhsja45mo+wFH3kWnU/P801lPPlC1kpGwFMrN+iOQ=
=FfLC
-----END PGP SIGNATURE-----
more preparations for eventual cleanup
Alan T. DeKok at 2017-10-31T20:16:57Z
Files modified:
* src/lib/io/schedule.c
Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/4aaa7c8f1b2eb6b0b9dc090e8644b36ad6ea9015
======
gpgsig -----BEGIN PGP SIGNATURE-----
iQEcBAABCAAGBQJZ+Nm9AAoJEH0Oec13Yh7NjNIH/jOY+Zy9P5RrCBdi1ab234xi
CTaovdCTIFkN+EVQkBoFxEjwy457P8tYDcRaVYsxXyDyzIoRrDADB7UEaJ9ewNZi
bzJoQH7lqO686bQP1PMd3ohR2kto+k22CKAXM3Q8JAsoZtB/YDZXMrlyyEVrqUhD
dnJbhfORZoZfRSpOsB0ZF7A5Db4oWibMPXCNoprv1zuY3h0aBCtnkLMfx+I4r/47
vt9+ThJFB/DQ+smDBdRtKxZX9CRlGCkBIBXt8XvqeVeBIk7Zm+Zb8REeGpP6EpJ6
PzviDn2AIpLX3C0PKWrOkBnF9eUOpnhqDcVlDL8wm5MXo9iLJaMGWSaz5qJ+u0k=
=ATAW
-----END PGP SIGNATURE-----
destroy worker where we created it
note that we would LIKE to free the event list here, too.
But... the event list is cached in many modules, and therefore
cannot be freed until all of the modules have been freed,
and all of the threads have exited.
Alan T. DeKok at 2017-10-31T20:14:06Z
Files modified:
* src/lib/io/schedule.c
Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/c42db4ce6434ed79b2ca8c5ab290d9ab688f6c32
======
gpgsig -----BEGIN PGP SIGNATURE-----
iQEcBAABCAAGBQJZ+NeTAAoJEH0Oec13Yh7NGf8IAKiQVmmdkdehBADWZVcqnyFu
qK0opD04/4GCdOzvo18bVh6CauBDbIhZG0WeNpzcSPObmU5y5P1dshSnIdPCvAHV
w3CtUlWEV4HlBn/K7UV438Eh/rghPkJmQ/M9WUFDVil0Bq30u4dV5nBPEeR2Q6AO
ibJ2VJnXaTQR4Vw/FQmun2pOpsgP/8OcFn3sgzcNab1LYE+JMPmHH55p71nlYzW5
KoqrZIiCd8dZhi4DbeIff5z2CiQP9JTnfTSFHU+ADer3CJnlJHwbUHLppBp66G+J
pgVw3XmIBKoX2Dl1Pt06hMePzm/L02HSkFyHNGj8lkY039J0c0G0ukSyQ2ZG3Xo=
=kEiU
-----END PGP SIGNATURE-----
timer events are parented from the event list
so delete them manually, before calling talloc_free_children(),
otherwise we will try to access children that no longer exist...
Alan T. DeKok at 2017-10-31T20:05:02Z
Files modified:
* src/lib/util/event.c
Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/1d6dc9d2b09f554fa937288f117ffa4ae5f0eb06
======
gpgsig -----BEGIN PGP SIGNATURE-----
iQEcBAABCAAGBQJZ+NZvAAoJEH0Oec13Yh7NE00H/R5svwqYCgC09KRjMVWPHdUC
zfGcztDMbFb21V4jITNNfDOioml0LQ+mp0xTdqqcnZFIk36lO2TkHgC1+RvOTeYX
WqMbKjPytFZaBeE5ZzyOT9y3lLbPQoY7g3Xm5JYKFiTEtAYkVcwDEto8qf17oIxN
3xWbaXsSeQN8gxctf6eoiDNCOg8YQxYITf9s+hzPdH5HakG/d7wfM18fWI0vhFuX
4NclfZbmkMo0PgPof8eFBz928ha85r2Q74AgX5J8ed3C1WXeWvI9QpfI+jnMnaBB
s1QjVg1f7muiKsByW+5hjb9+p/dNQ1twc5wItEugnWyzR5TvLret7Nm8ZozM2FY=
=R0gW
-----END PGP SIGNATURE-----
notes on thread exiting
Alan T. DeKok at 2017-10-31T20:00:34Z
Files modified:
* src/lib/io/schedule.c
Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/2e922b7378f1e55d9b1d47f74af5f762ed787c13
======
gpgsig -----BEGIN PGP SIGNATURE-----
iQEcBAABCAAGBQJZ+NNFAAoJEH0Oec13Yh7N/r4H/15Y4dB+y6nufZ3U4juQkzpI
nkew5r28Iz2ogOeSIn2LBz1UyCSdR+dayeMvK8cQmw9wLZfCkpphW4v/FPWs27uw
6ZC7otA2+InbLQnu6oiqsvMDXy5BBPge7NeZ34ya6a2MYP7WmiY9+qfhRLj4F2Q/
uFe/P43+Qk1ST3Mw1O9ie5anaFjet/CvCJNem2btme/mEXhLc6La74N7YJI8zWgw
aoc8JAFHD8lMFQDtQZ9hdNvrsB3+wnWV6bqTrBnuxcxC0DLY6Bcj7zLrB88QPcYK
9mQDO/DXuDIUjid5k1wD0qElPOE8VBgHk7q5VcASn6G3SFicCPdC+DocHsAQDzk=
=hjVW
-----END PGP SIGNATURE-----
simplify use of circular list
Alan T. DeKok at 2017-10-31T19:47:10Z
Files modified:
* src/lib/io/schedule.c
Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/1d6b7739d5c459cc648f2ce35f4fb24034eb292a
======
gpgsig -----BEGIN PGP SIGNATURE-----
iQEcBAABCAAGBQJZ+NEtAAoJEH0Oec13Yh7NneQIAI1KFtlIFcursSFQcDkDg96d
SdfQtCa0fnhKxaoxs3T6r86QvUxcJbYbiXZjZnlfGrvCxv5CHvNHgUvmceZ0XbuP
2rOLTfjs25HQiQ8DTSoSYV4nHTYOQE1COw0xInBkcqwX+RcVHJxUJ80NB9B6ZR4U
Sd166YraoFxqPswRSOyLxyCDsBf73EDFpwS0ax+XsMAxe8XFL5adnte8W+3d2Y0h
sGzJgcgluOR85T64xuB8j4kWH1j275pSPAziJ0PEGrjU5uOUEdW396LX6mq7EpbV
cRp/++DEXwtcnYPdAXUZ/D4GP5ywWSIvXlN0YTEUq70bDBENqacN5MvKoTJpLfo=
=4fUs
-----END PGP SIGNATURE-----
Fix coverity issues CID #1420467, 1420478, 1420469
Alan T. DeKok at 2017-10-31T19:37:53Z
Files modified:
* src/modules/rlm_stats/rlm_stats.c
Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/1d245a246029a1c0157b641dc05c7ee95b47de0d
======
gpgsig -----BEGIN PGP SIGNATURE-----
iQEcBAABCAAGBQJZ+NCdAAoJEH0Oec13Yh7NJdoH/0uIgWfBy7UWmcyfnZE7S8ud
uSZClkCUFGfaF+LCG70KEebGa3o1zuQ9G9SnXkSc19J9XMtLmr5cRV6vpg7BfUdh
uPUdLsChbFWxFPTd09tXBetVmxSSnhQXeh+/9nFXFSzgiUwLMwkP/F8vbKAcKnmh
7b5QAGJif8IqW2HmkQ5pFhnCiTPjUkkjWWvWmCWZHVtyBSdZSqcT3/QSYiAud48Y
Nc74QrJWcTXvffRq436sJxrljn0W69bHwWbzzEd0grJ2zACYAgVdO96NKTpBTbXb
2XuIoKSJf655slgTWpIE7x8nKRpb+Ox1TGxOB3I277vfdtx75rhcb2m2bpdIBdo=
=pzBI
-----END PGP SIGNATURE-----
add assertion
Alan T. DeKok at 2017-10-31T19:35:54Z
Files modified:
* src/lib/io/track.c
Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/43b18e8116670b6f65a1770895d6ba43956cca83
======
gpgsig -----BEGIN PGP SIGNATURE-----
iQEcBAABCAAGBQJZ+MYCAAoJEH0Oec13Yh7N+6YIAJCHzJnO1BfkW+2uRu8LbPyH
965TRXJmzs8bE69YOSpJTw2fo4qQtw2LovM54K4UzNMliT7EzEhF+hENS4JprZtO
kdwp09wQydEgiggqN5poT5vG5civWTWkJrv101X0u0koiXrVXoNNMthJY9IbfLlx
shLCP4wDBakkVY4DjjqmYVmAAeP+KPh0y+5Fm7aghrLdc3wQL/tKO2JRwq/rWVm+
NFG35S0b5dn9z67QeC9Zc4BJT9P8szZrMpf/923KBjm2xmkhlKtui8uLv2NGMoF5
Stl477Bmj4AE7MfYiU/Ijv/ViYS1KJyIlIHp1tciNFEzOZFzvnOujO+qsp1MEdA=
=XoNV
-----END PGP SIGNATURE-----
set entry->reply = NULL as necessary
Alan T. DeKok at 2017-10-31T18:50:33Z
Files modified:
* src/lib/io/track.c
Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/c815ea2e2b5147daebffbe034c814edca3cc4d4b
======
gpgsig -----BEGIN PGP SIGNATURE-----
iQEcBAABCAAGBQJZ+LSBAAoJEH0Oec13Yh7NLjsH/3e1llZfVnM1ViUUOGqVAT8d
I5S+198W8ITqReikQm3c7AGuGZ3aT33CqoC6HmbPwShnF10yoCt9v/RdzpIxy/yG
ITmZ1sNZj54pYgqq6495sxiw3UpkcG3qIffJ3/pbql0SVY/yuz0c6OntP2vw6l3N
7wVeXfWWuP2VBI3RK2a0bquv+4MYSD8SBfBMZsm+P2bvDYUoQMSz5hJ67jMtrC8S
tloflWl8JCIb5qdr7R9HQuwJsNU86rGcAMpGgPPopgUvQ0an6Z2cQaQdpxD7Qvow
XRptnbwFLSBAeCr3B/pLLpU85LN42jOylU0ehY8gQBbEhh/qLIWsRhkqHplRaLc=
=lsSx
-----END PGP SIGNATURE-----
move polling message to debug3
it will still wake up and print "ready to receive requests",
but one less debug message is useful
Alan T. DeKok at 2017-10-31T17:35:32Z
Files modified:
* src/modules/proto_detail/proto_detail_file.c
Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/cf824741156af08f3dec16468fed80a2a99f5a3f
======
gpgsig -----BEGIN PGP SIGNATURE-----
iQEcBAABCAAGBQJZ+LRNAAoJEH0Oec13Yh7NAFIIAIhMJz1wVgloMNFRHapcOaVs
hR+D1dhqDoj7RhOvmBprpO9WYvxmPZsRch4YgrTYx7h25SrMb9h+5hwNBQZRAZrF
7GiFBaBsnNxcdBrKVdn/477uNc1RozY2gXZHjskm8phzNS83cA64ZpXr9C+uJ+/4
eMxLethIdASlWk5//QTN5V6+jZQRj2XBWP6dILVbMpcWkmXHTVmZ7nxWvgabTP/E
DXxQXIjX+l/aP8EOKwfPhEL2rSupNAy1Q/+WBIGFt1xPqxXsbWPKp0UNYlk4HrCz
7aevt/uxJZeRX22JhCzimzgdIabg2w05rM8W8jcqaKV1HMEYh/T/S7SsGZg0GZw=
=miV2
-----END PGP SIGNATURE-----
do more memory cleanup on exit
Alan T. DeKok at 2017-10-31T17:35:08Z
Files modified:
* src/lib/io/schedule.c
Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/396db45023942cf5717dcad00367eca4b1d26609
======
gpgsig -----BEGIN PGP SIGNATURE-----
iQEcBAABCAAGBQJZ+LMyAAoJEH0Oec13Yh7N+QMH/2jkeNk/5XzJFL7oXLfbDvnH
Bzkxt86sb95T3tAeZ5aiCNGB7S9VTQopnV24FQrrFV2k6T+DNjbjrLNNxUQXdN2R
tSBN4Nv5XW2DdRguFMGi6Gxqwp/g93QBy/IbyeIqvJVSjj8Oe8lgy+md8uXc+dr8
9f3cOmJU+ypeHukmC2Wtr/k39znGXv6BAls8oFxV8QwAUCTsKZ6weo0WqHI0nydd
rfDIQfW8gdd9q0LbfmrQOaSsDKPJDvxHZMr2t8UATOQeAzwse4cGJqgFp4t33msp
/bmZpZvxUbk7gITZAtk/vIDAGR22tvwy4I7Ehfr/IKPTRkav/IJ4YVxLrwcsQTY=
=sFFE
-----END PGP SIGNATURE-----
free children before the queues they use
Alan T. DeKok at 2017-10-31T17:30:19Z
Files modified:
* src/modules/rlm_radius/rlm_radius_udp.c
Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/0b0d5610416815fabdbaf91ffd3ad291f6ab6318
======
gpgsig -----BEGIN PGP SIGNATURE-----
iQEcBAABCAAGBQJZ+J/5AAoJEH0Oec13Yh7NGrgH/iTbOW2pzLRcGMhmfmJPON1l
AKfB5CloQ1Ur68C4e6G6hgMRpdLW0dfoLle09c16VG9SeZJHHgQRZX43G3D9STOJ
TV8ar3cpAN/hDMXbpRDmgNFXVLNljjFWbyMgSNI2umyAVcRTj92PRYgVO2m+/79q
VM2awQ+N6HDc5StPTKJ0qFTq8Mng0lOtIm9ZLl+eYgUD0YRFJ3PeR2LD8h82kgc8
aEEqgfLuW/8Nhr0BqIwmqDoB0dGsYAK6rAZ3xHgJRB6d2dW7gV75jy+eaj/bp9Q2
KFJw73QegV84T02VWEZzhPROEYli3ELv3re57FTNOPmBOGivgDiQbQGTaG3bhwU=
=9Pvm
-----END PGP SIGNATURE-----
move debug message to higher level
Alan T. DeKok at 2017-10-31T16:08:16Z
Files modified:
* src/lib/io/network.c
Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/9abc1cbdd0710505cb7ccb6423781e686cabb430
======
gpgsig -----BEGIN PGP SIGNATURE-----
iQEcBAABCAAGBQJZ+JrpAAoJEH0Oec13Yh7NYugH/0FWC1eAVMl59W9FnbRLO9Xg
1NEsjmQ/Z1bO6sJNuWHnJSUNJFBVroU6S1HxTlgyFrL4if4gKwwfFpkqP0dYfvi8
L2QOVADM1lvjOb560I1LOUIwf446u9pYvTR5Lc8pGCUA3QxTND6sVrPixPb6bazF
XXr3JURD6UpX85Nlss9i9B4wltHZALGYjGhsf+qsifOiysXJoZzE+Olh7jfj8iSE
qTRJkJlYvvmprMmbfxP3AlXf62B0Zcjsa1vvV/1kQc3Iay4QfwROBccZ5KFsUMme
zLWBRatV4PElupEjTiRqoF0o1+00ZV5rVscDm3HGFVNjjxIWf49/GfOcE6yn+qE=
=VmDP
-----END PGP SIGNATURE-----
note todo
Alan T. DeKok at 2017-10-31T15:46:44Z
Files modified:
* src/modules/rlm_stats/rlm_stats.c
Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/e4db4a5bce3113b944953825c607ca85a99953ca
======
gpgsig -----BEGIN PGP SIGNATURE-----
iQEcBAABCAAGBQJZ+I3WAAoJEH0Oec13Yh7N4Y4H+gIaJ7hxnC73JKrFtkXJCuPg
omDfc/YEc18UUh2hjw8QV5hS4TnVDlOkGYV5GHeLOQF1iuXX0nWxavxYv9+svQMh
sDl4JhARpYXCZjematuZhUYcJpMYf74J/0vDX2gfCChg/cw1V0TDmU9Se9yB/Xnf
KZwRDZqBNz9/q9tvuKQ2XmBFk39CZI0bIYpug4GSXitRAcFDg54s5I75qTkHcdkU
m9Aa87B2+aHQ//ciOi/iYw/ZGvkhIfDrXblqu+Xa6O8rjYnWE75JimTLu/qgA171
YwDBCcnYTtTgOOVe6bHcZcfBYgpnwK8eMyG2ag0kEeu+FaNigXvKiObiAgDst7c=
=WFap
-----END PGP SIGNATURE-----
coalesce stats across multiple threads
Alan T. DeKok at 2017-10-31T14:51:00Z
Files modified:
* src/modules/rlm_stats/rlm_stats.c
Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/b692dd7d12aa816f4362b0650870004ac006e607
======
gpgsig -----BEGIN PGP SIGNATURE-----
iQEcBAABCAAGBQJZ+IzVAAoJEH0Oec13Yh7NJBkH/2A2eTEPuNqNLhz5Pk2VXq/R
sJPis7jUtuhLx3LW8Xi2ZJQAV9eo/K2yBl9gI2UIhYdmvAd+4G3JTzNNkDBJSD0o
uGthUtl42KK/YZESwnbjjqYD27Y4C3Ff0LtG25hXEOYV1f3SJiqydreupKQH+C0Q
dhoXNX4CNFfdTk+fmdLi/YSn3pKaJF5koLKTMFtUZjt91obPjLhBiszn1zohEUWb
Fc2DQLFhNg7G/D3fBKtnozdOhSnwr7LQAk45Z3IO+GqqCXk+m+I8mZkm7BkSjWba
KwiZexBcfQX/5Hf78/orWc6CGkLhcDnIcrfjOEmNItKBZQNm91ZH/ujwMSwqKkU=
=5c99
-----END PGP SIGNATURE-----
clean up schedule exit code
because of back & forth signaling issues, we have to be careful
how we clean up memory.
First, the network is signaled to exit. When it does, the
scheduler thread sends a semaphore saying so. That signals the
master thread to call fr_network_destroy(), which in turn signals
the worker threads that it's exiting.
BUT fr_network_destory() doesn't free underlying memory. Instead,
we have to wait for all of the workers to finish.
The workers are signaled to finish, and again don't call
fr_worker_destroy(). Instead, they don't ACK the channel close,
but do signal the semaphore again.
When all of the workers are done, it's safe to free the network
memory. And then it's also safe to free the worker memory.
... and then disable most of it, because apparently even
signaling the workers to exit causes problems.
Alan T. DeKok at 2017-10-31T14:46:20Z
Files modified:
* src/lib/io/network.c
* src/lib/io/schedule.c
* src/lib/io/worker.c
Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/cb93ff76ed7b0acdbda72dd1a68d44baf14d935f
======
--
This commit summary was generated @2017-11-01T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed).
More information about the Freeradius-Devel
mailing list