v4.0.x - DHCP - incomplete decoding of IPv4 attribute

Alan DeKok aland at deployingradius.com
Thu Feb 22 14:52:41 CET 2018

On Feb 21, 2018, at 7:01 PM, Chaigneau, Nicolas <nicolas.chaigneau at capgemini.com> wrote:
> Although an ethernet address is indeed on 6 bytes, the DHCP field "chaddr" is padded to 16 characters with zeroes.
> I've fixed this by restoring these lines here:
> https://github.com/FreeRADIUS/freeradius-server/blob/05e6c40d9319e6fec179101139e718be99635176/src/protocols/dhcpv4/packet.c#L161
>                case FR_TYPE_ETHERNET:
>                        memcpy(vp->vp_ether, p, sizeof(vp->vp_ether));
>                        break;

  I've pushed a fix, thanks.

  Alan DeKok.

More information about the Freeradius-Devel mailing list