[v4.0.x] fr_pair_list_afrom_file is broken (dhcpclient, radclient)

[Alan DeKok]

On Jun 5, 2018, at 9:33 AM, Chaigneau, Nicolas <nicolas.chaigneau at capgemini.com> wrote:
> v4.0.x dhcpclient is currently broken (most likely radclient is too).
> 
> When reading value pairs from stdin or a file (function fr_pair_list_afrom_file), only the first value pair is returned.
> (It does parse all the vps though, because if I try an invalid attribute name, an error is returned.)
> 
> It worked not long ago (May 22nd).

  Yes.  Arran has been refactoring some code, and things have been broken.

> Maybe this change is the culprit?
> 
> https://github.com/FreeRADIUS/freeradius-server/commit/22ffa0f79ce480ec681e1f5dd26f376065e434b2#diff-30e44bc9d0f40a6b36e5e2b634ed549c

  That was a fix for some of the other breakages.

  The real fix is to call fr_radius_init() in radclient.  I've pushed a fix which works for me.

  Alan DeKok.