Commit report for master branch

announce at freeradius.org announce at freeradius.org
Thu Oct 11 02:00:02 CEST 2018


New activity for FreeRADIUS (the high performance and highly configurable RADIUS server)

======
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlu+VzMACgkQfQ55zXdi
 Hs0ztgf/fbWgbinM2IM6UcjMpsseveikBD8QrKzzui7L/nRTiwO7+KI8NHw/izSb
 tn7tD+dGOGwo6iorMt/k3ILvt70zOb20h+FoCiOnfQzyMBewHeESqkF8/kp24M2X
 SW+RlOfcrubqxJwgJXPlaj56+xlD25DVhFlRCyT8aBvahxGpkcMPMQDnXKOlC9Ug
 thzWCe0haWKY5yagB8bPM0QOpVYdLRXwxyHy9ej1tS9J+49C6ktvghQAWZXJbHAK
 sLyEQ0mWp2tEUKrafDDf+ZYCAOnobuY3PrCWx65MZAiLE96CEYlYsw/o7W26mNGH
 TepNvQm8vmk08L/ggFp5Xhu020NABw==
 =tIGj
 -----END PGP SIGNATURE-----

now that we can decode these structs, create them as structs

Alan T. DeKok at 2018-10-10T19:46:44Z
Files modified:
	* share/dictionary.rfc5580

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/c6b5e55a30eb0845027b04a39f86388800d72483
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlu+VLEACgkQfQ55zXdi
 Hs1uEgf/fIohhk2nW0GNpfuO86MlhS0kiVYLGl9YbE1+v7xugJKjYfHZMOYF31Ya
 MuEKaxJVfaT7C17HEsnedOZtEhT8t20IunXdtCc6qWvfgq3pF4jUxPPzQk8GlvJO
 JtJQSxv1vtr3JmLSws7BKXeKU4oPxeWtwuiUgtEaR/zwg2zVFOjtjZreHljrNELQ
 HkbVJRl/k4k8H3C0KOWzxy0yZHgWnD7UfWoIgpQTyCXYK/XDxop5hwTSPbBFqiJo
 70M+YQcHVHf2Vv/G478VhbiaxKbybGbUcZEs2RIxj5fNCihjth2dBKFe29qEVPSD
 jonTc88VsAIGtL2TfbPYrSDpGU04Mw==
 =pQPz
 -----END PGP SIGNATURE-----

allow variable-length fields as the last one in a struct

Alan T. DeKok at 2018-10-10T19:36:07Z
Files modified:
	* src/lib/util/dict.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/f77d466ffa2f9faefd61a21d860119dff3210033
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlu+VA8ACgkQfQ55zXdi
 Hs0N0QgAmhvdoz3Y0FENzyHm+qe8Fhll1fJVQ+854dZVo2nF/gmDhTKMYzjtCm4G
 KIgzCku+Cdx012iMCOsyqvbkPCxdcWA0u6EIawf8inl5chdJuJTVuTs8ACmZS5Iq
 Vuhlnxm86690Ak1jtcBHrdm4z25tEqPg64wroCpq1Bvm4Qwj18+dskaOVZkisGfj
 gI54Khi+4oMQPe/cwNF2CDJ164Lx3Ojy/Lt/vQLAUz0A8Qlg9H1ZZdQy/F6FOpZX
 FB4Kma0PD89y+zjADkPSh/+2jf81K3sMy2j77T4s17cBqo8YGchFQY/nAJ8GL6zk
 Qq5jdc4gfhFYh3RSe+JS1IFK6i2atA==
 =/3PL
 -----END PGP SIGNATURE-----

encode structs, too

Instead of disallowing structural types and allowing everything
else (i.e. non-value types), we only allow value types, and
disallow everything else

Alan T. DeKok at 2018-10-10T19:32:43Z
Files modified:
	* src/protocols/radius/encode.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/23104cfd69fb353bc9d42ad35017dd3668fd490f
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlu+SBoACgkQfQ55zXdi
 Hs0uAQf/SJeE+QIAHdQvTIUbM4J/VGjwYYQDrH3FBdLy0mHsrt0rIxZQw831NdSf
 OxL6AUj4nsy1XD7WF5PEAekukwL1hOL31UtcimGGJiPIClr5iWGJOixifTPuvCKB
 CwmoVsgg/exoLw80TBhXSaeyT3ZkVgHDwPXIZkcmp8FcjEcg2r65dbiKW+3sT0Et
 IIcak9kw9Vn4iZ5Wxf59F8PsEHVDUjqhmWVga4J2B38V7kpQJFpo5IfmGxF8Clx5
 rzy1gYSN4nZVNXEg/Rf/Yi99rkwDqQtMVO+w4Dv9tNKz/RcUaIJs7ytL5xpJM7mC
 0VfBeBGJV1KOmZMdp37elnOMblTEag==
 =9HtF
 -----END PGP SIGNATURE-----

decode structs where the last entry is variable length

Alan T. DeKok at 2018-10-10T18:42:23Z
Files modified:
	* src/protocols/radius/decode.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/317724c62f1042755ed9774f20e1b85444fad3a3
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlu+Q9wACgkQfQ55zXdi
 Hs0BNwf+LEhwe11IZqffEKzDLtVvIBioCLA9gWxdEPwo9nqCFHjweCJVg3DVGY6l
 6GbtGc4o0oQygPRZtpcum/QSn1x0x1m1lJ4Tnq3oPAkZ1i+aQhxrESN4ASK2Bota
 yfSp2rtZUUgX/0Bs7lJ0deQ7Qc6lwP0atBOHlnf0jy94cQtA4vEeJrE/Yzfuj8Fn
 Twxq9FMA/CTmCmQREGTPpsF0ZcZcoc97hcJ2fXtK7UN4n8gEP8nxo+DeL5Y3iB7U
 K7JhFKwnFNnA67rJ/wipUVpKRZ6s52AnZ7dF7Ku6IY+6nYP+LsLvzk6aQIDiw7ff
 p8VBov3rDBCoilyzqmio/Ae3Bk/wSg==
 =aq4r
 -----END PGP SIGNATURE-----

struct children must be numbered consecutively.

We would prefer to not list numbers, but that's life

Alan T. DeKok at 2018-10-10T18:24:26Z
Files modified:
	* src/lib/util/dict.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/bd45664bf8cf608d59dfbb58197b87d46741f057
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlu+DMcACgkQfQ55zXdi
 Hs1XPAf/Tb5FIE2oGuSAoKh9PzTacl2zzJrS+4Y58qnwrAhDmr+lYZhgnT4X/u1R
 naRHvt/sqkpBsskDpo50Kv6RnLTKhQo8zDL4JOsiQuRo3vkpbFyt6Jk0uAVIpntD
 8Myy15RWo4F1ecyf8ALG4+4cAJmjVH9lkAmey/Y6HunZlxC3KDOpGYihjZD4/4qZ
 +cTDVtOlne0r/4272jLsC7sNT6uMCKaw1eJ2r7T8jpltGBB62IQ8/GchaZugODME
 V+O/hU/UcBuL+wzJILcmJFpoVfR/VzEr6KrVaZVuGaD99ov+CI9RbQsopybK2Fkn
 SUIw+jx1TMswpdBpTV6s7CzIs30GFg==
 =x8B+
 -----END PGP SIGNATURE-----

fix ethernet to integer conversion

we can't really memcpy() an ethernet address to an integer64
attribute, because the address may be in the high bits of the
integer, or in the lowe bits, depending on endian-ness of the
host CPU.

Instead, we manually copy the bytes over, so that we're sure they
end up where we want.  Note that this is the same process used
by fr_value_box_cast_to_ethernet(). i.e. copy to the *low* bytes,
and not to the *high* bytes.

In addition, fix the unit tests to match.  Casting a string type
to ethernet isn't the right thing to do.  With the previous code,
the string type contained an ASCII representation of the ethernet
copied to the high bytes of integer64 and then printed... which
isn't at all anything useful.

The new test case prints ethernet to integer64 type, and then
casts that to ethernet.

If we want to cast from ethernet to string and back, we MUST
just copy the bytes raw / as-is, and *not* convert them to integer

Alan T. DeKok at 2018-10-10T14:23:21Z
Files modified:
	* src/lib/server/xlat_func.c
	* src/tests/keywords/integer

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/d796ab2ddc1c8968ab143839b312f22e9a52e8ef
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlu+ChwACgkQfQ55zXdi
 Hs1ZyQf/Wab46zOBz914zFEZZgGRqa7wnboY8LEIaoCET8vRO5MsyjisX3v+X4QT
 963ypIs8LaU+hDhmG7wUWov0GxPlQsbLIsgXT5+iPxLIDDOpO/Ef2SgKwuFKuluP
 MhinrlSHNoWps6avRw9q/6FLUA5nEE6MDqLqTA3DLwTYd3I2I56BBh+shigL8TqJ
 M+nT06zawbs8mpItyPeNn4MG5yFISJoKYmnz+PKfroeyXHplGoo4s6QkEHvlCICQ
 B0LAILioHS6XnxHOEY6AHYrw+nvvA55GpWvM1bWurQcNfNgnjeDxV+kIoszviKzE
 sywbAMisJaP7tmuUi2tutlpsUMC+8A==
 =tEJt
 -----END PGP SIGNATURE-----

fix to be pedantically correct

the value in vp_ipaddr is in network order, not host order.
While htonl() and ntohl() are similar, using the right names
is better

Alan T. DeKok at 2018-10-10T14:17:17Z
Files modified:
	* src/lib/server/xlat_func.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/f040a1e2bed7f8e3c0e8868e91f26dda994f922f
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlu+CUUACgkQfQ55zXdi
 Hs2O2Qf+Jn0Kla+giHAz6WZhwV/7rUXHGDBfJm7GpVIgkpQgfGEh6JJV6C+J8TSi
 mGpCtQNOJad3VDHr13I9tWZSnHqo0QoHVMfBDWdDNQgXou8UOsq9UtlbZiNbVuqu
 nWojnMlP300NGWyhyY1MaMZI4973U6Rr1+kjh4+0L7AyD9R/hl8mmPyYJYv3N9F6
 cPpgeGuEcCKj1vS6zYhAvCgebF5JtBSdAw3wC3+agMnk3YVtxIzeZ81zE9Y3lQVd
 ciBEPKGRq/8vN0XWLNY9OQkF7hRalKECRUK80pI4h+DTbYzV+rbXm28WoyVdOf65
 nX2fVcWsoiUNsKefMgyjO8nFzCPiUQ==
 =qT2d
 -----END PGP SIGNATURE-----

iuse the correct line number for error messages

unlike v3, v4 interpreter line numbers are for the original policy,
not where they are used

Alan T. DeKok at 2018-10-10T14:13:36Z
Files modified:
	* src/tests/keywords/unit_test_module.conf
	* src/tests/modules/unit_test_module.conf

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/ac78d9ab6c9ac9f4b86715a0a4e2cd942d48ce1d
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlu9+MEACgkQfQ55zXdi
 Hs0QcQf/WBEaGbX9dX1G1etBXr2dLYdv7yZKvio/Euf0D87kdZhC+Npiab8Z8aFI
 BkHkgbiwanKRjJ8fxT/dW98JA72/TB1c4N8zcR/j/DkEACo0h/Z1x3Ati15ER94n
 WmlhewRfb3eZJA6cnZ9nM2CSPBQqXnDWv/Kj5hTgsL73cdp3KMpIEIsewHjTsllm
 uegk/eRHy8HX62GoNNFHSssDwTvRsIlB5EWMZbtDV4qDzpueDMqvaEa+H5wYQgac
 v3q0XwmhdBqWljD1M1rf8WFlSPr5hlSKuFhBX0eOUTrio1Zby0QlfJwWCLAs2VOx
 sKOHc6fq3k/LaJ1vTUksZCjVbeagUQ==
 =pQRH
 -----END PGP SIGNATURE-----

use consistent names

Alan T. DeKok at 2018-10-10T13:04:01Z
Files modified:
	* src/lib/server/xlat_func.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/caba97e972de0b6011e8ad6200efc25388a442ab
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCAAdFiEE6VbEmJeQrF8361hu/6TVgp+218oFAlu9pRQACgkQ/6TVgp+2
 18r7ow//ZDN5xjn3+JKNNP/0TShrv+ox8Tc7bH8o4m+NZXoIEj/eOMy2WZA/SYlJ
 TVaCMHGKGiF5hFYPhsYC6ltYtNopxKnbZgTFZF5F+9t0X+qRLsulCNMx62sp0SB3
 8ZK8TGv8jkCwsiblMaixUI2uwCJbIEFHoqYS54CARw+ZivnLahsK/Kvg8nHQDs3D
 Q2AxFWwmZZDDqF5NuSU3Kej3lLh63KxCeubV/jsGCRxvAB9ZcgpC5l20lvx268Wl
 JPa6HqmItNjzGpTma5J86SLRZP8OHD0/zvy4dJLg/cTk55WH+tC5ut6QSCDydBQh
 8eWeSyv4GhR7prdJbdNmgGAOrOd26xVeCiU6LkKO18X03cfFArZ2SsuqcPVm3myv
 JqGz+/r+QJj9odtX79WOBlZAWsBQLsY6jRi/b+Ij1bDldJ7H2FnOd0+pLr0yHSUj
 v25KbSW7d+K4fX27cbDq/2S8/IVBnPIJD5P+ziayVzBbfTVrvMzdKuzqgNeKuJy2
 SVz8t4dlexKPsxI1crBFWKzSZubizScSMtSAtzfAg9+SLlg74iio/G13+bdP9e5p
 1cZtiJl3QFyYs+aJ+yHRRehcqVR3SPZhoQwOnKoqGI6qqjSAD4+IBks8bkofJw7/
 KdEGdwsvnSz3SLE3xua6ayB57nNm3NlrFaWWqiZi7uPh8P0vTw4=
 =zjvT
 -----END PGP SIGNATURE-----

More header splitting

Arran Cudbard-Bell at 2018-10-10T07:07:00Z
Files modified:
	* src/lib/server/base.h
	* src/lib/server/cf_util.h
	* src/lib/server/client.h
	* src/lib/server/main_config.h
	* src/lib/server/process.h
	* src/lib/server/rad_assert.h
	* src/lib/server/request.c
	* src/lib/server/stats.c
	* src/lib/server/trigger.h
	* src/lib/server/util.c
	* src/lib/server/util.h
	* src/modules/proto_ldap_sync/proto_ldap_sync.c
	* src/modules/proto_tacacs/proto_tacacs.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/ec8d3b40d7b471bf48e463c1b68e78617f072291
====== 
-- 
This commit summary was generated @2018-10-11T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed).


More information about the Freeradius-Devel mailing list