Commit report for master branch

Wed Oct 17 02:00:02 CEST 2018

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server)

======
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlvGOLsACgkQfQ55zXdi
 Hs3WCAf/ZXVJlPfvLUjYJnYPySI7gsNkg2NznEco0WcrsJPTD8438OJ9+7XTG8Zq
 jzNw3S2ZjZ/X/gr859g4edN95R0N+eyqBAj1vlvYyVLIUzpgCFky0F54IiwyFrXY
 xA+o4cLdq518BcuBEx2ss9XITcmVog02qPayaPZAoA+1un9lT48kUka/1gT/89/j
 qGD1XI7tQxadj5oQZHbTsh2HUEIFZ+KFHxJaE3IK0ET2mUdIhfUS7tsFUf4O1Xv1
 vzmZrt8E7t9hQwPjOnchRa9GnDEQdTeCiydOX5sqM9DZiC2WCLg8xqdlhsReXfnl
 iUpeU+C951NlYqucT9Izslkv9w+1Tw==
 =Y+zr
 -----END PGP SIGNATURE-----

disallow struct[n]

which means that we don't really care about the size of the
structs.

On encoding, if we run out of room, we just truncat the data
as with every other data type.

On decoding, if there's too little data, we just return what
data we can find.  If there's too much data, we just ignore
the extra bits.

Alan T. DeKok at 2018-10-16T19:13:41Z
Files modified:
	* share/dictionary.alcatel.sr
	* share/dictionary.freeradius.internal
	* share/dictionary.rfc5447
	* src/lib/util/dict.c
	* src/lib/util/struct.c
	* src/tests/unit/dict.txt
	* src/tests/unit/dictionary.unit
	* src/tests/unit/radius_struct.txt

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/cf6f7af52d9155b5dabbc66980a47da695eb9e98
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlvGJ6IACgkQfQ55zXdi
 Hs3Wkwf/VMfH189EEjG9Y1HfUHg0SDtNeTvd2VVRrZYKXOPqn0g38S4T94Yz4P2L
 Rq0bkWGct04fDDp24LVlIzHdy8R32EJ23IWhIV3v+hBa6pD/a9Ext897t+pw/pWl
 6QS01Yr760RxF9zpK4aeeLshzjiO1qHDuDYSawdu1ar0fb7tuO63K9ZtrVpl2g2P
 9jdYZxhQawW6K04uSI1fGPWlG0y/PsRqfAKUyO73vzZ3C+QSI5DhN3v1VXFdRSRa
 d+vuM6FGU0j1D19f7j1SbND6rlkwH3Mwq+SwJIaBzrMd47Kjcu9GtrwcpVYY++iW
 UNm/SOsfFmyB7/WXeF/JldiMG+Y2OA==
 =1QAH
 -----END PGP SIGNATURE-----

try to quiet analyzer

Alan T. DeKok at 2018-10-16T18:02:04Z
Files modified:
	* src/lib/util/struct.c
	* src/modules/rlm_eap/lib/sim/decode.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/3c5aff4846c196d78932356fdbaf6b3e62528663
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlvGILcACgkQfQ55zXdi
 Hs0j8Af8C7pYU21ODfufe2wu3sH8zZCO0OIUvF03bZHIkIWMlPanlcfQdCDk79Jg
 nOtrnZmFg8y95yYQ60148+DH/OHwaaF0hxFgI+kIKzg4rrEn9gvgEh/KhxLW39OL
 +uTpZ+ERY+Dld6kpfCb1P5wAnhTv0DWZFXjt3Awcw3/PKVgjjPjLw4iL9QTgukL+
 3IepUXc+Q3uk0+tH1eAH1FPeKhDEkkFwprU4WRFkURESzW1qoGrcAK6gOutBTwQK
 X9Y2cRlb1tZ+DB8nUsCtbLZQn61mr3iXCnPC1yQGW6MQ7fr4gK71yMRjIUWqA/9f
 zrPYF4IGr527gC0HeE5oKVNBs69XSQ==
 =ANNy
 -----END PGP SIGNATURE-----

assertion for static analyzer

Alan T. DeKok at 2018-10-16T17:32:33Z
Files modified:
	* src/lib/server/auth.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a66ed9822fbedb3942756343737d8b76e084ecd4
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlvGIJAACgkQfQ55zXdi
 Hs2osAgAlbKotAfPBrrh34Lat53/Lv5SazVyadN03KFD23h7DzgtdTjCU6qYtTFf
 VsSel/2EFYEnUAZDJ6Zl2OF/+WJ+Sr/p+D/HaE22wEzpIB7ohuqVBVKDTWbmmapP
 dKB/IqUme9NYJilV4HYxKCV88+fyzdPnfuPYk4b+Ph87+rLtKpTg3UGVR4hhaS4j
 MA+I9LiRQ+DD3z/EKlC3lRt4DI3G1VqXHsjHjr5BoCLK7a6CdwQThGJw96dwSA8l
 iGeM1+I1OPgkYjV0XvVC+oZJ8gSxojvOHcwLCljFoE8QgAE2BhLwhNwwdXk4t+1H
 6S3fNfzF1Ocfv8rsIy+RMPIn4pAukg==
 =1FMl
 -----END PGP SIGNATURE-----

fix static analysis warning

Alan T. DeKok at 2018-10-16T17:31:51Z
Files modified:
	* src/lib/util/struct.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/308f43fae77e97aaa3dcb0aa4adadd5a8d8d4131
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlvGIAwACgkQfQ55zXdi
 Hs2hogf/YGoK0ftzdvsRcZODnzb4UKR4M2ySTDE/PDWTYRSNm8tMYAB3AyNyzZyo
 AkE6XYAUSi6n7tpj9U/AbK0yC4NiHyepXnk66mBXkRq1Hd3F2jlINrfuYBp+Fk2O
 FxkbuVyPd4yBQaGM284oFO5lRSbBW/7TXE3Ny4Srv0IG4OFl+adJ5Fe9IawHJaCl
 /B7EKR9Ee3rHyGKnXTKXN9u6Ckk5zaseYZapHMlRYb0Ulqeo3es+G0JdAA7d5Fvf
 0zHvuCBFbxYxNXQij6qYhWC4tNZGmHu94WJa+dXrI2kJUU1mAEYQNOWJyNfkYYWY
 0u46lLzDnSolZF+mUeZnV/7XnsefZg==
 =Xi28
 -----END PGP SIGNATURE-----

clean up process_authenticate

in order to get rid of old attribute names

Alan T. DeKok at 2018-10-16T17:29:16Z
Files modified:
	* src/lib/server/virtual_servers.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/ac853b7668d9110a8982a02be7b1fb57defb432b
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlvGGgcACgkQfQ55zXdi
 Hs0NDwf7Bt7c30GaxTb9Y1ZvQREixdCOJLE9mu6bmKbc+hBGavNkQEo/cnJlDX5m
 y1dKTKP0GNbLwtECE+7pZJpm+K14iFMKvpSGGsz8u2pwA5w95LKv4QGZJFm5rmCJ
 GEktsYOwDiBy4seDoGUrNOB3x3v8U9rL0iFTMjncb/caZ7VGsOy1j075mNSFi1O1
 Vbx1bjTedPQcakmETPO/M4aUMvSW4+/ZCgWZpEFonPD/N6iFiLmtA3QnAn7YdOYC
 Rs18GQo6RndzASkSPbwpHmNUNrOFAjkIskpISYJoNmCc8Iu1KFS6RxlFTu5NLE2I
 kvlENanZ+8VCdZMyrpsSgcP2kGjR5w==
 =kA2Y
 -----END PGP SIGNATURE-----

remove more unused code

Alan T. DeKok at 2018-10-16T17:04:03Z
Files modified:
	* src/lib/server/modules.h
	* src/lib/server/virtual_servers.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/7c885989d755469f2086c2fe103222b9c8c035c7
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlvGGSAACgkQfQ55zXdi
 Hs0wxgf/dk6yKB4GpUFzmb2hFbKj+bIPYx2YkG8ZZjN0Bkrga9MvTIiP+WfXwevV
 h5Zo27GuQfKNz3P8G07nKj9drlLKB9W/nN42pJq4dEsmApDZPLd4FKnJTvQbMwIB
 2v0AmatTXcr3R27WK07syjIDjl4nc7cmPj0vCzSFOmJBk5mLMOBIaaFJbXeFc93q
 YT7dOSFDUw38WptXiOreDUR1Isz8ZYCm7y+MEnDsE59BVBidvLD9wDTgT75RA1St
 fdxRVqcmTMC7OBrGLYGrkAzfygH2ASircu02WfPv3pDJXJusO09Cio+JaO/VzL1X
 Fk6ygmMYRN7+XMZLr3dINgl9OrZ3bA==
 =GUyd
 -----END PGP SIGNATURE-----

we don't need Post-Auth-Type any more

the reply code has already been set by the time we're running
this module.

Alan T. DeKok at 2018-10-16T16:59:49Z
Files modified:
	* src/modules/rlm_eap/rlm_eap.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/de68997ca25c61885564fdbb63cb45a19dabe062
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlvGGIIACgkQfQ55zXdi
 Hs1ozggAqMxzwJL+12KoHjUr40x86M0VyuTVuTSbrPqBPxE8CTzd7iWVRe/YTpck
 n6KpqKhiOyesQCVKDJSRWQuR+tU4uAj2s+rIaqUlphkn7y8mmmUFIDN1bQ/KJjsA
 pkN61z9uFFAvxcMykhU41dbXT3z9Os083Ut6RJ3HP8yPo4g7u4RyIf64POLDQAH1
 0V5rtfc3XKBNBR16i1yIHYI40tMesnUWDr9afxY+g2B+FmjgjYm62SaShrnldpBV
 zvXV827BY4O3qTQY2F3EPTir1oxAGGomvEN3YSkCXhaGTtoigtKoq6II15+XvWP4
 iPkK+eqE+yyuobAIF+avg43kAiJFyQ==
 =n5KF
 -----END PGP SIGNATURE-----

simplify the code now that the old code is gone

Alan T. DeKok at 2018-10-16T16:57:31Z
Files modified:
	* src/lib/server/auth.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/2f6a4314dcf2fda0795b50614267063dac8bbb94
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlvGF7UACgkQfQ55zXdi
 Hs2XjQf+LiCMJg6Hh+yp/2oRbHbXeGLu/qcY59dH41y8rLk7zYrgy5phcG/H+DXx
 ErjcNDWhdXyaA3+L38719EL2N1erp93kTFadiatsjddW0iFB6XzKoQNkHEAVp5+D
 XBUUEk3iuoRiOiljhI4s13jW4ilp2p286E66JdwYbLKniZw5sql9NmXw06IyjxDn
 Ar5JOC3a90yTx7w0RR1FH58RZypBKcOrp/ifLbpEXh6zyMIxEzmdaze/VMnpHlwP
 4PXQbqcY/G+4ij9W477/QzaQWS5QuV8BsJUIdKuRRsBaF1khT09zWPDjroezpBL7
 jIQcOUKB2jg3bWDZySTrvPjdBimdJA==
 =/XuG
 -----END PGP SIGNATURE-----

remove rad_postauth

Alan T. DeKok at 2018-10-16T16:54:07Z
Files modified:
	* src/lib/server/auth.c
	* src/lib/server/auth.h
	* src/modules/rlm_eap/types/rlm_eap_peap/eap_peap.h
	* src/modules/rlm_eap/types/rlm_eap_peap/peap.c
	* src/modules/rlm_eap/types/rlm_eap_peap/rlm_eap_peap.c
	* src/modules/rlm_eap/types/rlm_eap_ttls/ttls.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/362a28f2709bf84ffeb78472264c799b59ff43c7
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlvGFPMACgkQfQ55zXdi
 Hs05vAf+K+ewywrzOuq1phFez0s/cX7GFtpKQ8dPZurWzv9RMVCf1gEUCnnu3+5R
 GD9EvhT/gEB+wz/uUaJKhittJdMw2A18fO7KFDHgVKTRLZcLX85BB9Q+zO/36e/f
 DLL7pl/q2AN9odbXUVqIS1kFjH6g9Nbv0DZm+mDN0wzkRVXTs1r1ebdrzsuH24n/
 RNc9CgC6xaA+mjpog6Ze77jDc34XlqSk3cJ30nCzLA1KmJFCkFh4rpvW1H6DzknE
 pyCSA3jb4+EpwTPBfXeQLDNv64n2xObOLTHz8Vxy6jyZSeWX5T7OPSSZB5az7PMa
 LpyGn072vsh6vOrYONcrVpm6TufAew==
 =EXs5
 -----END PGP SIGNATURE-----

remove old rad_authenticate code

Alan T. DeKok at 2018-10-16T16:42:22Z
Files modified:
	* src/lib/server/auth.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/09103a925cd3a7fa88ae29f00e0207101a7b2584
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlvGERAACgkQfQ55zXdi
 Hs2vZwf8DhatLBH8am/WZymfBtSooqAbbTQd1yMrG6pBu43hJbnsYZnhXCDUo5CK
 YcrbBczt3+LuGhPQ4IzxccNqUN2h3xhUy8ZAyNnQYs6FWUhxXFDjTDxvw/7serdG
 y0qHJTEhwFyNz2dMETlaM/Y+UNcGPAxC0JKnGD7J2YtP6qYkR7Ztn8g+hatmjLb2
 GpHzhU0wgaLdpfEsCUg8m3/9l6W3FmNli/gqIGuXxqfTdF89RgQan2XhSIDZDXZW
 7TxIz8shHMJV/v2eUIDxj9UHu71MexIRPpmK9b0QuF2IM28YuNdp+H7F9gOiT5Rp
 Td38XOcsu/nj3LKs/7YBRSt6vTPiPQ==
 =Yc73
 -----END PGP SIGNATURE-----

remove Autz-Type and Autz-Type redo

It's no longer used

Alan T. DeKok at 2018-10-16T16:25:40Z
Files modified:
	* src/lib/server/auth.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/986059f0527cf6a3bdd8516b35448167a3133d07
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlvF9tUACgkQfQ55zXdi
 Hs2fMgf+IRYqzNWTpSfuUkJUGkm1cTxwmuC+WNVR736wQ8lrqUfActuOcvncU6IS
 vGZAlc1GW2JSzQakWwFBAFlVBhjqbD5iGXYGfA2jGAH7ltJ2FvaS7QVLE4TsLJWC
 3xzTV3LMaanTOLs6r3OnRtHfLMXc2C8kTlVAVCvBIzfa4pI+wSfEBQKCDRyNln6n
 Rl4YnEhijzrvrbCcoJjnGXC3pgge7klp16VAnRYhZzf72yWZ2hZNmgxqkJ/NJFl3
 OJ7vkkqHTFvPTECbK6JJjxS84oUWD2YQgeUgPKtnlWkmwMwvRUFIsYCxT49Dar3W
 i+/lexBfRzm7BkKtOUq0vae+qMEYEA==
 =SDuQ
 -----END PGP SIGNATURE-----

remove Connect-Rate comparison registration

It was wrong and unused.

Alan T. DeKok at 2018-10-16T14:33:45Z
Files modified:
	* share/dictionary.freeradius.internal
	* src/lib/server/paircmp.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/7aab5c5b8fcadb7b677b626a3ec7e67f7a1998ea
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlvF9ocACgkQfQ55zXdi
 Hs0kmAf/U5gWWgyWCD4r9ff23W+3Ze0z3MtobI66qRIDVGdfIy/n/mMgkgf371Je
 pbdmkKjtYv+q2Yzqm9O2qiqZU4QKL3k34iZE/HcwxVTKP8UWaBlahlZqlMAxYt/0
 ZEgtbc2WOhvAzP3mtMEFbhM+Xr87ybHWwNJhdqPNBALPUCuKCBq3k3X7iSrI32as
 ux3Mi6ZjPvRp3EctXcJEowVrIH56Y1t7ZoQRnt5iBKUznL9W2DAnfnUKqPFNmnfE
 YI6iQPxDrwMQ/Hyw6TlSgaWVtG8VT9YoJ7U/pSSkxYzoiLCwRtkVyroIkp0qdxEG
 KDoCIavNdqlAvsVWu/c4/SoLbpH4kA==
 =JCPH
 -----END PGP SIGNATURE-----

input is request list, not the attribute we need to compare

Alan T. DeKok at 2018-10-16T14:32:38Z
Files modified:
	* src/lib/server/paircmp.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/ada3993038e34145eb5e436ba96dfe085bd032cc
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlvF874ACgkQfQ55zXdi
 Hs2vuQf8DhN7mUeUn9rWuRvwiSjx2tpNZMvnK6Rb7DohSiB8hvR0PjR0/h5xUhL3
 qDWLZpmygtZgIR2JgLfVsTgFVt0uV449DHGG9cS/681dNBzIbZYPj9mMogRUdTBt
 Pbf2Ol4nWa+QNZbxgqZOUuR0SZjxzDG5Unk/cg7dZL//Xj8Ia2y65h1M6k0tWQfS
 y4mFSL9cz+p+yZqFyiQmQcQJ5fyI/9fr/dshf6edm8557KtFOjsCY5nZpdxr/0NW
 nNBg5ZOED/osSmc8OvWhfu9Zxa8KqCOD8GO9r0h/l+BmL1EvQ7NpwDblzDj1FZHf
 tW446Kr9F+fK/jUQcFmh4Y3jNM1Vig==
 =JWym
 -----END PGP SIGNATURE-----

inout is request list, not one attribute

so if the User-Name field is not at the start of the packet,
rlm_winbind would do bad things.

Alan T. DeKok at 2018-10-16T14:20:23Z
Files modified:
	* src/modules/rlm_winbind/rlm_winbind.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/5399c28270b72cb648d8fa74aed6c5dfb5a059ee
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAlvF7v0ACgkQfQ55zXdi
 Hs0e1ggAiiNgtySjKpzavNX3EZPU6uECS2TKaKS3ygTLtvv49Oobo4+PoSmF1doa
 7CpFijdmczgCiNykJVSkV/pBK6YQJu5eF7VCU19HldAO7uKUd3r8/BoKpWFC3vJT
 MlmJj++smcW82YkFd68BVuTL3ikS6el+lljzYN9sJZPUXHeWpELBek2lOjt3aD7E
 Lr2/Pm+ZNfWsYSk2DVheYbuIrxOiVp4ePojcHAsmhILMG3ftkePk5lU9Gwk4LM+a
 3yWxrlXELeepS18+p6MSqwA5T9o4j8/XIZNw/hijfDuUeAmn40KyDXolkG3pcJKD
 ONiWEqFaCXbvLzWuaPd9USM1VxKQtw==
 =mia9
 -----END PGP SIGNATURE-----

remove "compare" flag.

It was only used in a few places, and in the server.  So the flag
shouldn't be universal across all dictionary attributes.

if the admin defines a comparison for a pre-existing attribute,
well, that's something we can catch via other methods

Alan T. DeKok at 2018-10-16T14:00:29Z
Files modified:
	* src/lib/server/paircmp.c
	* src/lib/util/dict.c
	* src/lib/util/dict.h
	* src/modules/rlm_sqlcounter/rlm_sqlcounter.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/0cdbf91e566d19217f06e51967b3f2942b4a84bf
====== 
-- 
This commit summary was generated @2018-10-17T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed).