Commit report for master branch

Fri Aug 30 02:00:02 CEST 2019

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server)

======
typo (#2938)

Jorge Pereira (via Arran Cudbard-Bell)@2019-08-29T22:42:23Z
Files modified:
	* src/lib/util/table.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/de0939585e0926c3ec3dfc05181da04c25c0a95a
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl1oCwwACgkQfQ55zXdi
 Hs3rTwf9GOd/AyGg3wfdINuizUKpj5tE3/iCOi66bv3VUjRV/CtTIc36OHBp+uuy
 9FiDRNPQ55nMnY70Ap4WMcVA11BvfI6jkWzeMBE6SIHlm5qCHGQWrLhAhL9BiX+r
 9FX1jGwzoTB82c49j9xW6JM+Ig1NFNAt4LrtcCbCZ6qI4R2LPd4mcOGlG9DrIoYx
 zBF4y6isqBXWTGZiHmt8Mz9TT40/F7O6x4WdgYAZXkLQdef7+6QMaZrP3GnaXF8x
 D8YUJFZHy2QYIClqd3wvaRtJ90NtIwV4405iVMGv0EYenLpwfAHk+wKJ7sA2dMvN
 CyhVdyYe9RY+CrRQcdMG6CvTjoNtng==
 =Qp0v
 -----END PGP SIGNATURE-----

more typos

Alan T. DeKok at 2019-08-29T17:27:40Z
Files modified:
	* src/lib/util/inet.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/e3d38ba46a12c3d00c2f6c35361fd30b02746f8c
====== 
doc: Add 'update-check.doc' target to update scripts/checks/*.txt db

Jorge Pereira (via Alan DeKok)@2019-08-29T17:26:57Z
Files modified:
	* doc/all.mk
	* scripts/checks/missing-raddb-mod-conf.txt

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/44bf749c4c192b6e13150f22f995c12622afbcfc
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEyBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl1oB7EACgkQfQ55zXdi
 Hs2FMAf410w5bLzvMp+yur3be3jg4KkNKujejofmTG4IdXbK7qsTjJhAx8OUw/A/
 hNcupUhu4SU8kgMpm4Re369ZnPvX/n0VFaJ3Nb2jMv96UuNmrYH3E13nXb2x68tr
 ZkvFzineQPb2xLY2NEl6Ii62rxCQj9WKf6qHRQtJwzxL19XCza2I5h4bjob7KXJe
 krP9pzeS2fevvi33fITt6JytOHd+2uQWmeYKuOrhK9P61o6393XDx9tXBzJxFaF8
 OLKrOMfa6vI86NX1JbquN6Rzl2XZ+9997YQGVM4huEaHbxaTb20LsyofbNRk3CEB
 WaKKOAI5RMhPkcOx9BRW/rQumcwN
 =1hDN
 -----END PGP SIGNATURE-----

more typos

Alan T. DeKok at 2019-08-29T17:13:21Z
Files modified:
	* src/lib/util/table.h

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/8de0ce756c1e11d113ffa9b0e29f142df9dbea7f
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl1oB7EACgkQfQ55zXdi
 Hs3QYggAle1AJdrupQHAoVZHof0H9bTzdfsoNKrYUEmfEY86fnN8Ww+nme9SQCNA
 Zc9bYGbcMoodfeMuMxtUGJtIBeZ1ZzmuSR5wkOpeBrzoUEHMvsqU6THohc42x16M
 XSj6GIsuVkikvseZnd4J51nlGD0MoIZJvZJA93UfpSus55UzGeEXeiLHrLYswdql
 a4ZV1erHV7iB0TFKJIwoQpeAIQCtm0wZ3qn0+Qqc9IvfBExKOFDaAhKXcjdQ4ikH
 COiND4tldyaZIbxTBxdlubqfBfJ2UqJtpKOextbqLCmvfm8RYteB7H+EjXTdb5zp
 mnWKaxPPnOUHlEbtkEsMweJzMFK6bg==
 =UmDj
 -----END PGP SIGNATURE-----

typo

Alan T. DeKok at 2019-08-29T17:13:21Z
Files modified:
	* src/lib/util/table.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/c0d58cf777fe76a188f62add0e0f7f1938938273
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl1oB7EACgkQfQ55zXdi
 Hs2lHwgAheq7ILWN1BCGvjFIuoY9gRAz7zq82wXk9Xa9o7a9oTe6QsZKraL5q3EH
 fk/EVVUJHH0iZKv1cKwxeA2M/KlX4OSZja57wS4hqWAlzoQZaC5AN8jRP1vAQM3g
 yJMZRuzZ21wohED7q08E53DLycBeOWNHm7Yw9ErToHnQPVOJSxpXYuq5teLeJ2QU
 ANJI1h1ItPYFJSHc/+f5tm5UqVUhEWoosW5EfsKcYqo1aVOrFQNYuJUoNETtyc4Q
 R06Qg9V87UW1Ko7Q7KFeDYjhZkbg/mQN/QMYPs0B1gJ04XARkeCWxSoPjdLsBZlD
 VlGSP2ejaQ5GUKNShKkoIyJPnkJQzg==
 =Ddr6
 -----END PGP SIGNATURE-----

remove man pages that no longer exist

Alan T. DeKok at 2019-08-29T17:13:21Z
Files modified:
	* redhat/freeradius.spec

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/74daf3f5d11595d145a852fa9a71e3123948f6a0
====== 
rlm_lua: Fix 'func_instantiate' and 'func_detach'

Jorge Pereira (via Alan DeKok)@2019-08-29T16:30:26Z
Files modified:
	* src/modules/rlm_lua/example.lua
	* src/modules/rlm_lua/lua.c
	* src/modules/rlm_lua/rlm_lua.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/dec75c7613551d26ba49aee5ee997ddc6865f915
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl1n96kACgkQfQ55zXdi
 Hs23NQf/aIweL7jg/Wbib2Tca0VQw1CX51AsJ/cjD6nmj4idGLksfcFSeCEhL4Ul
 7aL3YX/EUdltSN6+ykY6+nkhCuJJ2oDOjZnmP5fJsU9PmkMvQoo+yhPbjxsWSW35
 Eyvmy6gNFAw43U6URklm7gnaxPQhm0ecvcvqgEhxJrW+TD1KBpUavrJffeNWl7SS
 kvuNMKghhNHuOf+aMcptMk4wc0HCkAUehJJ7I/KGrUnphoZa5R6QlRskcLkm8zD8
 X/Bt3hLSpV23RGv2tCyZUz6dtvvKBoTC1is+0/aTR0ywlbUeMhVq4+HvEC7wVPLU
 quY/uWmSxxEWym9fr/dHzXFSmfzbxg==
 =ivl6
 -----END PGP SIGNATURE-----

just print out each thing as we see it

which makes the output a little harder to read.  But it also
means that the output is organized alphabetically.  And therefore
doesn't change with different hashing methods of the parent shell

Alan T. DeKok at 2019-08-29T16:04:04Z
Files modified:
	* scripts/checks/missing-raddb-mod-conf.sh
	* scripts/checks/missing-raddb-mod-conf.txt

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/ba0d90af77923adf21ba63c49c3ed06573a7986d
====== 
doc: Add sanity checks to verify if the rlm_$name FR_CONF_ is documented

Jorge Pereira (via Alan DeKok)@2019-08-29T14:32:41Z
Files modified:
	* doc/all.mk
	* scripts/checks/missing-raddb-mod-conf.sh
	* scripts/checks/missing-raddb-mod-conf.txt

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/964e05e04ed49d21672a5ed3ad7f02c4dbadc9fe
====== 
Don't require a lease to have expired if we reallocate it to the previous client

The current default allocate_find query causes per-client IP allocation
instability that starts when allocate_clear rate limiting comes into effect.

With initial pool conditions the default alloc_find query selects from the pool
of all *expired* leases. It selects the least recently used IP address (i.e.
the one with the oldest expiry_time) unless a matching username and/or
callingstationid exists in the table in which case these are prioritised in
order to issue the client with their previous lease. Normally picking the least
recently used address helps to avoid issuing the address to a different client,
maximising the chance of stickiness, which is desirable.

However, if a user makes successive authentication attempts whilst
allocate_clear rate limiting is active they are always allocated a different IP
address because their existing address is unavailable (has not yet expired and
has not been explicitly expired by allocate_clear), with the effect that there
are now multiple rows in the table containing the same pool_key, username and
callingstationid.

The normal ordering then has the undesirable effect of ensuring that successive
future IP address selections for the client will flip-flop between addresses
because username + callingstationid are first prioritied then the *oldest
expiry_time* is chosen (rather than the most recent expiry relating to the most
recent lease). This behaviour persists once allocate_clear rate limiting is no
longer in effect.

We can avoid getting having multiple rows with the same client details by
amending the allocate_find query to include an existing row matching
nasipaddress and pool_key in the available set of IP addreses regardless of
whether the lease has expired or not (i.e. re-allocation of a current lease to
the same client).

Terry Burton (via Alan DeKok)@2019-08-29T14:02:04Z
Files modified:
	* raddb/mods-config/sql/ippool/postgresql/queries.conf

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/8bb2137a63c1fe547bca10c0c36855d0119cb681
====== 
rlm_chap: Add documentation for 'normalise' (#2934)

Jorge Pereira (via Arran Cudbard-Bell)@2019-08-29T13:56:01Z
Files modified:
	* raddb/mods-available/chap

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/0a1931482f0d4ca2aacac56eb3b1335ce0a5f007
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQIzBAABCAAdFiEE6VbEmJeQrF8361hu/6TVgp+218oFAl1n2EsACgkQ/6TVgp+2
 18oWzQ//YXdT0yHO0z7UZ0L4a0mvD+bXzkryzapBEAjJpjhQGcvoHXLIrobpjdZv
 xgE+DO0CwzbZ3ETkSG18phibL8Eo3YNcxWxMZl7nzv7Fe+9VThFFI0twlw7T3FYq
 IxaQxH5Dw7hi/asxpSXI2nkLKO5yUYMqgt+xbiwfe7KPD0KTe/6T0ZJtFCXIzvOM
 m6zP8pFlkaQJilAjUZsCJe4QdsRn1iTVsr0OYb6igyfecuE3kIxCKLnDs8+9qwgT
 Pe7R36wc10aRW5cI10ykedznC8bH/d9PayeLr6HYNOx2YS45exmIZX1ai7k/GwAj
 qOdf7Yn0U80JVB6epy5UZ0G9CwQRVhY4it8TST28vvXgus68cL+PpRlavk1+w0r2
 sQ6xtHcN20Qb21y2E3W99r+26dQA3+LE7EyefoKfL4z5DsrYxSvMKsRI0jo6CgGt
 enjlCAev2arLg5/xPSyRy+pg+ttkvOqktSlRcYLie4ASlY72aCSMBKtwRIIH1pqh
 ea5+T0Ojo99eevRLSBRmtuwDrOirQSZ5zGka7TIFrxcKvsqocNSP8kSX7U0jrRq0
 SgCxIjM3bHvBXOehpnFBtLuZB9JGgrE0rCkG7HFL889qaoqjIaKt0PB4kFeX5ALJ
 C+E5ovSmro6HqpwEXX1OjJzZFEKBCagAu0dT1MVYnrX3dndx/I8=
 =ATOc
 -----END PGP SIGNATURE-----

Minor behaviour changes in password.c

- Always process Password-With-Header
- Don't require the use of a temporary ctx, and explicitly signal if attributes should be freed after use

Arran Cudbard-Bell at 2019-08-29T13:51:07Z
Files modified:
	* src/lib/server/password.c
	* src/lib/server/password.h
	* src/modules/rlm_chap/rlm_chap.c
	* src/modules/rlm_pap/rlm_pap.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/b833f4ec572501dd4da2308f4975aa7d0a8d6746
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl1n0FQACgkQfQ55zXdi
 Hs36DAgAjlvNO6kV8NgwhFOCmoEukozColuGlNXWWkFAT50JtXEYkHLuT2yuGx49
 xEsL+/asZxzBZh2L7+MGpFC9mBNsX26Iop1hLgiHsA/OXHRKuvCW8evydCGUARsk
 cJC/XX/Atd60aQ+J26UA1o27DvSKP/71MuHRqvG0a9SYTdpIMPObtUfz2QcLwDBk
 AO1RnlxBcD18Kb7UigrHF8HV+OPXUy/iQZ9QKhU5GD8g6voz+Bk7l96zhhVujcMB
 tXE0TsaZ7bY5dC1aaq3g6AWao0BXRObNfvRxeTJgZ2m7lDA898thp0BXy04mAB16
 eXE0TLuZM9TeNMfnybbZXGi6Fp7D4g==
 =8YOk
 -----END PGP SIGNATURE-----

update and clarify

Alan T. DeKok at 2019-08-29T13:17:05Z
Files modified:
	* doc/antora/modules/howto/pages/modules/ldap_authentication.adoc

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/ac8536f567295e62606c1f61f5d7bb1f1d1fb6b5
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl1nzPYACgkQfQ55zXdi
 Hs1LPQf/WRiHilkADNz08J91SicZWIxO6xWfk5c+K3ati2c8FTvVfcOxJyETYV3f
 5diHect0Jw2JA3sSBFwvzAP5askGTQhV+UfIIUFyPBDxdQ+Kud9uU0lsADwGGpTW
 zEBL7sieAyZosfcomDZ+ti5eRVq+QobfBgdAQMy2r6i+y9fIk20zKmBv7NhVLCI4
 9/7TkbQwK+TQNU2RRUC075VO61B5CPVn4jLFXx+sd0KHU7CSDB2WzNJI3yjgubEr
 cm6FN+bHhR7cUgZOZogkhbBtS3ZMGFnv+5OpEWwSBPcHxFZ4jU+tMfNjOc0alP1I
 wRhrsXotFMWHanGY55jnzwwENK0TJQ==
 =jIKF
 -----END PGP SIGNATURE-----

use NUM_ELEMENTS() everywhere

perl -p -i -e 's,sizeof\(([^)]+)\)\s+/\s+sizeof\([^\[)]+\[0\]\),NUM_ELEMENTS($1),;s,sizeof\(([^)]+)\)\s+/\s+sizeof\(\*[^\[)]+\),NUM_ELEMENTS($1),' $(find src -name "*.c" -print)

Hmm... Perl...

Alan T. DeKok at 2019-08-29T13:02:14Z
Files modified:
	* src/bin/radict.c
	* src/bin/radsniff.c
	* src/bin/radsnmp.c
	* src/lib/ldap/base.c
	* src/lib/ldap/bind.c
	* src/lib/ldap/connection.c
	* src/lib/ldap/control.c
	* src/lib/ldap/sasl.c
	* src/lib/ldap/sasl_s.c
	* src/lib/ldap/start_tls.c
	* src/lib/server/exec.c
	* src/lib/tls/base.c
	* src/lib/util/event.c
	* src/lib/util/socket.c
	* src/lib/util/syserror.c
	* src/modules/proto_dhcpv4/old.c
	* src/modules/proto_dhcpv4/proto_dhcpv4.c
	* src/modules/proto_radius/proto_radius.c
	* src/modules/proto_vmps/proto_vmps.c
	* src/modules/rlm_cache/drivers/rlm_cache_redis/rlm_cache_redis.c
	* src/modules/rlm_isc_dhcp/rlm_isc_dhcp.c
	* src/modules/rlm_ldap/groups.c
	* src/modules/rlm_redis_ippool/rlm_redis_ippool.c
	* src/modules/rlm_redis_ippool/rlm_redis_ippool_tool.c
	* src/modules/rlm_rest/rlm_rest.c
	* src/modules/rlm_sql/sql.c
	* src/modules/rlm_stats/rlm_stats.c
	* src/protocols/dhcpv4/base.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/05ead58678317acbe2b901596c8c8a45f3c2c6f4
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl1nu/YACgkQfQ55zXdi
 Hs1JSQf/Ri7WcgGLysnQuZgsD1KqmwltCtG6aJnfXlxgeRx5X/W4B/HHfGZ6d4gC
 r7v3IVZEs/SVqNStPl6+XIZMHfWxLj3QnuefkY/S2xtnZyM1Npr9Yq6b7erqIDnM
 tiGJGGMr57jmQctRKrT0NYOPa4D5fjP7wDHtPKRqYIiEVogLvMBHugJpjiWeAcXK
 vcwfsEIKpFj9J4Vd0W/3ByjmNvaFs+6xCh71movWqSAwb9yCvfV2EqfqknSO6i4F
 GahZcX3OW5kI+R1866IiHn6ibNpR08KUNH+KPVGskzvyADSU0Ob8QV+TeB/Z4IST
 MQOatWqwLCjWm4bTCFXiQC/vmGutWw==
 =IWg7
 -----END PGP SIGNATURE-----

word smithing and cleanup

Alan T. DeKok at 2019-08-29T11:50:14Z
Files modified:
	* raddb/mods-available/chap
	* raddb/mods-available/mschap

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/7c629823e6ccc0410a106168c647689e7e9124ef
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org

 iQIzBAABCgAdFiEE6VbEmJeQrF8361hu/6TVgp+218oFAl1nOdEACgkQ/6TVgp+2
 18rIiA/+Jg6s3i3DUXM8R+x1+NSdcNdkErKUzezxi8E6Im4zAXZxRLViDao8AlL1
 LxH2f8cD7BR+Aj/Vnnl2CeYMgPFnt4sOTgvUm11fOMxcZnZ3hykDkTQugUFlqul0
 LiEnFUnbFAuMfbrtCEWOZ5gnOBnhoU8oVVtPrlQyxNF7scJ7pYEQiIlqAJzYqrVX
 d7lSx08NVBUQNs6X2v5a9351BsU1RzfR19QoCXCHt389ZaJ6N0jC38a6qOt5I+vk
 v/cgMMAoVBix0vpVpy6yYjgJdJTIIejZk66pdBir5ITVVncV1/eaX6I/fU1CiCNM
 nX3iVMy/TOpOimtZXlw7pyMC44v7iGRIQOgNtPFIVdzOB6hDjUxfpLh/0dVi78fi
 Y6Mi+P3FKDrNKPjm4wu7Fdn2wFO/3Hw7aijlgaDtOxw29/fqPZj2VEabk3eI7/x0
 HU23oJZ+ZPmyvu7KtQejJh8kmVR+fo/Y+m5/xTXbUNLThd29NStOQuP5wcI1cW6I
 +fIwJjNfU4xvu83ffOCdEWwZf2TNcDNUcqvYQSV/rUntHzwPo3HOOAnnQ+XcFiSO
 9OrOmXgBmY2yIDsfhk+TVIhvvRRHH7rUtp599g0ReKaC8uAcsYAvD8ssdzgPn67B
 F0nAgEnnKDN4zLHlMuxB6X8T1Ryc4h8osR9kZZW92RyhwMK8Vbo=
 =2KWe
 -----END PGP SIGNATURE-----

Stupid picky compiler

Arran Cudbard-Bell at 2019-08-29T02:34:57Z
Files modified:
	* src/modules/rlm_pap/rlm_pap.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/bd7af45e6072c24093c736e9f161aee47a0e23e2
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org

 iQIzBAABCgAdFiEE6VbEmJeQrF8361hu/6TVgp+218oFAl1nOC4ACgkQ/6TVgp+2
 18ospg//QIdzOffB4+Pef5umn1G0OvPPNgiZ8V5SweEhAj7DbfqENcNcVvvY85xx
 DXzs9okzvkoY6ZHP6TDAgOze0DEkXEvYWbHpmYS6K3omLr4/V7mY5NBb0qo58OaN
 BlvcqAssD/v6u3+DwztFQQsyO3WVh74AHZFTtDfljvMvJCizvbP5NwGUMR7CG5xk
 qkRqEf5P1KspmzX+Xhh3IEmIAhwA9AeLmRNV7GzqH8InOWzkKnjo849ZPcSHjV2S
 t5RO6J2CmUd52/C/ABbSyBVo2X2H5tr9WElGTrRhlM2sMupSxWij+wqUiIkzgLCk
 5UVioWbIGOtQVdFg9wDlnPtOB3MxpxyFrwYY8vAz4MAuhPRNg5LvWPaHg1/UEY4y
 oLG2gtP4IKg/FFVLJ/fl6VZPE+1UQfB9F+ndRR5spf6X8DjMVFrdXA7yJyhRl+6n
 GX3nfUb5/akV1roTHSMd+5aCpGh/XJkhSNLxugH2WpDXjMRIG0LjsraCMInl3zRI
 Tq6NJ8u18SD9p2EV/24WxoBeohjt1beQYBXnDBVWwg46twZUJn4Ny5V4QcqrwiI3
 +FUIO5+xC0dWtQ4AdO2G08bUdtKtOX11yw0VACJc3HJk6TSNnO8shj7M8KvC5PkP
 53GzesezW/XagdDZIx/XvAlBNEwKwL0nyg/31AQEQiVQO/kkUQg=
 =a/1r
 -----END PGP SIGNATURE-----

SSHA1 available without OpenSSL

Arran Cudbard-Bell at 2019-08-29T02:27:58Z
Files modified:
	* src/modules/rlm_pap/rlm_pap.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/1f65af75ba2eb02f556cde8edf92b94e836e64f3
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org

 iQIzBAABCgAdFiEE6VbEmJeQrF8361hu/6TVgp+218oFAl1nMcIACgkQ/6TVgp+2
 18pnGQ//b65psIUjKv0xs47prDlArPX65tcnZLhATHXbIvjRdOxBgvQ0At9jq5LE
 HWsZ02WB4icAofm2B6+Tk27dFUM7jne6kEYhnyIbfddoLqVNmp4k9/MMrvNKkrpU
 +JfmXCpR07QADGVANa8eWjmtaSSSSMh4LSKVCW5akCK+gZSRUV8zJsr1mJAWPkM4
 iqJvNi+EIfHDsypbdeV5u1/O1maymjATw4XdLGiscGSH7ZaoXwnp9N1wJKKjc3gl
 5aenC/hPMKmSANQ0n87yEUjxi/ynODT+qqP1EyNZtgIb3y4KboB1R14ihClrM8Ig
 6GblYQq29FTy+/MtVdxRKh5ePBknT7iYnUcjLbRCEHlb3gkrNuKssGsCJ/94iBJ+
 UnsBlLrN3T++FS9+GZisL4iaF/hXJT5oDnvt6svOT5P9wtfgKfmFeqzGqHMUgfXv
 mpAF40q/93SV9SuDTK5qodVB7YGAwsQksQJRuWMhTDT7SQeXGvLIYVdR1xYRU0Dj
 /wxqmoXu2qSPFGLQ6bjkL3WmUQY/OrkK2NiQ75Sw6cTzWvRPH2XP/WqtUYHmp6BW
 dxvGzwHJuUYawYpinuC/t2epLe76gy9lpfyfiMShPzuiiS6wfqYKbK/dciUomXnb
 RQQHNcPi2VXfzGp8PuY2hn4Xra2u7R/eVbr+5D5fgkx/hcMtceM=
 =vW5D
 -----END PGP SIGNATURE-----

Instance is now used in rlm_chap

Arran Cudbard-Bell at 2019-08-29T02:00:34Z
Files modified:
	* src/modules/rlm_chap/rlm_chap.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/e1b31257ab1efc7183a0401c717ebc8e8353034d
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org

 iQIzBAABCgAdFiEE6VbEmJeQrF8361hu/6TVgp+218oFAl1nLHUACgkQ/6TVgp+2
 18rFxBAAjn0kpmDnv5nOZWYoEsS1pTHyiZDEKfNUCsvdGLbkfdvByoA+oNLqC0py
 dbprAicbue1tTHdgo5ACWPn1CO3/cZcxgRDQTGBn2LRLPaWRWIu3J9n4PqikvQK5
 X9hNC0fg0gMKK0dYjOwOaQIynLulJVsirZKo3jrT3BrpO8ChaksMvRMpT3aVi23M
 w+CzaTMRk6ffPz5Rk4iqfzUdXZP4VSUy0H2wwzXUCaTflMPPfVoQihL+7QnOpbzB
 vrs3fWAohMNnd1dYjUhpoUYcAo8ql9drJttGQ75VgU/EifpXD+sZylPigzEkqSdu
 cUX/fU6VWYLTGhhlX1uvHkw0Iiy+mvwhE4EKFChcwjZCOLLhegISwdNWLPEDKtt1
 ZQ57J6gFl+MgNEoK/GaFdOi/OICoFOw38pw0UAXzty/UF36JQIGylUKicIcks3vn
 8llptCmLX4FRDL/K3+n4SVVAF/+PdssjzlVRFth6gy2wbS8aCE3a8cFbGWvsD/1O
 8+JEjZ823ZViU+h7oYYwffiTnLwUzOqqI/nFX5O9++p8gFUcXrcnz3uaa20LfG1o
 KYLcO0fcnpkLuPyGDDzGfiT+M5Yz1zN9j9tiKY9IE1doCkmDYxypPi6jd+1fAN/u
 P8LTySFqLm+qYtqwblNVm/9cVbn/5nCGmMQeWZyR4qVi/VmVMyY=
 =78FX
 -----END PGP SIGNATURE-----

Various fixes in password.c, rlm_pap and rlm_chap

- Move password attributes under Password-Root
- Apply tighter bounds checks on hash length in password.c
- Failover between "known good" password types in password.c if one type can't be normalised or is the wrong length.
- Merge password info arrays into one table in password.c
- Provide two public functions in password.c, one provides a cannonical version of a password attribute, the other rewrites all the password attributes in the request->control list to their canonical form.
- s/(S?)SHA-Password/\1SHA1-Password/
- Support multiple levels of preprocessing callbacks
- Support restricting password types password.c can return
- Use Password-Root TLV to be more efficient about locating candidate "known good" passwords (should be MUCH faster, and no longer quadratic).
- Use proper hash length macros in the hash info table in password.c
- Split SHA2-Password and SHA3-Password values into SHA[23]-(224|256|348|512)-Password attributes automatically.
- Provide macro wrappers to allow us to easily add additional EVP based hashing mechanisms.
- Fix pap_auth_func signature so known_good is also constified.
- Prevent normalisation of Cleartext-Password, that's probably always the wrong thing to do.

Arran Cudbard-Bell at 2019-08-29T01:37:57Z
Files modified:
	* share/dictionary/freeradius/dictionary.freeradius.internal.password
	* src/lib/server/password.c
	* src/lib/server/password.h
	* src/modules/rlm_chap/rlm_chap.c
	* src/modules/rlm_pap/rlm_pap.c
	* src/tests/keywords/pap-ssha2

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/e5daf0d423223ca816c5d3abe8ffa3ff4267ab64
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org

 iQIzBAABCgAdFiEE6VbEmJeQrF8361hu/6TVgp+218oFAl1nLEoACgkQ/6TVgp+2
 18rhmhAArN4KVV77T0hGdoS9uAQOKnERBfQgo/knD5gMiCQ8QbHqDa25DbYuxKni
 gQrEQ3/VmfkqQPzD4nbGtAfDu/dw9N1lwLkA79pp7Xqk2iRFwDc+4nGEeSweWe0E
 vc5aN9rUbyZCWCUcTzI6UhDwa3eqcY+/MnSjx/jfYr3KKhbON+JlMdW+BBoUR4eT
 s11Hl934nnPAMaceOiu2t2bOQC3nD6OCol8PG8zr/a7r0pNHhaC6gMQfFuLiGnyh
 9ABVnSPElam2C45ecppy4UMvLVwrYh8p6wKGFoqgndjsEI5E97YKXzdKEEAQItzp
 fXNFGbjR/mXOWWss0N25IlN35COetrMmEN3XkFUgY306mxPlPrPK2FeJNvCLFlul
 +CenyFBvuRGCdtPiDEmN0kcCqqFlMfxgLMYx2T6Rlzd3wrcIeVxvXkgGvhLjXYVB
 oWbXzLwQRu/nDxeyrfAyo7Naw+gmE8EKyVY7EJVXAp7IQi2XFurXfxZpbPpZbyc0
 yFmpIFLDqZl6A3E4KSdSZUjd+zvxPuw6mzx50sBEnGZ6cBzDl+B8Xj4mODSUX7PN
 ScumvA4RBct6nD2jBCEcBm4qoOAQzifhVAl70Tj6u5+Nkhsk+92bdozAlqQrACVE
 Q4KWzzv9CXgLlX8c2On7qjsYphOxMDgajIKOSCB5chP77NJlse0=
 =naHo
 -----END PGP SIGNATURE-----

Don't print too much of the salted hash string

Arran Cudbard-Bell at 2019-08-29T01:37:14Z
Files modified:
	* src/modules/rlm_pap/rlm_pap.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/b930391deda6f0dd5639a246e8b4c1f7ffe456f9
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org

 iQIzBAABCgAdFiEE6VbEmJeQrF8361hu/6TVgp+218oFAl1nLEoACgkQ/6TVgp+2
 18o5Eg/+LF4J0iS80erkQU0CbAE2/gFWvLu81XpT92VTga0KWuXx7M79cX+PyLi9
 NQsgtmtJo+i5h69ljPOXGGzyTvj1BmCt4tMB0jWGXFYo1fNUbFYkm0DSkmUoQZ/l
 Rqjma7f1edkp2c59hU81FFIVZ5Aiw+SFU1g7uxl42qs/ga9h6GFaZ2cFDeZeEfe+
 LlM4+h8t2J7qKj5yiPlF/CcYxQnPHi928ZL9qPcCYnKvq8Y12LVSgfFAWh4F2+Zr
 gqEQfpIwrKniq8cN39A8aVa/L3s8euKGpW+tfpRcEOHvj1RpbFdMdoNNrxJqfqNE
 +Tmojg5S5xNWVLD/GPMj0Q6Jm73vKWPod2is/23MudRM3Jb9x4K98TzhOuP3w9Ld
 e+hn+dTTms+CtRYndEA8WRWC4seD3jP//a0eW220x+b+mltAP93F5HQzhwEZMqDf
 +tUWOFxHDD/3AMl7Y7cKr54WSEJiz/zhhvLRlWTVh/Svjm+i0h0fMTcYbPZAVwDP
 xmaDwLGALExyS4EY+HgH1vj26zmidBCFs/pvNfJD1Vwg8O6XROrJTisyvzT1yZdH
 AMfM/hE7BYk2ahkqV0hjW7n2GYBp+PHKeLcHf39VqCYRt6y0LR0mJbxvs47AJ6o5
 fq878HwP+2v9S07foMajBVSM63esjZSFn4L0WtmJgBd5n8ceywo=
 =Pwcd
 -----END PGP SIGNATURE-----

Remove normalisation call from proto_radius_auth.c

As discussed. It's bad to mix internal attribute processing with protocols.

The normalisation could be applied equally well to many protocols, and rlm_pap and rlm_chap will do their own normalisation without mangling the existing attributes in the request.

Arran Cudbard-Bell at 2019-08-29T01:37:14Z
Files modified:
	* src/modules/proto_radius/proto_radius_auth.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/1124ab8ba736da0f0635b878aefb6107f2ef2470
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org

 iQIzBAABCgAdFiEE6VbEmJeQrF8361hu/6TVgp+218oFAl1nLEoACgkQ/6TVgp+2
 18oUYQ//bIDQQBoTuVE/HVZXo3YgXjdYxyyBfRsnBH/Z6r5Ny5oiswKg+0zogTE5
 7LhlTYozRf/6f/qEuzCwbZkF+fjfi6V4nadjhTWD4ZHBh3Az/tKQkaJ0S38hXzq3
 cbIlHtr9B+qP0uH2bIYKuueVrrQFI0RF0Ti9FLf0S9FNkAxcx/JxmObl/PGqfM5F
 bgSbMXNiRdqmCXl2zmTHCT0XKYzz2mcoCOUHXpw3870Hh6JhOiV+GOrraGriwN+N
 qGNRXfiMPymWlh7Knf0tRHF2ixVzA50P9DWWKiFqPfBH5tSel+DQsG3tvKKvEvzl
 STHNAB4X5nq3kN8g1b+RnqBhUzErbViikS+XXbEe/9iGXAOTdrHIJ++BwlZ64NDG
 emu5JvVucIAAylowlDflsHNDBow89QL4sIf4FupbHPJ+Jj5eCpUi686jDFo/QIyI
 nfaYjMMXDxyphW8a/snawrL8xyy6JE0ZAlLCsz6sRfTBB9nEmCGrmLtrMFKI54EQ
 Up7dXbXiLbA1edUKxSgTO9idkCGqlQpEffTPbKG6/rePNHZBFjNaj7sdxGNbZmvo
 o4OWtSmBOR/JElv5P6yDR2B3Ug7IrTXUPXBBdiFaQkIaaXLdzhFl9TlGlW5aGG5l
 n6/+8BecxtujsHL53l152HCpItLqnlR1EryEh7ErOKecH7qv9LA=
 =dtFD
 -----END PGP SIGNATURE-----

Fix Auth-Type checks in rlm_pap and rlm_chap

They were looking in the wrong list, and the output should not have been an error

Arran Cudbard-Bell at 2019-08-29T01:37:14Z
Files modified:
	* src/modules/rlm_chap/rlm_chap.c
	* src/modules/rlm_pap/rlm_pap.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/1e3a0ae2f32eaa4e7811b6b7c2dd24feace7cd65
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org

 iQIzBAABCgAdFiEE6VbEmJeQrF8361hu/6TVgp+218oFAl1nLEoACgkQ/6TVgp+2
 18qgXBAAlvqw2s2+xVp1JU6yv7djGM1FUHhMstAIDVIUQad2TKB0ztf+6JDXY5QZ
 b9eB/jUaua2YMNnUUTPFy7w/eYrxis9SzIXzWOdUCyMu4fe2hiRhi8VaI4j4iy5/
 s9ZcuS0P3gxLBblQZHqHMk0uxQMFgXjMHK1NNqwjbyY5WYQzNDkF8bmO5++gOiJg
 0W0F6f+oSN8MPCpU6m1lzgup7tGPaV4V9CUm38gDQANAm6oKpHQlK33OYlN6vCLd
 0wTPNPTa94m6gkNmPUya90P4dXZ2ZPQRKZdM8vpeJ9YG9Bfg6scd11pVQCB9B6+H
 NLtttQORjvmy4ojAfYZ207AOeJm8a5VKA6rOZToGY42KFdXfPu0Hv8QvP8h9UeeZ
 d0pNaAL9v9xeVIzxL0D07ZXxswJOGuc2EFUSlx4L571D5NWsDhg/UlCCerl68bdG
 a4Lm0qfib2KWV9Dckp159qMgvT6Eq+wi1Jes38nX+3go1fsV0zZpTDsi5tO0k0EY
 X6+mkA8qEgVNKw43MHWgEg3RNtbHf3YzTo8ud5ijn6/VPj88aoY2HCue+sdRawJV
 mhl0IF1/M84u314Aox+uLF3J1qVXAKcuYizGxTLIXSsTJVabq+EdDzKmdgSP2BWX
 6fkbKwb3daeYeQv+81H1Ht6cWw5Sx8J+07VDQkjaYa814jk80Is=
 =vx2q
 -----END PGP SIGNATURE-----

PAP no longer checks for input password hashes, so we need to work around that in tests that remove &control:Cleartext-Password

Arran Cudbard-Bell at 2019-08-29T01:37:14Z
Files modified:
	* src/tests/keywords/unit_test_module.conf

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/06adf8311b5a7c95227b4f7367f917681f253115
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org

 iQIzBAABCgAdFiEE6VbEmJeQrF8361hu/6TVgp+218oFAl1nLEoACgkQ/6TVgp+2
 18q74RAAqidVpcggFx+AfUATgJ7uvaG5iTkHEBVv9BNvcD5EVmnUpxw6wHjHOWC/
 iWVDPINdn+FmVWGDOibwjEmkFzluP5P7X7rpKxj+astTWT0YtHj9v76qxEdIVJuK
 2HtUSN9B43GP3jLhwS3IxlLD0Zmk7jLdbDgX1dXS5bPvFOkOjhhAgCOiVewoJ3Pz
 AhOGqdfq/7VB3zoaqFWdQ/AcTVh14XJLDLKprhwPlpwSawcApBoNtF/N+o5VjalU
 7tcN+8quDRvXx+plPt387faiPCDL5iWtLW1LmzndjHL93tzjYKvRAt5BVZ5my8JW
 l/FixUP0GC70P09YUo3FlWqChIQdBMYUek+NLuj38mbnjQRUrcP0z0USFVJPUgaa
 ZFjNikyQpqxohrXn0X0HLit2cEaAiWvBxC7EC2JYr3U6Ajj9Tra07De15/vuy0cC
 3sV/Yh71sPPPY4ANWmdz3MadNwMS0hPzLBFTf5/CM5M/ei/S/rWhw1q3oT1Vn6qS
 UyYwyu3m/l04ocrQd2omv7ooTIIGZy7BWAU9WgkAtlN2ODayNsY0LLWl2YtN1HhD
 /4lfn1E8BZaCmQzhSoLE1cCsryUaGWpCDjoL6GpZD/GAP0pcFTCEUTz7OJtBrZDj
 3UVI+r9X4jHdULUx2SnAx1R8RBXWn+1+D7YrEDwg4NDQarFTp54=
 =5imO
 -----END PGP SIGNATURE-----

Password should be const in fr_radius_encode_chap_password

Arran Cudbard-Bell at 2019-08-29T01:37:14Z
Files modified:
	* src/protocols/radius/encode.c
	* src/protocols/radius/radius.h

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/827770c9a3416187d4299f5d6b4072e8e85f7f74
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org

 iQIzBAABCgAdFiEE6VbEmJeQrF8361hu/6TVgp+218oFAl1nLEoACgkQ/6TVgp+2
 18o16hAAg69uhTPtW5VUuT+lb/xmt32Gix4fIO1qBiu9tNLdMJn4Q31l+DtxjHjo
 KkpKgm64TINFBqEI8CZoLpdr9dg5PjSHSHMV1zu+zta3Lw6wIort26XhrjRvg8Dq
 MbeDX9pPTynvCokrrGA5ZN03OPZ12lcyh2HVjd10WlIlDI5t6JnIPJlOVEuraLjl
 c38Wbhwmku2t9Zh9/SbJvoflhwf35P/CVXMGoRw5HByEqduvzUIkw1vtUlvNIeBo
 ODKpgQ8uP21GnBMI1g6c8NXzPRtVfLR3ctAUhotowTaSlaC/miMzS8afOnkjEbzn
 gVv4alhllhSWYknvNwWAiH3t+mVj4ALGkjOKhXn8Iuhf8pgiB0fNaea4DXx83ERt
 7CWWtwpIRPVgL64OUN0LmsUkwUJRgPuJ9wNMdWDHG1O1R0GNiTxJrdfyzs2l3qA5
 S89sXaMo0oW05J0JwnDUHf9osHr6HdEV7GsIigSG7kRGVRuPoSZ54AYxLkUpcJb9
 KFcnrjY9s9oFt649puOUTmsffvLVY4sWFt5zhzX2MXKOOXkQdv9G6yCPQQG81G2V
 XoWvelIRtBpZ/ctWbArQk39xTrMKISLytNGVqHV0NbIky6G5fQnuWVCVq9q9Cgex
 pA/3zy2SvAvoaEDh5+h1inq7hWcFinjkFhcq1C0oLOa6lVZditc=
 =Oyif
 -----END PGP SIGNATURE-----

Provide length of the match in prefix search functions

Arran Cudbard-Bell at 2019-08-29T01:37:14Z
Files modified:
	* src/lib/util/table.c
	* src/lib/util/table.h

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/4dab1f339abcfaa179a4628df322f7d3eb99a9ed
====== 
-- 
This commit summary was generated @2019-08-30T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed).