v3.0.x: rlm_rest and redundant load-balance

[Alan DeKok]

> On Dec 13, 2019, at 12:05 PM, Geaaru <geaaru at gmail.com> wrote:
> 
> Hi,
> i'm trying to use rlm_rest module under redundant load-balance section
> like this:         accounting {
> 		update control {			&REST-HTTP-
> Header = "X-Header: XXXX"		}
> 				redundant-load-balance {		
> 			rest1					rest2	
> 			}         }
> But doesn't work as expected because if the first node (rest1) failed
> the second REST request is sent without REST-HTTP-HEADER defined (in
> this example without X-Header). If rest1  is up&running HTTP request
> contains X-Header correctly.
> I think that the problem is this:
> https://github.com/FreeRADIUS/freeradius-server/blob/v3.0.x/src/modules/rlm_rest/rest.c#L2028
> is there a reason because there attribute is removed instead of simply
> to use it?

  The idea is that the headers apply only to one rest module.  i.e. you may be calling two different rest modules, with different headers.

> So, fr_cursor_current instead of fr_cursor_remove?
> Could it be correct to leave to the user the clean of this attribute?

  Maybe.  For now, it's simple to just re-add the header.

  The rlm_rest module could arguably have an option to remove (or not) the headers.

  Alan DeKok.