Commit report for master branch

The git bot announce at freeradius.org
Sat Dec 21 01:00:03 CET 2019


New activity for FreeRADIUS (the high performance and highly configurable RADIUS server)

======
Fix memory leak in radmin

my_readline() needs radmin_free() to avoid leaks.

Jorge Pereira (via Alan DeKok)@2019-12-20T21:01:38Z
Files modified:
	* src/modules/proto_control/radmin.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/7a35d3a354a3ba7d3c5af55b6248923ed91c4e67
====== 
Add radmin tests for 'show profile'

Jorge Pereira (via Alan DeKok)@2019-12-20T17:36:53Z
Files modified:
	* .travis.yml
	* src/tests/radmin/all.mk
	* src/tests/radmin/set-profile-status-yes.out
	* src/tests/radmin/set-profile-status-yes.txt
	* src/tests/radmin/show-profile-status.out
	* src/tests/radmin/show-profile-status.txt

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/c6bf95fbf24095671db84ae1e97eeceb6dee29b7
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl39A2oACgkQfQ55zXdi
 Hs24Dgf+KRBQ4CyEsuCa4vkW7f/L0bQBcttwusfeYHLoI/YuGXuiKs0px3DcjaM/
 fXwWAPj6YxW+ALs/8t8st0wPBaaxviYWyooUSwQA6vne6uZHkBNmYN7VyMStrqMU
 6Wv1Uv3Pzm/yVtKkVHxl4+I+iRtbmX1x5DZRt/9B2sFQedT6jRCfh7La8cskuHBO
 GAKj6c8UuwDHE74x7ZOZMTGKAY7V68TuDhRsZgrHgF7uEBfk8eiF4+fQXL2nOrNl
 Ggr4a16fifD6vw7d9H5N8AYRohLtC0FqXLDMt04myjmCJbDHP0qbw/2oo0AYVimd
 +KgCv9QH46knb0hcuzZHdjfx6fHRkQ==
 =ivye
 -----END PGP SIGNATURE-----

variable is unused

Alan T. DeKok at 2019-12-20T17:22:46Z
Files modified:
	* src/lib/io/worker.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/14bbb76c2b3062d90ba3d1fe4a9224f9578cb453
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl38/AwACgkQfQ55zXdi
 Hs1ARgf/c4KMHhXut6TCQ+f/RjoiNpnMvBlYCF6uo6zcWDBTxOkRJdFXGKEDQ+Ct
 9YJXH1YcF0Gr0annVC6KqOi+fT+3uQ/jdT8pRBTtiobhgOXRG8vbssTN0ebLz9kW
 dimo/xbiLklENQP2oj3NXBr3VgE7rx+OUMBI47AYN3JnqpkwG6V4cMmO4GcwJr4U
 udf6DKN6rbZ/2P82Zl8G6fVM8lkXJnkedLrssSOOGcui+FUit5AdDSXBgnLiCkFt
 8IPYtDLLfTbePo7fAGWbrZIPq9LLLlVOoWn+K8beIxr5vlIDaX/Gji6Ps+PZBQ4S
 bezGQ8cmG/7A563LM1KRamgShdD64w==
 =C/Lo
 -----END PGP SIGNATURE-----

add post-event only for single-threaded mode

Alan T. DeKok at 2019-12-20T16:51:14Z
Files modified:
	* src/lib/io/schedule.c
	* src/lib/io/worker.c
	* src/lib/io/worker.h

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/7af450322639902894840aedee3d901e7c0159d8
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl38+qgACgkQfQ55zXdi
 Hs2ezgf/eoMHI9LH/KglOJawup7gNl3JOM00TtvgbxaTa+yPIrx02GXvX3JS5Be+
 bzlUZ/1shF+Gc9lC/JJE0xH0Oz+QSsNfvNR4czD7a/bO8ksJaf+KcqcX/7PvTDKs
 rMU5TNUOJsy2j6c6RtFiNj/2yA5y4uR66714eHHrIsL4dxiTrhQXZb5p0BaxuUkG
 HF0u4R5qhvnjiXU24Q4QWEzQthRn91S9J0RT4q0zOIQH7EXBM9vuoip2gMMEfGp0
 YxqGOVFDeDg5yyG5dNXNYooG8hy/RM4mmmdMZi6Kk+juLOkKQvInyB/tDqTUbfOg
 yT/HnBwUggrmCTI99EjNLwQnrr1mFQ==
 =4q+I
 -----END PGP SIGNATURE-----

don't spam the output with 1000's of similar debug messages

Alan T. DeKok at 2019-12-20T16:45:16Z
Files modified:
	* src/lib/io/worker.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/0c7f5d2a54a931f43c7ccfefeefede99b35452ca
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl388csACgkQfQ55zXdi
 Hs14owf/a3paR1nYxq+HJZ93zIc9WyXHYKLtBLo+FnePVTjpMt1tr77J1aYbULjl
 Pld36jWKux4+WOGjAY2lhYgH6HrJckkFZtPL/TUVdu0IH7rwuKZaL2S5JbJG+Awk
 qWhrHv7EwywExMosH39Hu58lR1e8VPqe4uMtdVUPmMwrWFxY61p3ys+MpcPHufek
 mv92q7rLRd/vBj7xPU8ykvGMC0C7LkmOTCOrlBdqKST4nR9dYYo4t/7XEZudJwQK
 aITg2it2h1PnQuv8zvxLuN3/ycnnnKMwTD0L+PnJcRxPTii9l6xsVWehB0kl6UtN
 z8dr7aCRNKr2/PAw8tmFLlaNaN+5WA==
 =6DtS
 -----END PGP SIGNATURE-----

whitespace

Alan T. DeKok at 2019-12-20T16:07:26Z
Files modified:
	* src/lib/io/worker.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/2ff24c475b87e88a28605b25457f149012e922c8
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl388RsACgkQfQ55zXdi
 Hs0LWwf/eUW2BhYj+PFYsZ0Wvd2LmJQwKo1p2FIS60NnqGJ7zHrvKAAUKa6Uf+YE
 LIOpn5mzL2TXaENdJYc+v/qgi9CNbxdC1+Ko8iFIPSK3884bGkpQ9WZIK+aHhSfA
 IDVqsscbouh7zDW/O60uQ1RmJkUnIsAAZKS0djLZSXo3VDuYufr7uuxggqwJBjmv
 orkbbeCjnMXTu+9bC5CGRAGHkSJUqywhGjGZzhobyeqYKLW68KgSAznK/phymPhL
 dfvFHTiYDo1Y6zKeUDQoR+r8gzXYmCz+hpHwFP4HbwO6EeQv59ol62P3IqgmIjTN
 npVkEiBmzy421ZfLMxrn0NBTH1EVkA==
 =C09p
 -----END PGP SIGNATURE-----

move "run request" to the main worker loop

and out of the post_event handler.

Alan T. DeKok at 2019-12-20T16:04:25Z
Files modified:
	* src/lib/io/worker.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a72f157679a13693b5bb9c0f27fc87bdfa2d2ccc
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl3878oACgkQfQ55zXdi
 Hs1xAQf+PBp5l65mCl1ztk66V8rRVO4Vc1g/KrEFEwgu622pIrPNKFEeKaveI1Ck
 GAUXewSMkC0sfTI/fMl4DrE1/4k1282lq4DPVx8tnRD8rOi+IUTlO7fVEoCRVEiL
 xhLFNJYjPH63Z2LwBbREL4fbu33xKjmcIL/qwsVaz5j7hbDByX6H0x2X7FvRQHUu
 9nbeq75B4d+fmrLPA8RNvC4S4uJQgvdKyCm5XXudEcRUMmPDua/cbKP5V4bigVST
 qTGap3T7IGmxIFYvxcXnbqd66uHBEP2W055IgRdjc2XS8S+DSmmggvG1CizKh3xs
 wy4Syj1Jvbgm5B8Wf9Z8Vw2wBceTwg==
 =XuFF
 -----END PGP SIGNATURE-----

get rid of "to_decode" heap.

Just immediately decode packets, and put them into the runnable queue.

Alan T. DeKok at 2019-12-20T15:58:43Z
Files modified:
	* src/lib/io/worker.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/4baeed489c82f806e58b4428e459f04b1f5258b2
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl387oMACgkQfQ55zXdi
 Hs0KPggAhgELbkjdUJVPXiGbFQZSXXF85QhDGKUFL4Q217SYhyNOyKT/VPhB584n
 bOlj3ctPPplqUxcZq/1eMoFK5uU970sJ2fHRW7ITMRoMtuI3yUD+m9Ep9jdBQN0M
 H1q+mBBcmZlZPDlibPUCgD+7JUUuDIezN3yOvJEGN71JTim4Q3eAXGidsX/y1t+D
 9lnPrFvLvgfiWcophbNmoVQXY4e56mjtKqxO23zVfk5Ui3u2KBOhJqXCFuUJpRSJ
 tIYTTJjL7d5EEK1nzU5fIUxf6Y1Mr5eLA6Y+CXODaplDCN6WAsc73V5kmUZChFpM
 F+bs1FlcNT9WPb4n+h5kn0IkhzLSgA==
 =ooA0
 -----END PGP SIGNATURE-----

remove 'localized' heap.

If the worker is busy, it's not servicing ANY packets. So we don't
need this heap.

Alan T. DeKok at 2019-12-20T15:53:10Z
Files modified:
	* src/lib/io/worker.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/2b27d30835ae415df4695c5660b1f97e4c9ee931
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl38zWQACgkQfQ55zXdi
 Hs0pqggAoxhM019w1Nr5o/RMyDCUTcm3YnDKzdoVHi8/giISrfzMopfqEwSk/7Rp
 3X3xmyNo7nP7n7J19cCmOegfqo3UbtoOhFGrNAHnqQNdJr/8CiNrmHLRFDAjpgRp
 vWLkcUUbxxkTfSp4POSnDCW7utCaA17knojoI+YhhgNBVtCvHayTNPfE3BiHLJeE
 WxmFgxMMP4a3/OFXPachnW41cOuhe4KtnUwF1Imwzc3GZ2Kgqu2Q7mZfAJyoHqS0
 dvZJUsvo69Kn6j2FsSprL8A7wHL6Q3F6aEzRu4P0Pg3w8XGWoBHdDaD9VNM0uoSG
 wD+wIgqqIloZnGEP7ZqDgq5j2V9kjA==
 =TkgL
 -----END PGP SIGNATURE-----

Better fixes.  Helps with #3219

Alan T. DeKok at 2019-12-20T13:32:12Z
Files modified:
	* src/bin/radmin.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/750951720c45600eed4b6d8df8b26cc824625a7d
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl38zDsACgkQfQ55zXdi
 Hs39MQgAk+cIpPRgA8nRQRyGPtab0TONSrT4bWNCrbEIboyaq2y0WQP5RYz5mFYH
 g8W15yc0WKdV8OIi7sx+ViVFdQuEYIjvxGk4NasKYCv6Fm/lL4HT5coUmdzhAXgq
 ammk0IK/D+NYVf8zRATn9FuczVJBsYF0uwZbbjA8MvMsR8I3CilYKTm69Qwx6kTD
 8oi63x9M4SJRGvy8t83KEXk0KN3UfrupWqQVSt37Bip7zWAMfw+8EXj7/trqepxU
 QAQTKzuD5+ptoAxEmj+VzNR9B9a6UvGFbVLbSMro3fnIVzDrfoxpZuzMUfWYaAN6
 abnt9uec0+sluKfpCdv7F80emjWdRA==
 =5iHN
 -----END PGP SIGNATURE-----

add "show profile", and don't allow "profile on" multiple times

Alan T. DeKok at 2019-12-20T13:27:23Z
Files modified:
	* src/bin/radmin.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/f4dbffe5329b879d5dafc7c74d1151fb2c84890a
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl38zDoACgkQfQ55zXdi
 Hs18QQf9GNdT91/P5x+hVFm7DfRQPlYhwnNPkROeSinIzOVWyvu4R1WHpeH+NByy
 YIhfbm/bvQaniUpZ9PtDX5+Xa1MmsF8gLUgvV7hPh3DeXntpbnrDwFVZRUV4JrYp
 NXAAYC0hPGc4iECvXCRsIAnw1OfnG586gt7mMP08gESkv/bFTaY2Ow3jcpxXezXY
 3OUH4wnqbIfjXhP4eqf0lBKHxkqefMJTfddmHY3XesmLuV4/P5qlg3KjFbWvSWER
 oOy4m18fN7flL4E6XwhJC6n1hFVPveQf9eTqCLmhAHgrE5ZVYQKBBqNu4p6kwjMu
 CHu4Q3abmeaKjXmeOP+3xKz7gsIRzg==
 =OIqP
 -----END PGP SIGNATURE-----

avoid cursors where they're not necessary

Alan T. DeKok at 2019-12-20T13:27:22Z
Files modified:
	* src/lib/util/pair.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/7d2f2b5b821adaf6ef903f1d36080d2f0e8de14f
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJd/C0fCRBK7hj4Ov3rIwAAdHIIAK9bzaHM5czbqUsB1x1j6cLc
 6pOPqnKxdSeEGBqz05onxRxhe6M7QZJsgGTKc1twg4LM+BgeSrQLHJ3/c+bV+5Pr
 UkDNlw06eyyoRk4EuYgYYZwYBVs1p2NPN5mEYkSp9FZS96A6xD+KDMi2hIsvd0F4
 DL/r7Z91ItNgEvMjilpRU+1iESk3K4FPf9VPOeM7vYH8kMRUh3kdwOLw11Ws52Od
 YbTlR8LSjdb5Ygou1vmyt2adWec4FT4UP/r5ttlp/iaulhxH2B1yz24Bsh/xXWVw
 8TpimGoetl00t2P7j6U2LJz9MkRDidcQ1GdveqbuBlz1FybQHqbBMTKpW10leM0=
 =IF2R
 -----END PGP SIGNATURE-----
 

Don't hardcode the src ip address

The DHCPv4 code has multiple ways of discovering the correct src IP.  Hardcoding the src IP to 127.0.0.1 means sending responses will fail will obscure errors, which is frustrating.

The server works out-of-the-box biding to '*'.

Arran Cudbard-Bell (via GitHub)@2019-12-20T02:08:31Z
Files modified:
	* raddb/sites-available/dhcp

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/054095b5310d1c7b0994565ddb1d9eda2b45b435
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCgAdFiEE6VbEmJeQrF8361hu/6TVgp+218oFAl38GZoACgkQ/6TVgp+2
 18r83RAAkto2fv1TgLaWkRQz4i5TA7zhJ33raj7sDlYy0qzVTjD247Re0cHkPqHu
 LOiTqdypAyeJ4BORfA1VAkN4RuXUXIX/RftlPWba7AAOtyvN1NHFxY1zRw2ZIryk
 oBTf2nkGqhclV0+KUc4vwE0+7LhXltQ1Narcy27ohuGi2gnQLuP0FwV9+IEqBm92
 iHS6Y53UMhxZVy/hdn9Dqy9WEvAybX1CWITAQMEd8Uacn2LHGmQwCm+l7Wj3M2D7
 lxmdxERMm23gyvqAjDdPSHoDWz4a7MbpQn5uULEVJECuVf4qQWIAmetUJmpzGnrg
 CxhXBxaiHAPqgZ0nLSIeKM2ZSfhkm0cdT4BB8ZpFDu7FyajkKu8PY6dfz4IILfmU
 AilWp/PHc8smMZCQHGOZjMqoOtSvCynDuR5zpgZnwPzm+mPzm2piCqx+aqnmV4AX
 FDsR7LHopnS1JspxeWDWJ5l9ywr28buvw6NlVhh6vvCdX80+FzRsstTQ6UZ+Vxfx
 kTyreLJpKR/zAWrjue6SopEoo8eT/3VCVv0OfPty4nsOm4wl8uXh0UBo36aJzEST
 VkzEK7LDzNV8JQGWADXGzqmoFyH+3RcoBBuE3ZvYcyCKx/pkzbOJ/MjtspCHKeN6
 Zcy3i0L+mFZPnYNPgfA8z/pCbhSRQs5fPG5L/fKhlf1DofdnSWM=
 =G2xc
 -----END PGP SIGNATURE-----

Quiet compiler

Arran Cudbard-Bell at 2019-12-20T00:45:14Z
Files modified:
	* src/lib/eap_aka_sim/state_machine.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/83e33bbff1584ae36577c3ad9b0980b1c495c4bd
====== 
-- 
This commit summary was generated @2019-12-21T00:00:03Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed).


More information about the Freeradius-Devel mailing list