Commit report for master branch

Tue Jul 16 02:00:02 CEST 2019

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server)

======
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl0sJ78ACgkQfQ55zXdi
 Hs1BdQf+Jzjh4XKkuvpkHjxKWbkP7bgwBeatS+dVPGvWNs9Ch8yiUbylgh/7TD28
 ndClX47EsBNqCM78KtO/zbdKKko5Spmng5gU/SvnWCfLh7MstAvkhu85E7VkxSjm
 BHeR/jpS4bi/hLEM0BS/0NoxXZ2WG66Iz77FrRH4WDTb65mYUz5xFIXk0IyiFP7D
 Q0hHz1+7kDBrxM9PhqKwzrtd2lPhd/FEJL8UznW4bdski2sVKPgf7+kzqPGbJc6n
 3XE833EMVM0RAjW/qHNTnBfU0K7z9wIVrCr64mDzjPrMuKDbibCzTH/Ix9+wZM6t
 xX8pTCqg1rcGM/tNGVbrQyULMP8yBg==
 =iyfb
 -----END PGP SIGNATURE-----

we're not LDAP

Alan T. DeKok at 2019-07-15T07:14:07Z
Files modified:
	* src/modules/rlm_csv/rlm_csv.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/25c6ba64fc98a745babaec9555e1ef458f19cf70
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQIzBAABCAAdFiEE6VbEmJeQrF8361hu/6TVgp+218oFAl0sDxYACgkQ/6TVgp+2
 18rlLxAAkKLUQwRdOSt1k6mtn7F20aBY+ft+MnfG0wBTXQxCyqOQvHoz9jgP9v1r
 xcTYHde3YEqS967srcaTtzGFTqYk34ZZcnKFidsr9W4onYnt20HR+3S4ueoOCadt
 OVpAJLiN5d+gbd9PwogftCOKxXI+Jo7NBURWXcGEh1QitEeHeihsK/NqVjIRXVL5
 ccznv8MAMyFDcLZ8aWEdiHJPh44snxN62DCrqoeaCbsFg2+bGWWSmHzV7Lufr9c5
 +N7RB3/I1Zqf14ccPDVNEUfJIRfr9LjJlVbndgh3X0MoalhJx0RZZz6ucq3sp1v8
 xMWtxROJzH9CTmosqm8jZWsPzaRlVkOsjT4EWx9jgdhiuCF4oSYLV8BUhi3QLRs1
 EWzz6m/BPqtGPOJOiqyREISj8KSLnPGOQgE3m2boXewERns3hUSFXV6cSNQH4fS/
 8JfJZpxASNbrSUwMg5N3cyKJcxWGRBAXR5slbJsYToQuiyIhDoHfFRslypyxx2GP
 A8wvCs4XG3TZE9HsdTLbrx/tl9xxXlYdBIRO15HWK8vrchPpHel/kkdXiwe6srXE
 7tkmL5KWG/ln0EUqfgTB/LtQRthb+JKa/CQgv4V23fbEX1fk7xeGducMC6gLp9D0
 ucbImrV+Ec5ZcElLb+iDBbwgKJ6LaZag1pCWFjhg6JuUvm8H564=
 =IjMZ
 -----END PGP SIGNATURE-----

Use log lvl macros in more places and remove fr_log_fp in more places

Arran Cudbard-Bell at 2019-07-15T05:28:54Z
Files modified:
	* src/bin/radclient.c
	* src/bin/radiusd.c
	* src/bin/radsniff.c
	* src/bin/radsnmp.c
	* src/bin/unit_test_attribute.c
	* src/bin/unit_test_module.c
	* src/lib/server/log.h
	* src/lib/sim/crypto.c
	* src/lib/sim/id.c
	* src/lib/sim/milenage.c
	* src/lib/util/log.c
	* src/lib/util/log.h
	* src/lib/util/proto.c
	* src/modules/proto_dhcpv4/dhcpclient.c
	* src/modules/proto_ldap_sync/sync_touch.c
	* src/modules/proto_radius/proto_radius.c
	* src/modules/rlm_radius/rlm_radius_udp.c
	* src/protocols/radius/decode.c
	* src/protocols/radius/list.c
	* src/protocols/radius/list.h
	* src/protocols/radius/packet.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/9c5104a02f7fc8f2e08d85123ffe87c63d5aa959
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQIzBAABCAAdFiEE6VbEmJeQrF8361hu/6TVgp+218oFAl0sDxYACgkQ/6TVgp+2
 18p3ww/9EdF8Vitk2R2WPBGXwWziOgBog9XUTjTYgY0bOIXIKjch41pViEzIao4Q
 MuhBsTqRl0ffbcspT4aMCucehOXGS+DDZjt6Kh6xdIAr3kGP/JCVqIi5q64yhYw4
 3UnrXerfYXXGkNEaFJC3zBuie/+8SogAwAb17/G6wcmloZb9964/jXo6uE7/98iX
 vsAkbwg5M/pKk6e74WkNaEUmWasaXewUfvPz7uSd/+6I6UJKGygtKmBv3g1kyLrN
 m8+b/FYI2SLrg+FrsSwZD1i+MU0rAcC7bLpXWYjqA9o8Vf9pZKKWA4/d3x0xyTI4
 arbLGJPOoFA9tVyPO1n/EvwM4W9Wirc6hPxalbJUgo1nC9P7EK1v6GNnCNLcd622
 Pu5lR+5zXh2j1OmobSPoZM4+Of7H5mTctwlUZ40urtXifzwlrXPdgZ17sR9igZgt
 +S6GQZMaA3en8xhM94+BUH/O7uFENBxSKFawT8YrdDA1CIFJogSmmnFtAvIU1kju
 GWAweIv0sluDQcgBuV1GvH2ATDfbNpQKcQD46mFb2OG+zp6dThmjCFI7ULUJ1PhK
 AbmqUWDKRo2zzuB5+TeX4qVM8vfX7ZHxJv5eGpx3AeFbJc5SfMioEuG/koyhVRad
 HNDoFCrazJ8H+MvcQ/izFuJ5/GEMbWYcYzLbieYNF94gcRRJDlY=
 =Mt64
 -----END PGP SIGNATURE-----

Respect the taint value of boxes being fed to logging functions

i.e. not-tainted boxes don't get escaped

Arran Cudbard-Bell at 2019-07-15T05:28:54Z
Files modified:
	* src/lib/util/print.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/012865619f8001b0903fa129ac44cff22e91fadd
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl0rhXYACgkQfQ55zXdi
 Hs2fVAgAnpNsXrOvNfV0lV3UXo09L06iU3U6SLHEo9hD+TCQn6f16PuXl+/ReGyM
 hjCisRtK9QxP4Rlg+FgARC2iXElo7h6FUsvU08nzE4RZnfUP6MPFzJmagzdVuQGj
 HmHNqeEa95fkHiOgD0tODeBUmrxtlPSp2MV8M+phTV4HxTw4lbNCatDTdmJR8kiM
 UT88olsXUKz2VizOWG0Xj3HvG+BGznWE85NXZpbKqm6TTUTTOBiSm+q0ncpICpEH
 bfft/qTWR+M6RYaDOKe/59QiLjFfaEEYgDRWQ9T+LnUHTrsjLC07Bw32jEMGtecd
 LkJmeFcZ/UZHlcUWngtV4jznFemT8g==
 =5bOT
 -----END PGP SIGNATURE-----

allow filter operators, too

Alan T. DeKok at 2019-07-14T19:41:37Z
Files modified:
	* src/modules/rlm_csv/rlm_csv.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/8e93cf9bdd0625ff06a3ce7f543bf00654a173cb
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl0reMYACgkQfQ55zXdi
 Hs13gAf8DeHGAcC+p6ATVj3ZfHRu7zKp0V+HjznHO7mDIYo/cH/usYGuWM7W5wZ2
 L24Z5wqNYyh5BcwiR32S9C4sR5Qd0nyymx0sfg3N3IrixAhY+gbmslC5eXUi5qe+
 qjKSrP+j+uLnHa7xLHKKa3soyfHz3WnNmntWDmrRz0teKDoD8QleveK0n+gwmbrh
 wLdpiiqr2eYdQ8SNoEdIT+PPKWQ1CpIKqXtF5XOQvozgSQTcTlLoCWVTStJftkDe
 ao34T+hu/aDGoSbxJll1SHxwaFutRBz1XFzYClmTLweG7w5joGQuwYsdiWqg/c8z
 nw+ogOkLggm8nw3FFcxCIZ2IVsT7Lg==
 =/V10
 -----END PGP SIGNATURE-----

allow prefix, too

Alan T. DeKok at 2019-07-14T18:47:31Z
Files modified:
	* src/modules/rlm_csv/rlm_csv.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a83a5c6108131a0a6a1d06ed05a47b47b32a4316
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl0rco0ACgkQfQ55zXdi
 Hs2DfAf9GvhYV967cjNJ718A0xa3XZxHhsBYRVgo0d7RvYwlVvADaRTGAA9yo7so
 S3iyWXQ1lzEQ1jIpmuhdA8KHwA3WPfThqfFbpwYCZhJ/3OVJFmWQ6GRBs+V9h7Ck
 PEf5QaRHv5bWcvJ6mWnHJUyoAYlk5fqWnJQfLl2Rt0Y5y73cqg6FUy+o5/9nF9RN
 IQLE84zUoXFZyQ9YbiLp5htkoaUBVJEIFPJv7ueYFcoOSzCCLFF7l5Jbake71Kg6
 1eCm0Spy7gqIcWqww4yfbpku3JEcG49RGAJ4mSYnXfv0DiTjvA5reSMfTOPC6yb4
 s7ho5uSlNSC624qNvp+PSZxHwdJasw==
 =ERJW
 -----END PGP SIGNATURE-----

use concat only for octets / string

Alan T. DeKok at 2019-07-14T18:20:54Z
Files modified:
	* src/modules/rlm_csv/rlm_csv.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/3a6780a32878214f9dc62218136851bcbd8147af
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl0rcgkACgkQfQ55zXdi
 Hs16iwf/UceYHR2YmtUmwqHGAMm6VGImqP8jHSSNqDJ8BrPJM4W9fmmE6lpLJ5u6
 8e6pHc4M/vBQyPYtX8ZiZtTZiKT8z/WKqMPQpiH6RnlBn+wxMmt+cbPAmBR+iPTm
 dyN47eW3e/zRmHNvMrtNFq0ZYbMP8GioADmZENVQGQHWSGHqxdMx13xI4N7hRdSs
 crgPK57lEy16MFrsN7uLw1WFP0Hiu/PAQ2O2SGkLzVgknRlC4++BP+BCAevO6qx+
 XFUBZb4wlJMLw5KhBPUC1IX6jtYJVu3+87ggPZVuzJsLJh2PIP1LDdh9Ds8CvMQg
 O3ZxBX2vAKRbeWeuBcYZjw/U5S8yeg==
 =IrRz
 -----END PGP SIGNATURE-----

use MEM instead of explicit checks

Alan T. DeKok at 2019-07-14T18:18:39Z
Files modified:
	* src/modules/rlm_csv/rlm_csv.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/3f4bba5f473885eb6c2e8d53e1186c1e5d2d7276
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl0rcawACgkQfQ55zXdi
 Hs3tkQf/bqRIiqCoPse516mWQmuZR2j/4lFzrobwsdRoqpYqGijsZ+deU/4V8bFx
 X6U7Q6yc6S4Qobeqdp0B4OC9wduQc+DvJUiwRheAHirU5dlrZFYdPNGFfC2zOOvH
 z1xtozjiknsKVzSNGrb1ibbY5YLOZhOlKpTVf/CEhO0zr2bFNNsizHqFT4HGQAS7
 ypraGIMzCaJ2jjx2QhFGWugj7wTrmw3v21cfc9sPPUVmXL+O/OWtSnKvdgEFiUaP
 BGCyiAxj+ikEk4yKPtC4zr8lQkYS/B6v5Cs2vO/6XDHZdIPLKC8QeNocuC1cXY7+
 MqmsWNDyfFHWDOs5Et25nUmPqFiADA==
 =jii7
 -----END PGP SIGNATURE-----

use ADDR not PREFIX

because PREFIX is really only for RADIUS packets.

Alan T. DeKok at 2019-07-14T18:17:02Z
Files modified:
	* src/modules/rlm_csv/rlm_csv.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/7e3d60893fdc30215e5d8260c83a9fdd15758947
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl0p/lAACgkQfQ55zXdi
 Hs0lHQf/fQfbP1jEVL4vnV/8SxL42dIzSVKTnSlocn7Ood7pxFwtbrvPH23DzFm9
 LAlTLogzu/QYJVlqeVra6B5FeWdYJWAKaD0NZjtudaX4J9Re82hGw5dP0htmmvLI
 jO52uwUDpJcuPTTarL2nOV7AFOGF3Ssb2bzhymIVzN4d5Ym7Mx6C6mHxPotwwslr
 0cDtky6dgDIL7SlIYd0aXMj3ehrvLQG9HVhTT2dkGFLjxxSKttNRiTpU3iR/Yz2T
 Wl4aBh5WKL/KSOxrlu1V5c3VY+PYyeIVX455h1LWJKDBI4PddfvuX5LJmklDmqua
 ZNnwpkCnOf5xCENd0Cy24rBEpt9X9Q==
 =D//X
 -----END PGP SIGNATURE-----

update functionality, docs, and tests

the `csv` module can now be used in-line.

Next step, adding support for "extra" fields, as with /etc/group
When that's done, we can get rid of rlm_passwd.  Finally.

Alan T. DeKok at 2019-07-13T15:52:00Z
Files modified:
	* raddb/mods-available/csv
	* src/modules/rlm_csv/rlm_csv.c
	* src/tests/keywords/unit_test_module.conf

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/619dfee53591391e70db9ab89dd478c713db9cfc
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl0p+psACgkQfQ55zXdi
 Hs0cXQgAgdirIo5TtRbx3q9svc99M6jCiKJdR9HlK+9FX5O2DFbI0ts9MGyOuCml
 /ZNMWGDfjUuNk4IxPaJMdpnrdkgKacIfAbvQZ2gN4nCHYZnA0G1tzRJYtKapMJia
 qFs/YABZu7dqyvP7OwReVaGPIoEA2jkqZY9pZhy1UGs1LmJbScUxqQdNbGJ85zPD
 1IkGwzM8tKWcdVC22XScyEtMtHL1aeUwOfBJREyG7RNeAbKxJOB3db41XmEuAHF7
 goS5yCEtkg1AMCjJHPsdMW7B+JVsZhn4Gue8aazuTYr4VbG0nC6VXojL7FC5x0U3
 4ozPp3fgiYun6rGY7kER0pexM8CzmA==
 =sB5d
 -----END PGP SIGNATURE-----

use input names for lookups

Alan T. DeKok at 2019-07-13T15:36:51Z
Files modified:
	* src/lib/server/module.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a4dd7d6dfc9c406297287308750f32c99c3f292a
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl0p8GsACgkQfQ55zXdi
 Hs2BDQf+PRTZ9RpsZhfJK/TFdXwF6jhznjMT1dS1JIW+tuBGQuvOGODhf4kToN4R
 1tZhe+xx0cdcv8LkIPSR90YnSMfkJNC1mVUG7glL2sRz5nn960ai+VUT2gXGsm4D
 Y8d3VLziDoodRSAZf3UUxjL193IOxND32eHYZJYRZiGuLaSeM4V5Hs4Nq4gfG4vU
 sm4ef90gdCW4shxIxX01JTKUlvU2oTaKktrwEAh2SJhHA4OQ8vOr4EON6FK6hG9l
 ZG7uDMPbpkjJidmoTOYtiSwCEKY+GmNKwZdwCX0tDeLz7UpXnbulnJg6HRdD8yi/
 Dl4bXZi3HfLR11F00EdSnQH8DxMPiw==
 =Lvu9
 -----END PGP SIGNATURE-----

goto exit on success, not error

Alan T. DeKok at 2019-07-13T14:53:25Z
Files modified:
	* src/modules/proto_control/radmin.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/da786cbc4c440ae3ee3eba90a126371e88fa8948
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl0priYACgkQfQ55zXdi
 Hs2FAgf/ezDmdOfqx+1WJdFDKFMT0gXJ33LmRdjU0PFLxIswDkSwH5F4RSlC9uzO
 EPENIwEpr8IFOdoT1Y5Y1+P4MLxkbf7hrbve6c7qWzkvrjr7v0fwbzH+oIU05Al/
 rgqD+WRh4rASvI+A6yOwJ3gauIv5SL0Aetsz2N5tYx5tuYT7CIjHxBdppccLjG9D
 3WAkTaRhp+V9IKwmWRTqF1uYwghClDGlQnZdM341VyE0ZftTjN52JqD23im6ji8I
 gP0KSQzghj4q8QWNT5GrqpTA+J5lSkMzaK3I9XiApccr0TdQghNHjF7n2zaj99RF
 ZEB8teccPs3+bcNowIpLLFn85GHIQg==
 =Ifn4
 -----END PGP SIGNATURE-----

doxygen

Alan T. DeKok at 2019-07-13T10:10:42Z
Files modified:
	* src/lib/util/dict.c
	* src/lib/util/pair.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/0b105796e2ee48b04b11e703627c866ad2517b2d
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl0pi7kACgkQfQ55zXdi
 Hs3Rrgf/c0sMxhBQzgqs4xEauy2If50KnERLVfoeYysUg8LHxN/5eT4L4zZ8eLOo
 ETKPyjYBK1IzenVJu5MX2HnoKuaL3rv05d5UiSY1RQP9LnK+OKuHgnwBtkEtDeOo
 BsWw322bnoWB7kiG7fYdNLmzTMCk573l1+z+T9ivX7UKG1QsAfSUCpR19QHUkny3
 brSJ4vxDPvqnY/RqvFJ4lD74IB6iXaKVumTJ0rDTwTLKFrOWj9nj5m7cOxud69xk
 B59pwYdVGZd/I/A1viAmmi7mDV1Ed1sDuagQTfc7pLC7W3geMlt32OeyEeJLsGNP
 8nAoJVlo7s4bCvn0YHEJjTWihD/A5Q==
 =W1kK
 -----END PGP SIGNATURE-----

print packets as decoded hex, not as one large hex blob

Alan T. DeKok at 2019-07-13T07:43:42Z
Files modified:
	* src/protocols/radius/packet.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a2043a8c008267accf28a145d263508857517b79
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl0phhkACgkQfQ55zXdi
 Hs1rOAf+JEUcuV49s5WL+/e4CF+/X7968NDSdC12z+oomzbq+OPuCWaQReidFmn6
 1tjBytYdwfIOfJLwQQfMIwQ0TL5N0tLhfdgGMiM40L6Hv9hzUUi8ws04EYMjQmuF
 nDYzXGaLSgvXAa0hayLkfbct8QBuntB7leQqMUsYk7Vo+Lz8M08i9t+YJyqwgyAk
 +GYceot6QMPrdjVs9S96Dgv3QssqKVSeEEyNzeiKZQXvGT0Y05KJy54dmyOCEPcJ
 59oyW+F13ZqHMEfzHT1VKxu1oQc5dwnRdYVPpZxs1Nps+cECRfkEWKHkLhQdeyi+
 nOyKdcy/mwyKlHBXRPHkvm8z/Qq7ng==
 =9iGa
 -----END PGP SIGNATURE-----

fix debug output

Alan T. DeKok at 2019-07-13T07:19:49Z
Files modified:
	* src/protocols/radius/encode.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/c273ab68c3d2746f2d85dbfe57bd11ba8e8f5a8e
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl0pg14ACgkQfQ55zXdi
 Hs3LOgf8D8R0xTzOeN/QapBYqidvaP5TlMxjEricY5KsMa+6htVlPQbnVG25dbje
 NaIhMqTMvel31Ab3zdpAoSRlwWQAHfCFl+oOhnczB1JN99nhc0gB3x2I+WFI3qsJ
 AG0lJhlv31eeqSJDI8+7CxSix18eieeM5gIhdm9KBICQW/bMBHUqiUhBs/WVHaPF
 SRqaDflPBSp1DSyxutSQA3W9V7ZnOZo4SgSBqChPp9EpThTqX6JD9zzg6DHDSa3i
 rD4iAKv91jZ+g9r2QY8It1iMVk1woigbv/7HPTdW0JzChpEFBIDFdz7cwrjWQK6j
 TyZ+C/YooV7xcX8RTEkI0hmrZ7nTqw==
 =bMQy
 -----END PGP SIGNATURE-----

minor cleanups

Alan T. DeKok at 2019-07-13T07:08:14Z
Files modified:
	* src/modules/proto_control/radmin.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/eb82caffe906d473482d9eff48196fef8df53280
====== 
-- 
This commit summary was generated @2019-07-16T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed).