Commit report for master branch

Wed Mar 11 01:00:03 CET 2020

New activity for FreeRADIUS (the high performance and highly configurable RADIUS server)

======
Fix typo

Jorge Pereira (via Alan DeKok)@2020-03-10T23:27:17Z
Files modified:
	* raddb/mods-available/radius

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/29b56af63b2ddda7493deee449903d7965f04e03
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl5n71MACgkQfQ55zXdi
 Hs2owAgAh3Ujp5Dexcg9WMLcQpvnhi87KoOAeNpl6FdTjBuIVJBzboCATRsLIVg/
 DnsdEexJB07HR9TYI65PkIyshsvxNWmcpbuppJHaXeG0gFAekzvP4zEFiwRAZNy8
 TSS4EJWPlzzRJFe/7CmuXjEIIRk/6cCNbS5gMNuJPxTcbHaMYkza8BLGln3MVsP7
 PQ/7QVm7cxkbzgXtxRcqtu5PLeIBAsZ4MKpUm6ByB/SFtm8PqSH83/IO9K/AAM9d
 +WjbqNTXADB0Ol9MpcvZAgUhHGZmzVH7cy4VWxekzQot5/8PbPu73jAGylQdCgpB
 Pk0VQuexbpaVxP7L2qhrRKojjUesRA==
 =tlG1
 -----END PGP SIGNATURE-----

typo

Alan T. DeKok at 2020-03-10T19:49:37Z
Files modified:
	* src/modules/rlm_radius/test_plan.adoc

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/76c1de721392b818e50480e4c473330b4051f02d
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl5n7iIACgkQfQ55zXdi
 Hs3FOAf8Dhkxz9ndv++yCFjyqoNLJuDkPiHHTrbBCREXi2VUfzpssMZbKqtHcgF4
 dpn4EpyPzZrKgUBu4IaQvQoKR5yhvezIAAxyJOeVng7wzz9cgeb2ThFNTVae1WgE
 eTjQ3/eIGgZ7FMi4g2hD/DOamt+JyVlJTh2VNz3g06DrE+7PATkh7Z0R09fFZ/KI
 bO3rjkv0L3ZKyOZ78b+iOGv97tKm3PcR/jVDqUg3/mjTX/778tH/HdKaC4IWc3SX
 dNr0aifkKAQsyrCaBQIQPkptizjZgyhz3Gw5MtX1P1m4JXx7aA5DvctZE8gVkd55
 0fRhynxvhoDdhXtasAq4VNSDPdiWZw==
 =CljO
 -----END PGP SIGNATURE-----

always go to the next step

even if this step didn't receive all of the replies, or if
this step didn't reach it's expected PPS.

Then once we reach maximum PPS, go to the draining state, so that
it stops.

Alan T. DeKok at 2020-03-10T19:44:34Z
Files modified:
	* src/lib/io/load.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/68dce8abe3298da9242f21c3dc69f5fb395c101d
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQIzBAABCAAdFiEE6VbEmJeQrF8361hu/6TVgp+218oFAl5n3P0ACgkQ/6TVgp+2
 18pUDg//VQECq/fNcMOjhfyRtOA4GGqAEM/DWJ5X3/HF3N2nM5s+VgRPiFO+sT7s
 t7k457wuGgHcLA9MEBCo3etwnqtk0kFlXw3OmmQYN7BKwhpEkeiaxmWN3v32jmhj
 bP4ZPlhEf0jcHzG9t1HfqDfwwoj6cEcKvix5zaZoTiQMhui1krE8GpsBAwwl/NeF
 YNgfImYbZFu49FYg/vmp5uU4Xf8Y3q8rI5a/3HmlGYcc0DwgrOXB6pv+scN6PoHS
 jfkfAuD7eY5/Uonpm/ACNiCEtWjHmyAOgee3Lom0+oBKbG2znso9mz/34oWUfN0j
 sIddbsBggxo+dLe06DAWgo2ki4suTAUSoFH8O9ccETPdqRkubBNAD0rAQ+SXs/Pp
 wHk2WyLSavQ8E6IUq/qpd3UwmVcKj2wtYkdbvLV5m1RY7rIu0Ay+cEEaKwG4mWwT
 8vXhidmmftI1pDNO/FCFspjJO+jgYZIw6H8sRIy15Qzd8OjVqQKAw50esUYl6vVO
 TPeOMQpFFhySFRp4oIfIEPNJ+p2xCb4khi1odqLB153RoZO0r1lTbMyqy6XheQve
 KgnckwhqyrcjuNs6KD7NcU1SOTTIBIUgqPm3EIEzTeGpY+yYYnQOtz/TYThZwwNc
 odK62tZaP1EeakmNbHeoLKFfVK4xHyyTIwvnbAdVldMXaFCBgSM=
 =H6Qx
 -----END PGP SIGNATURE-----

If the trunk it doing work when the event loop is exiting that's a pretty major bug

Arran Cudbard-Bell at 2020-03-10T18:31:25Z
Files modified:
	* src/modules/rlm_radius/rlm_radius_udp.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/67e08bca7ef598b6fc5a7a6a530f624d1830c07d
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 wsBcBAABCAAQBQJeZ8+4CRBK7hj4Ov3rIwAAdHIIAKJZMtHLGHnf+7Kr0wLCgtO3
 mrwFjIGBUenGx4buVNzbPwSMyRBtoHBn9ydPkdJpuoXUSYSDu4gUyUmi5KuDdByI
 YXMfL+fc/BeUqQ++7y/sUZw2pwcsKZdyejJOULtq3Oz7EJgG+RTAcqwo30/wBMGC
 94aAhP0yrVN+ZvEbA6jgDAtwLnQLUGcmsjVKcHjru3svZKo9rY9/6tXLN6/PbRad
 PkBrUOfSZC7bgb7/TvgU66EIDusuCetZZHmjz39chleenYrKiSGNSklss9kxSAxJ
 mKDqRKFTc5B5Myjc0rMcvgCKo13wsVGuvkD7uiYcipJLNWsmLRkc90Eh5x22vZ8=
 =FBuN
 -----END PGP SIGNATURE-----

rlm_redis: Add missing 'database' parameter (#3317)

Jorge Pereira (via GitHub)@2020-03-10T17:34:48Z
Files modified:
	* raddb/mods-available/redis

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/d93468a2142d1a849a52703a44ea8243b41c42bc
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl5nyz8ACgkQfQ55zXdi
 Hs0pwgf/c9ZR/QecP51M/YnPgqsNFMxexCVcOEQM9Auw8qG7d1P9O4iBQ33/F2yE
 CVPQvwKmqGEKip27C+oflWx3OLyWuRw43O0QT7zQJFZqP4s1C0rYv0ugfK/JDH7/
 r2q20z6le88OjYR7sFtrKbJOACzPh495ouQeQiFTrzgUX0OWY36rm4K1GG7ByZVv
 wNL8zdoQ7OBmeTqty1Z0qITvUglELO3WWz9HXOFjmMr/Eu3cWOE+4T4SljkuykUC
 ylw8LAStM4P0fZw3vZCxwnhBoT6PPDEK+Oji+Zivp9zhufCuk8fbhQWu8KZxRU7t
 grj68Kf7IGcdt9sCPZfLdq77JFreBQ==
 =ywee
 -----END PGP SIGNATURE-----

stop doing work if the event loop is exiting

and therefore don't crash...

Alan T. DeKok at 2020-03-10T17:15:30Z
Files modified:
	* src/modules/rlm_radius/rlm_radius_udp.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/31f817f01386a5505248ef9de463185632fbae89
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl5noZAACgkQfQ55zXdi
 Hs0sdAf9FGVK0PFGDkGVCPQ+5yqKlhHClZB7cf6oQptxJ6sl37mTJsgz33cbIRtP
 uLwbaRVNgAx6BzW+Uxt6+kjZBRbJ8R+EExO/J88mUk3NdQGSavCCXa6biuM9konD
 Nru8sV8DtVXXnk74vIuUcShfdI9sOASxwkgB8bXFsxYP81myWKn+5ddRQkGDwRYK
 fWaYmR4SubR0HK/4aEakr88DcpkRMVtAXyS1qsyeYPJgMEhS3t3h1EH1REZlrTyM
 34+auxjivtsBTR3MoPDdLqgNGTQELIzU8nX/wwSfKDBymokdMvOGoQwBY0qRsMrx
 hbJhypkYY8h3ArUYr8gmiOpBzC9yiA==
 =yDGD
 -----END PGP SIGNATURE-----

signed / unsigned int issues

Alan T. DeKok at 2020-03-10T14:17:40Z
Files modified:
	* src/protocols/radius/encode.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/91a22d0a6dd41e04c3b230c259cd0762fd03ff6e
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl5noB8ACgkQfQ55zXdi
 Hs1h7wf/QT5jVnRiJ+mKLmKZe3C7j7qEVptGpfv1/r47mPGFpabemN3zg6JbalGj
 nl2XSi3UPDwY2zT6noZYa9DIRsY2y9RkQJycAl41xq0hQ8nGH4+9qQlUZm3Pv8zC
 ZL0oYpwXgqbUK2vSjcDln/ZTfnNKMZtBjfO/wEvkxhpeQJxeSSDFH/yAxCLhuc6t
 Tiww2PuJ9wjcBzhICn+D0c9myAmEWHxHyTfusxW/pgbyNX87fmnRr3n6S3r5vhFo
 cC1iGUpgsbaQGgCSrRcVNxsUgvIT313e8vukhgpnLP/WpDKtuj65ta1IuE6LjCaN
 PUhgCiJmaF4h/DZGck7aj1XxzCwDQQ==
 =hHKd
 -----END PGP SIGNATURE-----

tags of 0 can be omitted when printing

Alan T. DeKok at 2020-03-10T14:11:35Z
Files modified:
	* src/lib/util/pair.c
	* src/tests/unit/protocols/radius/rfc2868.txt
	* src/tests/unit/protocols/radius/tunnel.txt

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a7a9534e6418b52aa19b08ca0d28ca43824d3b63
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl5nniUACgkQfQ55zXdi
 Hs1NKAgAi22W0DCCOlD2qCGDyXIfqYTxC8IuOEgZk/WlgGVnEzn4+hmGW5E8SyXi
 IvvW9Ul2FD+2c7qX3B/7pfaKrcpI/vmOMCXQ/piw9vj3N1S9NeE3ahqqnaV01o7e
 28bLst6t8C9rW9+KubEbjJUe/6oqV53mKciLCbVW/qXmql6b6aI0uHeJ8zvXJ7BU
 mQdCKCfH6LXh/GCiwW6aTosBESjUsD/CLW2uT3nB6Xxh3kvIYOOuPWERw3xrgUv9
 LblD7C5sRZm12RYRqEEqQMFEVjOL2LdUkBUN3KtLSsk741bsfoRCXRjzs/O3GFWa
 TuKwCMcdgSJJaAcSs1z0zsPU1UAf3g==
 =PuHY
 -----END PGP SIGNATURE-----

add unit tests for Tunnel-Password

now that we have seeded randomness

Alan T. DeKok at 2020-03-10T14:03:03Z
Files modified:
	* src/tests/unit/protocols/radius/rfc2868.txt

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/e8f1e87735f1cdd79913658ddfa36c5b1e4c881e
====== 
gpgsig -----BEGIN PGP SIGNATURE-----

 iQEzBAABCAAdFiEE8n1lTTL4FC4LtEWpfQ55zXdiHs0FAl5nng8ACgkQfQ55zXdi
 Hs2avAf/ewswH+6MS4f01svZmP08dCff8w7Ugc3GWd7A5WA7pLkZVQJ6+eqX2q/T
 z/oIOVx1aOu8AvC3B52lJ/Yq2GTvWB6SuyZFY1GflAZE1D+oaHq77SDlYSaBZ0vx
 DFW/6Cy7uXJUYufu52+5jW8Az03ZEqRxt6/GAFsjCYNWT3XYT/+NRXs3TiewNa6I
 kOGCc8znc2oXHPShJ6JHbvg4CC+TcYiXykUM7sJv56AkgyCxt1PN3k/bNeD+iZbe
 ZXEFHVl6xJ9GQmWls5gd5M9+jzK+oOoGOv0RPMpoZ9bV7aQEGN9B0FiKcLKnmKt+
 KFhCuZYHjaOo/8ZTO0CsdwZFjvsQRQ==
 =COuI
 -----END PGP SIGNATURE-----

use random padding, instead of zeros

that way if the salts are the same, the encoded data will still
be all different.

RFC 2868 Section 3.5 recommends that the padding is all zeros.
But the field already contains a length, so it's not necessary.

And for CoA-Request packets, the "encyption" of the password
is done via the request authenticator, which is all zeros.
So we rely only on the salt for security.  Which is small, and
therefore terrible.

Changing to random padding makes it harder to figure out what's
going on.

Alan T. DeKok at 2020-03-10T14:01:00Z
Files modified:
	* src/protocols/radius/encode.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/cb537354a3d719fce068a9e5cfe8e628d721eae7
====== 
-- 
This commit summary was generated @2020-03-11T00:00:03Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed).